From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37721) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1elg8X-00025I-Sl for guix-patches@gnu.org; Tue, 13 Feb 2018 14:21:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1elg8U-0002Gf-OM for guix-patches@gnu.org; Tue, 13 Feb 2018 14:21:05 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:33905) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1elg8U-0002GY-Im for guix-patches@gnu.org; Tue, 13 Feb 2018 14:21:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1elg8U-0007xr-Cg for guix-patches@gnu.org; Tue, 13 Feb 2018 14:21:02 -0500 Subject: [bug#30446] [PATCH 2/3] gnu: Add intelmetool. Resent-Message-ID: Date: Tue, 13 Feb 2018 14:20:31 -0500 From: Leo Famulari Message-ID: <20180213192031.GB31517@jasmine.lan> References: <20180213180001.4339-1-dannym@scratchpost.org> <20180213180145.4412-1-dannym@scratchpost.org> <20180213180145.4412-2-dannym@scratchpost.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="p4qYPpj5QlsIQJ0K" Content-Disposition: inline In-Reply-To: <20180213180145.4412-2-dannym@scratchpost.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Danny Milosavljevic Cc: 30446@debbugs.gnu.org --p4qYPpj5QlsIQJ0K Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Feb 13, 2018 at 07:01:44PM +0100, Danny Milosavljevic wrote: > * gnu/packages/flashing-tools.scm (intelmetool): New variable. > +(define-public intelmetool > + (let ((commit "1b64ae1119fc7891b043d5d29bf93859ef9dbfa1") > + (revision "0")) > + (package > + (name "intelmetool") > + (version (git-version "0.0" revision commit)) Same feedback about the version string as with the other coreboot-based package. > + (synopsis "Intel ME tools") > + (description "This package provides tools for working with Intel > +Management Engine (ME). You need to @code{sudo rmmod mei_me} and > +@code{sudo rmmod mei} before using this tool. Also pass > +@code{iomem=relaxed} to the Linux kernel command line.") Overall LGTM, but I don't think we should use the description as a source of copy-and-paste instructions. Does the package include any docs? --p4qYPpj5QlsIQJ0K Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAlqDOn8ACgkQJkb6MLrK fwi9hA//an88FPOSLIlECj3zRcIu/fdf9bXvLrtKCr/KGKBesQkBwP3tRDa5Z5d8 BzjYA8kkaI7vPSY9c/ulfUrv2Z2tf0irKT6rV6jAVIhHBFC4q1QTDQxzTdc5hVXj 2Jjjvydq0FRNKs6Qcj7Vl1U3Bx9q3obkS3DxOngbKptL0Io+NbQDxQIi2lwtWod6 DKKJa5pNnaYoWf16vvOcYQOCJfqN/7IttMNUe6RyvDOueqattCRanYP+ZcwfONvG k/Zj7/OfVP7CPf+a6t4f5P4lDsTu5KXFiHNScidvFovPb1HLpXNMT4GAZW1vUILB iwYCS6VlwOe6KoNqVJkpeYNhMSbTddDFMYcScu1gMqlpexJK5s849pZ+MY/ryd05 tTi92bNam3jZuNqJrAxcup1UgOzGaPgpfxAmWQXFR4CQHFCcZXapHxh5qKRd5+0F /wkEV9rCz8TM80DpgqCDYmLWVKnXmFDZMbWN7Bor9mQQzPKM8mMpFndL3lhakfNo 6LjKLWEs0UI1vO4pyEoZG0ln49qdZPRdWFEZzN0t5vujujAmTw2uPt1DxE+pWm6R iLkdm4xopVTJ4hgyaP0Or8Gc2rjjrOQ2rVm+CaTlj0lumMuyD5MDKXadqTnyAST4 TUy3VoGdeT1HRZfRnEhoXngkTpfTQdaLfusUuGO0fnUJ6H7tFYo= =UcT7 -----END PGP SIGNATURE----- --p4qYPpj5QlsIQJ0K--