From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: Re: Re: [PATCH] gnu: Add python2-gyp Date: Mon, 5 Feb 2018 18:11:25 -0500 Message-ID: <20180205231125.GA22963@jasmine.lan> References: <1517631607.29145.3.camel@gmail.com> <87bmh3d17c.fsf@gnu.org> <1517870390.6194.8.camel@gmail.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="+g7M9IMkV8truYOl" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:60132) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eipvC-0003gA-F1 for guix-devel@gnu.org; Mon, 05 Feb 2018 18:11:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eipv9-0000Mg-6w for guix-devel@gnu.org; Mon, 05 Feb 2018 18:11:34 -0500 Content-Disposition: inline In-Reply-To: <1517870390.6194.8.camel@gmail.com> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: dpg Cc: "guix-devel@gnu.org" --+g7M9IMkV8truYOl Content-Type: multipart/mixed; boundary="pf9I7BMVVzbSWLtt" Content-Disposition: inline --pf9I7BMVVzbSWLtt Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Feb 05, 2018 at 05:39:50PM -0500, dpg wrote: > Sending a new patch, this will apply cleaner and has an actually good com= mit > message :-)=20 Thanks! But it still didn't apply :) > From 300c37a8d9818cfc1a6315d2113cf58b110e1664 Mon Sep 17 00:00:00 2001 > From: DoublePlusGood > Date: Mon, 5 Feb 2018 17:26:34 -0500 > Subject: [PATCH] gnu: python: Add python2-gyp >=20 > * gnu/packages/python.scm: Added python2-gyp library. > + ;; Google does not release versions, > + ;; based on second most recent commit date. > + (version "2017-10-11") As described in the manual section Version Numbers, we handle versioning of version control checkouts in a specific way: https://www.gnu.org/software/guix/manual/html_node/Version-Numbers.html#Ver= sion-Numbers This allows us to ensure that the versions always increase and can be used to refer back to the upstream version control repository. At least in Git, dates are not meaningful. They can be set to anything with the --date parameter. We also have the special helper functions git-version and git-file-name to make it easy to use the standard versioning scheme. I standardized the version and source file-name as in the attached diff, standardized the commit message, updated the copyright date, and pushed the result as commit 956ba99cb799889e0a0bc0f657f4e31b4f830775. --pf9I7BMVVzbSWLtt Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: attachment; filename=gyp-diff Content-Transfer-Encoding: quoted-printable diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm index f77491a90..45ef7b5b6 100644 --- a/gnu/packages/python.scm +++ b/gnu/packages/python.scm @@ -46,7 +46,7 @@ ;;; Copyright =A9 2017 Muriithi Frederick Muriuki ;;; Copyright =A9 2017 Brendan Tildesley ;;; Copyright =A9 2018 Fis Trivial -;;; Copyright =A9 2017 Ethan R. Jones +;;; Copyright =A9 2018 Ethan R. Jones ;;; ;;; This file is part of GNU Guix. ;;; @@ -12420,30 +12420,31 @@ style guide, even if the original code didn't vio= late the style guide.") (package-with-python2 python-yapf)) =20 (define-public python-gyp - (package - (name "python-gyp") - ;; Google does not release versions, - ;; based on second most recent commit date. - (version "2017-10-11") - (source - (origin - ;; Google does not release tarballs, - ;; git checkout is needed. - (method git-fetch) - (uri (git-reference - (url "https://chromium.googlesource.com/external/gyp") - (commit "5e2b3ddde7cda5eb6bc09a5546a76b00e49d888f"))) - (sha256 - (base32 - "0fr7nxcrk292djmxzpcjaphnsd123k31gp8jnd91vwknhq6snmv9")))) - (build-system python-build-system) - (home-page "https://gyp.gsrc.io/") - (synopsis "GYP is a Meta-Build system") - (description - "GYP builds build systems for large, cross platform applications. -It can be used to generate XCode projects, Visual Studio projects, -Ninja build files, and Makefiles.") - (license license:bsd-3))) + (let ((commit "5e2b3ddde7cda5eb6bc09a5546a76b00e49d888f") + (revision "0")) + (package + (name "python-gyp") + (version (git-version "0.0.0" revision commit)) + (source + (origin + ;; Google does not release tarballs, + ;; git checkout is needed. + (method git-fetch) + (uri (git-reference + (url "https://chromium.googlesource.com/external/gyp") + (commit commit))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "0fr7nxcrk292djmxzpcjaphnsd123k31gp8jnd91vwknhq6snmv9")))) + (build-system python-build-system) + (home-page "https://gyp.gsrc.io/") + (synopsis "GYP is a Meta-Build system") + (description + "GYP builds build systems for large, cross platform applications. +It can be used to generate XCode projects, Visual Studio projects, Ninja b= uild +files, and Makefiles.") + (license license:bsd-3)))) =20 (define-public python2-gyp (package-with-python2 python-gyp)) --pf9I7BMVVzbSWLtt-- --+g7M9IMkV8truYOl Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAlp45J0ACgkQJkb6MLrK fwhXzg/+N2zIWIPAzj2BkonrMwuiIvs//PiaXZJjLuF2IXy1uIaIEvauVSqBc9ZV kIXdDfAF4kOqEO8Fi3Nsfnd8B1wWvgSoxbDEHesnz/7UZQFIOuzHQBP+9X1OA2lo AAaWEIpY3zg79veFbbdllvc9KO185TDQmp/JbQfhFPhPAyGrY0M4nrK7TF/0dcbx J0U4z7bDOOW7apH5ZvJ26PS9NgqIda/5Jt1sOCo512i5ssga/19386bVwS4jo5B2 OHWILkwTdNM7dnPP0crarzqxksUvQgBvRCF6uioHMx4mye4QLSlvDp5XGnoer6dm gmSBPiX4o/pnuW9aR50dEhUkLMxAQTD4t/cacUX9ifEiavOXWJmt4ZYaolB3RUcL /iOqT+y+c0I89gJ+NWQKCg5dPCqpK8p1HoU4ssueqjlbP0lyUSgRzvvEgxtDZ+/a Hem/i6uhibhKZoT4Z4H4h0vVCPV8HiMfbseV4pPreQDFtXVIz9n7d77nzmhMLp6Z owc0CF9qUbg2djXINw/ixIXwmAok2BB7jYsOVhkjaisG7+n99m2yxGgmFZgkTtf7 a1VHBDtwkcH5Im9H3tYVFT7gZKpADMjG3o9jLraUMeEPG+Y35nr8jvOxsEZ8v+JT mG2tBNLz6s3bj8ieUNJHTStLkh++2pskk0VvHim5R4xRAgU6IhI= =EXrr -----END PGP SIGNATURE----- --+g7M9IMkV8truYOl--