From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35741)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eiDnV-00016Z-QL
	for guix-patches@gnu.org; Sun, 04 Feb 2018 01:29:06 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eiDnS-00088Y-M4
	for guix-patches@gnu.org; Sun, 04 Feb 2018 01:29:05 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:48271)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1eiDnS-00088S-Il
	for guix-patches@gnu.org; Sun, 04 Feb 2018 01:29:02 -0500
Subject: [bug#29359] [PATCH 13/31] gnu: Add java-joda-time.
Resent-Message-ID: <handler.29359.B29359.15177257302008@debbugs.gnu.org>
Date: Sun, 4 Feb 2018 07:28:46 +0100
From: =?UTF-8?Q?Bj=C3=B6rn_?= =?UTF-8?Q?H=C3=B6fling?=
	<bjoern.hoefling@bjoernhoefling.de>
Message-ID: <20180204072846.68571999@alma-ubu>
In-Reply-To: <20171119175805.902-13-julien@lepiller.eu>
References: <handler.29359.B.151111429223890.ack@debbugs.gnu.org>
	<20171119175805.902-1-julien@lepiller.eu>
	<20171119175805.902-13-julien@lepiller.eu>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: 29359@debbugs.gnu.org

On Sun, 19 Nov 2017 18:57:47 +0100
Julien Lepiller <julien@lepiller.eu> wrote:

> * gnu/packages/java.scm (java-joda-time): New variable.
> ---
>  gnu/packages/java.scm | 64
> +++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed,
> 64 insertions(+)
>=20
[..]
> +       (modify-phases %standard-phases
> +         (add-after 'build 'build-resources
> +           (lambda _
> +             (mkdir-p "build/classes/org/joda/time/tz/data")
> +             (mkdir-p "build/classes/org/joda/time/format")
> +             ;; This will produce an exception, but it's all right.
> +             (zero? (system* "java" "-cp"
> +                             (string-append "build/classes:" (getenv
> "CLASSPATH"))
> +                             "org.joda.time.tz.ZoneInfoCompiler"
> +                             "-src"
> "src/main/java/org/joda/time/tz/src"
> +                             "-dst"
> "build/classes/org/joda/time/tz/data"
> +                             "africa" "antarctica" "asia"
> "australasia"
> +                             "europe" "northamerica" "southamerica"
> +                             "pacificnew" "etcetera" "backward"
> "systemv"))
[..]

I'm not convinced about this.

* Why is the exception "all right?"
* If it is all right, mention the specific exception you think that is
  OK: "java.io.IOException: Resource not found:
  "org/joda/time/tz/data/ZoneInfoMap" "
* And if it throws an exception, does it actually do anything for us?
* Finally, remove the (zero?..), as the result ignored, the result of
the sourrunding lambda will be the final statement, the #t.

Bj=C3=B6rn