From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59930) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ee5RL-0000or-1W for guix-patches@gnu.org; Tue, 23 Jan 2018 15:45:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ee5RH-0004mw-Az for guix-patches@gnu.org; Tue, 23 Jan 2018 15:45:06 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:60382) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ee5RH-0004mq-7B for guix-patches@gnu.org; Tue, 23 Jan 2018 15:45:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ee5RH-0008QZ-1m for guix-patches@gnu.org; Tue, 23 Jan 2018 15:45:03 -0500 Subject: [bug#30214] [PATCH 03/10] gnu: Add go-github.com-jessevdk-go-flags. Resent-Message-ID: Date: Tue, 23 Jan 2018 15:44:51 -0500 From: Leo Famulari Message-ID: <20180123204451.GG6750@jasmine.lan> References: <87h8rd4nxg.fsf@cbaines.net> <20180122210830.28924-1-mail@cbaines.net> <20180122210830.28924-3-mail@cbaines.net> <20180122215447.GD15170@jasmine.lan> <87vafs5p79.fsf@cbaines.net> <20180123202935.GD6750@jasmine.lan> <87r2qg5n74.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="p7qwJlK53pWzbayA" Content-Disposition: inline In-Reply-To: <87r2qg5n74.fsf@cbaines.net> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Christopher Baines Cc: 30214@debbugs.gnu.org --p7qwJlK53pWzbayA Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jan 23, 2018 at 08:34:23PM +0000, Christopher Baines wrote: >=20 > Leo Famulari writes: >=20 > > On Tue, Jan 23, 2018 at 07:51:06PM +0000, Christopher Baines wrote: > >> Leo Famulari writes: > >> > On Mon, Jan 22, 2018 at 09:08:23PM +0000, Christopher Baines wrote: > >> >> * gnu/packages/golang.scm (go-github.com-jessevdk-go-flags): New va= riable. > >> > > >> >> + (add-after 'unpack 'rename-archive > >> >> + (lambda _ > >> >> + (rename-file > >> >> + ,(string-append "src/github.com/jessevdk/go-flags-" = version) > >> >> + "src/github.com/jessevdk/go-flags") > >> >> + #t))))) > >> > > >> > Should the go-build-system try to handle this automatically? > >>=20 > >> I believe this might be connected with what is in the source > >> tarball. Without this stage, the go-flags directory is called > >> go-flags-1.3.0, and this causes the build to fail [2]. > > > > Oh right, Go expects you to use Git checkouts instead of release > > tarballs. I bet it works if you do that. That kind of tarball is > > automatically created by GitHub per tag, and can't be disabled. > > > >> I'm not sure about the wider context, but it would be good to handle > >> this automatically. > > > > So, I think the build system doesn't need to handle this case. >=20 > Ok, would it be more appropriate to use a git checkout, rather than a > tar archive for these packages then? Yeah, I bet you can avoid the rename-archive phases if you use a Git checkout. --p7qwJlK53pWzbayA Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAlpnnsMACgkQJkb6MLrK fwhsEg/+L1nAqEtB8qKNuh3hvlS6gqWhMHSZJY9UbnL14PfwJKAEwRWub6SDFKyH 2wETipxkeByeafAuO2ARVp/kgQXZqF0jyYuta+Nvk9f9M4KoN0KlyCFNhpcCACSl bDW4HvduWHI2Wi1qiJ8gfvIvWceczJVbH6hGrvz92E1mkgFNNMtCRU04Gj41NPzl s63WQhBW7pR4HF+BaNMS6HzeD/QGKs5M8QE7+aztJiqffoNlK0fWFutxdn/9thLL ehuH6FFyuKZhimDBlcMzJnSgzIg0VhpDboU6qAjWRfAyC9buqzQhuCd6u0UHoTUz xkVQ1KoZPRhR+DDzs5YY779qe5j6P9cYqnCemltravYCA8ZeGfi0pt2XDcYCa8Dj Dx6W+lQTsUG95RJd9DK3g7EtdwjRhKEOJwQboWJ2sDiWKqAt/vnl0QSpuhs7b7rm SvZjwuFEL3ZfssHAo3nQjP2o4EfAwHKme0pTjIgUWY5n/nbSVAYvZdpwL//gD8LW zimzyowMZ2T14zSsx0gYXPnUOLPIh8Ijvf2oqedZrvb5qm9+Gs4AAW+51Hnvo3Y3 eWtuOukex2alVsr6WsF+yDOEhckscmpacxJXqY05afWFI79D8wycZ27BBM8xWBTu h5wAZuu+/HZQrppqNhQvGqQAvvzyWjOQ2igu7zEVeQkgPirzV2A= =Zyyb -----END PGP SIGNATURE----- --p7qwJlK53pWzbayA--