From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52459) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1edk3V-0001Oe-Qk for guix-patches@gnu.org; Mon, 22 Jan 2018 16:55:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1edk3R-0004HW-Vl for guix-patches@gnu.org; Mon, 22 Jan 2018 16:55:05 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:58986) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1edk3R-0004HS-Rr for guix-patches@gnu.org; Mon, 22 Jan 2018 16:55:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1edk3R-0000Ut-LA for guix-patches@gnu.org; Mon, 22 Jan 2018 16:55:01 -0500 Subject: [bug#30214] [PATCH 03/10] gnu: Add go-github.com-jessevdk-go-flags. Resent-Message-ID: Date: Mon, 22 Jan 2018 16:54:47 -0500 From: Leo Famulari Message-ID: <20180122215447.GD15170@jasmine.lan> References: <87h8rd4nxg.fsf@cbaines.net> <20180122210830.28924-1-mail@cbaines.net> <20180122210830.28924-3-mail@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Km1U/tdNT/EmXiR1" Content-Disposition: inline In-Reply-To: <20180122210830.28924-3-mail@cbaines.net> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Christopher Baines Cc: 30214@debbugs.gnu.org --Km1U/tdNT/EmXiR1 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Jan 22, 2018 at 09:08:23PM +0000, Christopher Baines wrote: > * gnu/packages/golang.scm (go-github.com-jessevdk-go-flags): New variable. > + (add-after 'unpack 'rename-archive > + (lambda _ > + (rename-file > + ,(string-append "src/github.com/jessevdk/go-flags-" version) > + "src/github.com/jessevdk/go-flags") > + #t))))) I notice a few of these changes in your patch series. Can you give some detail about what's going on? If someone were developing with this library in the typical Go way, outside of Guix, would they have a problem here? Should the go-build-system try to handle this automatically? --Km1U/tdNT/EmXiR1 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAlpmXacACgkQJkb6MLrK fwgIGxAAsDAH5kAvUDf58Kw/Yx2T0cRzLG8Ed5CKyh+mNixEvvl2he9xQYZvswHq oEfWbM3qTqUQMt5Zk3b9KDUgFD9GsFFH0YJMKWhenN0tVpaI+ihpdqcjDYxUDs/J UGZeWcbBVUPjLVinYjAxxJNzw4zs9JhNBqawSa+Hq2aYT+0O473a29h7rVQ5BJ06 T72Vulj9G1dCQOj50QY1qYU2RjUOrisAjI4KERkhcQWFKIMVR//2t0Snn9oXe/mT hQGXa724O/sMrphdhu3KMgIuFeNCA0TM/fnsc39xii/UsWrqNT8JT/8o0AIyV8hq LGRVYSc+XCntvY3l3sN6QQnlypQV47HxpXOYm+if/NklptqGpbz//NXtg6pTLXa6 yigsHHVksFOR+YF+pwczJHbtmCiOrZ7fNRMIClyPpbbsSXJF2fX3O0cfIhbLG66e ZV6MVa5sevTxrErAUoqX1lyq8fnn0XLRvKut6xjSRI/RK1xjeCvnbCOfcNEme8X9 t96PQss4cqgq5evV2qJgatX1TqqJFJgMzFELlzetRdQoOmK5ZpW79b5zAwyPR0qD v+iWANw3TzF3wWqtSYJZh/gkUGo1lvY7EfxiP7DuAhzmOgBn2/JZInDXB6JCyaqK FsGU3AOxSjkNLkCPeqcudR4baTRUy3kOc+i/xPashyHo/RmGzAQ= =UQRP -----END PGP SIGNATURE----- --Km1U/tdNT/EmXiR1--