From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45843) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eX8Sz-0000iU-Dg for guix-patches@gnu.org; Thu, 04 Jan 2018 11:34:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eX8Sw-0004eu-7h for guix-patches@gnu.org; Thu, 04 Jan 2018 11:34:05 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:55425) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eX8Sv-0004ej-VL for guix-patches@gnu.org; Thu, 04 Jan 2018 11:34:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eX8Sv-0003PS-O9 for guix-patches@gnu.org; Thu, 04 Jan 2018 11:34:01 -0500 Subject: [bug#29950] [PATCH] gnu: Add instantmusic. Resent-Message-ID: Date: Thu, 4 Jan 2018 11:33:42 -0500 From: Leo Famulari Message-ID: <20180104163342.GA2127@jasmine.lan> References: <151491839599.22521.7205938574875528259.stgit@sandburg> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="5vNYLRcllDrimb99" Content-Disposition: inline In-Reply-To: <151491839599.22521.7205938574875528259.stgit@sandburg> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Stefan =?UTF-8?Q?Reich=C3=B6r?= Cc: 29950@debbugs.gnu.org --5vNYLRcllDrimb99 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jan 02, 2018 at 07:39:56PM +0100, Stefan Reich=F6r wrote: > * gnu/packages/music.scm (instantmusic): New variable. Thanks for this patch Stefan! I have some comments... > + (version (string-append "0.1-" revision "." (string-take commit 9)= )) I noticed the latest upstream release is tagged "v1.0" rather than "0.1". Also, it's convenient and more maintainable to create the version of Git-based packages like this: (version (git-version "1.0" revision commit)) > + (file-name (string-append name "-" version "-checkout")) And similarly for the file-name: (file-name (git-file-name name version)) Those two procedures come from (guix git-download). > + (arguments > + '(#:modules ((guix build python-build-system) > + (guix build utils) > + (srfi srfi-26)) > + #:phases (modify-phases %standard-phases > + (add-before 'build 'change-directory > + (lambda _ > + (chdir "instantmusic-0.1") > + ;; Fix some read-only files that would cause a bui= ld failure > + (for-each (cut chmod <> #o644) > + (find-files "instantmusic.egg-info" > + "PKG-INFO|.*\\.txt")) > + #t))))) I guess that changing the build directory and chmod-ing those files are required for their own reasons, right? So they should be in separate build phases. Can you send an updated patch? --5vNYLRcllDrimb99 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAlpOV2IACgkQJkb6MLrK fwg6Vg//a5/fHgS+h1Mf8IAdmO6JHkNhU2NxPGhJ4LfocoYsRu6PPlBLiq+hABYw VNy/oeQMQaLSM58DEbJvg7cI5pi2t+toZ2qEbArEGh6Bll4j02kuiqc1gwbI8mpU b+7gDqxOpbaYku12VHyGbydqPXbtNK3UtdWT2ecAdexZEz6EzpXHXl4HUOLTafdS G1V21H7tLAz9kbjS72d26T46NUm3lKxszqajlG/FhKLAUMCzdYhYAw7fH6br3fBW +KyfM6s6e+XYQBDwLl2Uccp0rJtAk45ziiq4vhGmB5aIGZGrZhBFh6XNiS2hMUKJ u/naFQQZEKQcbO9qOB+x7v7XwFK8rXiR9cTlrPptYQjmb/0Ck246z0r0kKcOxPYo 4e2V084nZBW7KiC5A8exFgpOo1Sg8Gtp8Ci5LCCNyv14DYelOY1p1IEp01RxUDC3 67Fqyfii/oq1UxKbLIzK3ADJ/NAkNtHDKU7XmsXqD/7+IYNJJwu7JtwzENwMJdHi ngcU0g6Cc+GBfK+/bIZY+8kHoQuqxbqFkbqahFkRfD1cEOLDIyBf2Y6MS0zaQbJX UW9iMH9WcYnBHhwikHDOeWlHrPB5mrVLCOtRJqv43hDViW26NNwfDtxkOQz8HN3Q nB/Cpef8n7nHp3dR3Z/CBni4A/gApEEpwwa2pvO6p38bf5Ts9tg= =oesk -----END PGP SIGNATURE----- --5vNYLRcllDrimb99--