[bug#29973] [PATCH] gnu: newsbeuter: Supersede.

[bug#29973] [PATCH] gnu: newsbeuter: Supersede.

[Tobias Geerinckx-Rice]

* gnu/packages/syndication.scm (newsbeuter)[properties]: Mark as superseded
by newsboat.
---

Guix,

Newsbeuter has been sufficiently (unpatched-CVE-level) stagnant for long
enough that the last maintainer done went and forked it as Newsboat[0].

While our Newsbeuter shouldn't be outright vulnerable (thanks to Leo and
Efraim), and newsbeuter.org might be only temporarily off-line, what do
we think about blessing its successor? Surely it's but a one-line patch.

Kind regards,

T G-R

[0]: https://groups.google.com/forum/#!topic/newsbeuter/RPtlWX8CPGU

 gnu/packages/syndication.scm | 97 ++++++++++++++++++++++----------------------
 1 file changed, 49 insertions(+), 48 deletions(-)

diff --git a/gnu/packages/syndication.scm b/gnu/packages/syndication.scm
index 086b132b7..6bfbe77cf 100644
--- a/gnu/packages/syndication.scm
+++ b/gnu/packages/syndication.scm
@@ -31,54 +31,6 @@
   #:use-module (gnu packages xml)
   #:use-module (gnu packages web))
 
-(define-public newsbeuter
-  (package
-    (name "newsbeuter")
-    (version "2.9")
-    (source
-      (origin
-        (method url-fetch)
-        (uri (string-append "https://newsbeuter.org/downloads/newsbeuter-"
-                            version ".tar.gz"))
-        (patches (search-patches "newsbeuter-CVE-2017-12904.patch"
-                                 "newsbeuter-CVE-2017-14500.patch"))
-        (sha256
-         (base32
-          "1j1x0hgwxz11dckk81ncalgylj5y5fgw5bcmp9qb5hq9kc0vza3l"))))
-    (build-system gnu-build-system)
-    (arguments
-     '(#:phases
-       (modify-phases %standard-phases
-         (replace 'configure
-           (lambda _
-             (substitute* "config.sh"
-               ;; try to remove this at the next release
-               (("ncursesw5") "ncursesw6"))
-             #t)))
-       #:make-flags (list (string-append "prefix=" (assoc-ref %outputs "out")))
-       #:test-target "test"))
-    (native-inputs
-     `(("gettext" ,gettext-minimal)
-       ("perl" ,perl)
-       ("pkg-config" ,pkg-config)
-       ("ruby" ,ruby))) ; for tests
-    (inputs
-     `(("curl" ,curl)
-       ("json-c" ,json-c-0.12)      ; check whether json-c-0.12 can be removed
-       ("ncurses" ,ncurses)
-       ("stfl" ,stfl)
-       ("sqlite" ,sqlite)
-       ("libxml2" ,libxml2)))
-    (home-page "https://newsbeuter.org/")
-    (synopsis "Text mode rss feed reader with podcast support")
-    (description "Newsbeuter is an innovative RSS feed reader for the text
-console.  It supports OPML import/exports, HTML rendering, podcast (podbeuter),
-offline reading, searching and storing articles to your filesystem, and many
-more features.  Its user interface is coherent, easy to use, and might look
-common to users of @command{mutt} and @command{slrn}.")
-    (license (list license:gpl2+        ; filter/*
-                   license:expat))))    ; everything else
-
 (define-public newsboat
   (package
     (name "newsboat")
@@ -128,3 +80,52 @@ file system, and many more features.
 It started life as a fork of the currently unmaintained Newsbeuter.")
     (license (list license:gpl2+        ; filter/*
                    license:expat))))    ; everything else
+
+(define-public newsbeuter
+  (package
+    (name "newsbeuter")
+    (version "2.9")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://newsbeuter.org/downloads/newsbeuter-"
+                           version ".tar.gz"))
+       (patches (search-patches "newsbeuter-CVE-2017-12904.patch"
+                                "newsbeuter-CVE-2017-14500.patch"))
+       (sha256
+        (base32
+         "1j1x0hgwxz11dckk81ncalgylj5y5fgw5bcmp9qb5hq9kc0vza3l"))))
+    (build-system gnu-build-system)
+    (arguments
+     '(#:phases
+       (modify-phases %standard-phases
+         (replace 'configure
+           (lambda _
+             (substitute* "config.sh"
+               ;; try to remove this at the next release
+               (("ncursesw5") "ncursesw6"))
+             #t)))
+       #:make-flags (list (string-append "prefix=" (assoc-ref %outputs "out")))
+       #:test-target "test"))
+    (native-inputs
+     `(("gettext" ,gettext-minimal)
+       ("perl" ,perl)
+       ("pkg-config" ,pkg-config)
+       ("ruby" ,ruby)))                 ; for tests
+    (inputs
+     `(("curl" ,curl)
+       ("json-c" ,json-c-0.12)      ; check whether json-c-0.12 can be removed
+       ("ncurses" ,ncurses)
+       ("stfl" ,stfl)
+       ("sqlite" ,sqlite)
+       ("libxml2" ,libxml2)))
+    (home-page "https://newsbeuter.org/")
+    (synopsis "Text mode rss feed reader with podcast support")
+    (description "Newsbeuter is an innovative RSS feed reader for the text
+console.  It supports OPML import/exports, HTML rendering, podcast (podbeuter),
+offline reading, searching and storing articles to your filesystem, and many
+more features.  Its user interface is coherent, easy to use, and might look
+common to users of @command{mutt} and @command{slrn}.")
+    (license (list license:gpl2+               ; filter/*
+                   license:expat))             ; everything else
+    (properties `((superseded . ,newsboat))))) ; unmaintained
-- 
2.15.0

[bug#29973] [PATCH] gnu: newsbeuter: Supersede.

[Leo Famulari]

[-- Attachment #1: Type: text/plain, Size: 711 bytes --]

On Thu, Jan 04, 2018 at 03:21:57AM +0100, Tobias Geerinckx-Rice wrote:
> * gnu/packages/syndication.scm (newsbeuter)[properties]: Mark as superseded
> by newsboat.
> ---
> 
> Guix,
> 
> Newsbeuter has been sufficiently (unpatched-CVE-level) stagnant for long
> enough that the last maintainer done went and forked it as Newsboat[0].
> 
> While our Newsbeuter shouldn't be outright vulnerable (thanks to Leo and
> Efraim), and newsbeuter.org might be only temporarily off-line, what do
> we think about blessing its successor? Surely it's but a one-line patch.
> 
> Kind regards,
> 
> T G-R
> 
> [0]: https://groups.google.com/forum/#!topic/newsbeuter/RPtlWX8CPGU

I think it's a good idea!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[bug#29973] [PATCH] gnu: newsbeuter: Supersede.

[Tobias Geerinckx-Rice]

[-- Attachment #1.1: Type: text/plain, Size: 413 bytes --]

Leo,

Leo Famulari wrote on 04/01/18 at 03:59:
>> While our Newsbeuter shouldn't be outright vulnerable (thanks to Leo and
>> Efraim), and newsbeuter.org might be only temporarily off-line, what do
>> we think about blessing its successor? Surely it's but a one-line patch.
>
> I think it's a good idea!

Good to hear! Any chance there's a less silly way to make the change?

Kind regards,

T G-R


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 248 bytes --]

[bug#29973] [PATCH] gnu: newsbeuter: Supersede.

[Leo Famulari]

[-- Attachment #1: Type: text/plain, Size: 586 bytes --]

On Thu, Jan 04, 2018 at 03:54:28PM +0100, Tobias Geerinckx-Rice wrote:
> Leo,
> 
> Leo Famulari wrote on 04/01/18 at 03:59:
> >> While our Newsbeuter shouldn't be outright vulnerable (thanks to Leo and
> >> Efraim), and newsbeuter.org might be only temporarily off-line, what do
> >> we think about blessing its successor? Surely it's but a one-line patch.
> >
> > I think it's a good idea!
> 
> Good to hear! Any chance there's a less silly way to make the change?

I'm not sure what's silly about it? Is there something that requires the
package definition to be moved?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[bug#29973] [PATCH] gnu: newsbeuter: Supersede.

[ng0]

[-- Attachment #1: Type: text/plain, Size: 970 bytes --]

Leo Famulari transcribed 1.6K bytes:
> On Thu, Jan 04, 2018 at 03:54:28PM +0100, Tobias Geerinckx-Rice wrote:
> > Leo,
> > 
> > Leo Famulari wrote on 04/01/18 at 03:59:
> > >> While our Newsbeuter shouldn't be outright vulnerable (thanks to Leo and
> > >> Efraim), and newsbeuter.org might be only temporarily off-line, what do
> > >> we think about blessing its successor? Surely it's but a one-line patch.
> > >
> > > I think it's a good idea!
> > 
> > Good to hear! Any chance there's a less silly way to make the change?
> 
> I'm not sure what's silly about it? Is there something that requires the
> package definition to be moved?

Can't we use the package property superseded? That's how I imagined 'superseded' would work.
What you are doing is dropping it as far as I remember the first email.

-- 
GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
GnuPG: https://c.n0.is/ng0_pubkeys/tree/keys
  WWW: https://n0.is/a/  ::  https://ea.n0.is

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[bug#29973] [PATCH] gnu: newsbeuter: Supersede.

[ng0]

[-- Attachment #1: Type: text/plain, Size: 829 bytes --]

Leo Famulari transcribed 1.6K bytes:
> On Thu, Jan 04, 2018 at 03:54:28PM +0100, Tobias Geerinckx-Rice wrote:
> > Leo,
> > 
> > Leo Famulari wrote on 04/01/18 at 03:59:
> > >> While our Newsbeuter shouldn't be outright vulnerable (thanks to Leo and
> > >> Efraim), and newsbeuter.org might be only temporarily off-line, what do
> > >> we think about blessing its successor? Surely it's but a one-line patch.
> > >
> > > I think it's a good idea!
> > 
> > Good to hear! Any chance there's a less silly way to make the change?
> 
> I'm not sure what's silly about it? Is there something that requires the
> package definition to be moved?

Oops. Nvm my last email.

-- 
GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
GnuPG: https://c.n0.is/ng0_pubkeys/tree/keys
  WWW: https://n0.is/a/  ::  https://ea.n0.is

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[bug#29973] [PATCH] gnu: newsbeuter: Supersede.

[Tobias Geerinckx-Rice]

[-- Attachment #1.1: Type: text/plain, Size: 878 bytes --]

Leo Famulari wrote on 04/01/18 at 18:34:
> Is there something that requires the package definition to be moved?

newsbeuter refers directly to ,newsboat. I get an error message if
newsboat isn't defined before newsbeuter.

> I'm not sure what's silly about it?

What I meant to say was: there might be a better way to do this than a
100-line patch, but this is the best I can come up with.

I don't really understand why

  (define-public foo (package ... (inputs `(("bar" ,bar)))))
  (define-public bar ...)

appears to work, while

  (define-public foo (package ... (properties `((superseded . ,bar)))))
  (define-public bar ...)

seems to fail.

Hence feeling a bit silly, and vague waving of hands, and whispering
‘probably macros I guess?’

I should really pick up that book about making elephants eat cake again.

Kind regards,

T G-R


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 248 bytes --]

[bug#29973] [PATCH] gnu: newsbeuter: Supersede.

[Ludovic Courtès]

Heya!

Tobias Geerinckx-Rice <me@tobias.gr> skribis:

> What I meant to say was: there might be a better way to do this than a
> 100-line patch, but this is the best I can come up with.
>
> I don't really understand why
>
>   (define-public foo (package ... (inputs `(("bar" ,bar)))))
>   (define-public bar ...)
>
> appears to work, while
>
>   (define-public foo (package ... (properties `((superseded . ,bar)))))
>   (define-public bar ...)
>
> seems to fail.

Indeed.

Unless you really want to keep the ‘newsbeuter’ definition around, you
can also simply:

  (define-public newsbeuter
    (deprecated-package "newsbeuter" newswhatever))

The only value in keeping the old definition is that power users can
still install it with “guix build -e”.

My 2¢,
Ludo’.

[bug#29973] [PATCH] gnu: newsbeuter: Supersede.

[Tobias Geerinckx-Rice]

Ludo',

Ludovic Courtès wrote on 08/01/18 at 00:13:
> Unless you really want to keep the ‘newsbeuter’ definition around, you
> can also simply:
> 
>   (define-public newsbeuter
>     (deprecated-package "newsbeuter" newswhatever))

Oh, perfect!

That is of course exactly what I was looking for, but I only knew
(and more importantly: grepped for) “superseded”...

> The only value in keeping the old definition is that power users can
> still install it with “guix build -e”.

I don't think that's appropriate here, so I'll use the above.

Thanks!

T G-R

bug#29973: [PATCH] gnu: newsbeuter: Supersede.

[Tobias Geerinckx-Rice]

Done in f26fa354f1d76ce9cbc43cc553637af3f0c34cc2.

Thanks,

T G-R