From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44117)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eWQLB-0008Cf-JQ
	for guix-patches@gnu.org; Tue, 02 Jan 2018 12:27:06 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eWQL8-0003RH-Vz
	for guix-patches@gnu.org; Tue, 02 Jan 2018 12:27:05 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:52936)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1eWQL8-0003R8-Rv
	for guix-patches@gnu.org; Tue, 02 Jan 2018 12:27:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eWQL8-0002dr-GQ
	for guix-patches@gnu.org; Tue, 02 Jan 2018 12:27:02 -0500
Subject: [bug#29856] [PATCH core-updates] guix: python-build-system:,
	Modify ".py" files in-place.
Resent-Message-ID: <handler.29856.B29856.151491399310120@debbugs.gnu.org>
Date: Tue, 2 Jan 2018 18:26:27 +0100
From: Danny Milosavljevic <dannym@scratchpost.org>
Message-ID: <20180102182627.16566e3c@scratchpost.org>
In-Reply-To: <86b45cc4-f8ef-95da-87f7-397db19c424e@crazy-compilers.com>
References: <86b45cc4-f8ef-95da-87f7-397db19c424e@crazy-compilers.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Hartmut Goebel <h.goebel@crazy-compilers.com>
Cc: 29856@debbugs.gnu.org

Hi Hartmut,

thanks for the review!

On Tue, 2 Jan 2018 17:13:15 +0100
Hartmut Goebel <h.goebel@crazy-compilers.com> wrote:

>   * it kills "from __future__ import", which must be the first import
>     statement (or even the first statement after any doc-string) to work.

... oops.

> Thus I suggest aiming to implement the solution discussed in that thread
> (see esp.
> <https://lists.gnu.org/archive/html/guix-devel/2017-11/msg00041.html>.

I like that approach. Nice...

> Beside of this, the patch suffers from some more issues. Sorry to say :-(
> 
>   * When converting PYTHONPATH into a list of python strings, these need
>     to be quoted properly.

I agree.

>   * The description (commit-message) of the patch is much to terse. It
>     should describe the the reason and implications. Esp. it should
>     describe the case this is fixing.

Sure.