[bug#29878] [PATCH] gnu: Add emacs-evil-smartparens.

[bug#29878] [PATCH] gnu: Add emacs-evil-smartparens.

[Arun Isaac]

* gnu/packages/emacs.scm (emacs-evil-smartparens): New variable.
---
 gnu/packages/emacs.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 3d5b67a70..3c920ff91 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -6551,3 +6551,27 @@ Feautures:
      "@code{evil-matchit} is a minor mode for jumping between matching tags in
 evil mode using @kbd{%}.  It is a port of @code{matchit} for Vim.")
     (license license:gpl3+)))
+
+(define-public emacs-evil-smartparens
+  (package
+    (name "emacs-evil-smartparens")
+    (version "0.4.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "https://github.com/expez/evil-smartparens/archive/"
+             version ".tar.gz"))
+       (file-name (string-append name "-" version ".tar.gz"))
+       (sha256
+        (base32
+         "1bwzdd3054d407d5j4m3njsbvmc9r8zzp33m32pj3b3irxrl68q0"))))
+    (build-system emacs-build-system)
+    (propagated-inputs
+     `(("emacs-evil" ,emacs-evil)
+       ("emacs-smartparens" ,emacs-smartparens)))
+    (home-page "https://github.com/expez/evil-smartparens")
+    (synopsis "Emacs Evil integration for Smartparens")
+    (description "@code{emacs-evil-smartparens} is an Emacs minor mode which
+makes Evil play nice with Smartparens.")
+    (license license:gpl3+)))
-- 
2.15.1

[bug#29878] [PATCH] gnu: Add emacs-evil-smartparens.

[Catonano]

[-- Attachment #1: Type: text/plain, Size: 2083 bytes --]

Hi Arun !

I linted and built your patch, it's ok

I didn't run it because I can't use Vi(m) so maybe it's better if someone
else tests this

2017-12-28 12:39 GMT+01:00 Arun Isaac <arunisaac@systemreboot.net>:

> * gnu/packages/emacs.scm (emacs-evil-smartparens): New variable.
> ---
>  gnu/packages/emacs.scm | 24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
>
> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
> index 3d5b67a70..3c920ff91 100644
> --- a/gnu/packages/emacs.scm
> +++ b/gnu/packages/emacs.scm
> @@ -6551,3 +6551,27 @@ Feautures:
>       "@code{evil-matchit} is a minor mode for jumping between matching
> tags in
>  evil mode using @kbd{%}.  It is a port of @code{matchit} for Vim.")
>      (license license:gpl3+)))
> +
> +(define-public emacs-evil-smartparens
> +  (package
> +    (name "emacs-evil-smartparens")
> +    (version "0.4.0")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "https://github.com/expez/evil-smartparens/archive/"
> +             version ".tar.gz"))
> +       (file-name (string-append name "-" version ".tar.gz"))
> +       (sha256
> +        (base32
> +         "1bwzdd3054d407d5j4m3njsbvmc9r8zzp33m32pj3b3irxrl68q0"))))
> +    (build-system emacs-build-system)
> +    (propagated-inputs
> +     `(("emacs-evil" ,emacs-evil)
> +       ("emacs-smartparens" ,emacs-smartparens)))
> +    (home-page "https://github.com/expez/evil-smartparens")
> +    (synopsis "Emacs Evil integration for Smartparens")
> +    (description "@code{emacs-evil-smartparens} is an Emacs minor mode
> which
> +makes Evil play nice with Smartparens.")
>

I would say

@code{emacs-evil-smartparens} is an Emacs minor mode which
makes Evil, the Emacs mode to simulate the Vi key combinations, play nice
with Smartparens.

I wouldn't assume that people reading the description know what Evil is
Or, maybe a link to the Evil home page would be better, instead of a quite
long sentence between commas ?
I don't know, I'm not sure. Has anyone anything to say about this ?

Thanks !

[-- Attachment #2: Type: text/html, Size: 3103 bytes --]

[bug#29878] [PATCH] gnu: Add emacs-evil-smartparens.

[Arun Isaac]

> I didn't run it because I can't use Vi(m) so maybe it's better if someone
> else tests this

I do use this package. I installed it and checked. It works properly,
and I'm quite confident there are no issues. It's a very trivial
package, after all.

> I would say
>
> @code{emacs-evil-smartparens} is an Emacs minor mode which
> makes Evil, the Emacs mode to simulate the Vi key combinations, play nice
> with Smartparens.
>
> I wouldn't assume that people reading the description know what Evil is
> Or, maybe a link to the Evil home page would be better, instead of a quite
> long sentence between commas ?

In the new patch I just sent, I have added a second sentence explaining
what Evil is. I don't think it's very useful to add a link in the
description text. IMHO, descriptions are better if they are
self-contained. The user can always search on the web if they want to
know more.

> Thanks !

Thanks for the review!

[bug#29878] [PATCH] gnu: Add emacs-evil-smartparens.

[Catonano]

[-- Attachment #1: Type: text/plain, Size: 845 bytes --]

2018-01-02 13:40 GMT+01:00 Arun Isaac <arunisaac@systemreboot.net>:

>
> > I didn't run it because I can't use Vi(m) so maybe it's better if someone
> > else tests this
>
> I do use this package. I installed it and checked. It works properly,
> and I'm quite confident there are no issues. It's a very trivial
> package, after all.
>
> > I would say
> >
> > @code{emacs-evil-smartparens} is an Emacs minor mode which
> > makes Evil, the Emacs mode to simulate the Vi key combinations, play nice
> > with Smartparens.
> >
> > I wouldn't assume that people reading the description know what Evil is
> > Or, maybe a link to the Evil home page would be better, instead of a
> quite
> > long sentence between commas ?
>
> In the new patch I just sent, I have added a second sentence explaining
> what Evil is.


LGTM ! 😊

[-- Attachment #2: Type: text/html, Size: 1311 bytes --]

bug#29878: [PATCH] gnu: Add emacs-evil-smartparens.

[Arun Isaac]

> LGTM ! 😊

Pushed!

[bug#29878] [PATCH] gnu: Add emacs-evil-smartparens.

[Arun Isaac]

* gnu/packages/emacs.scm (emacs-evil-smartparens): New variable.
---
 gnu/packages/emacs.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 9f80f241b..eb8356619 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -6574,3 +6574,28 @@ Feautures:
      "@code{evil-matchit} is a minor mode for jumping between matching tags in
 evil mode using @kbd{%}.  It is a port of @code{matchit} for Vim.")
     (license license:gpl3+)))
+
+(define-public emacs-evil-smartparens
+  (package
+    (name "emacs-evil-smartparens")
+    (version "0.4.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "https://github.com/expez/evil-smartparens/archive/"
+             version ".tar.gz"))
+       (file-name (string-append name "-" version ".tar.gz"))
+       (sha256
+        (base32
+         "1bwzdd3054d407d5j4m3njsbvmc9r8zzp33m32pj3b3irxrl68q0"))))
+    (build-system emacs-build-system)
+    (propagated-inputs
+     `(("emacs-evil" ,emacs-evil)
+       ("emacs-smartparens" ,emacs-smartparens)))
+    (home-page "https://github.com/expez/evil-smartparens")
+    (synopsis "Emacs Evil integration for Smartparens")
+    (description "@code{emacs-evil-smartparens} is an Emacs minor mode which
+makes Evil play nice with Smartparens.  Evil is an Emacs minor mode that
+emulates Vim features and provides Vim-like key bindings in Emacs.")
+    (license license:gpl3+)))
-- 
2.15.1