From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rutger Helling Subject: Re: 01/01: gnu: qemu: Enable Samba support. Date: Thu, 28 Dec 2017 06:46:28 +0100 Message-ID: <20171228064628.31852bea@mykolab.com> References: <20171227092649.22335.79799@vcs0.savannah.gnu.org> <20171227092650.69D7B204F7@vcs0.savannah.gnu.org> <87r2rfn5pc.fsf@netris.org> <159BE99C-4CFD-437B-9768-AF13A5017F55@gmail.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/5buzayO6R2_s_XcKZdRaI9S"; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:55338) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eUR1q-0007lz-67 for guix-devel@gnu.org; Thu, 28 Dec 2017 00:46:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eUR1l-0008JU-NN for guix-devel@gnu.org; Thu, 28 Dec 2017 00:46:54 -0500 Received: from mx.kolabnow.com ([95.128.36.42]:27758) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eUR1l-0008IY-BK for guix-devel@gnu.org; Thu, 28 Dec 2017 00:46:49 -0500 In-Reply-To: <159BE99C-4CFD-437B-9768-AF13A5017F55@gmail.com> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Maxim Cournoyer Cc: guix-devel@gnu.org --Sig_/5buzayO6R2_s_XcKZdRaI9S Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable That does seem more logical IMO. On Wed, 27 Dec 2017 23:41:31 +0000 Maxim Cournoyer wrote: > Hello, >=20 > On December 27, 2017 5:53:19 PM EST, Mark H Weaver > wrote: > >Hi, > > > >rhelling@mykolab.com (Rutger Helling) writes: > > =20 > >> rhelling pushed a commit to branch master > >> in repository guix. > >> > >> commit 84276503059d46c0a42240f8770f59090614d863 > >> Author: Rutger Helling > >> Date: Wed Dec 27 10:09:26 2017 +0100 > >> > >> gnu: qemu: Enable Samba support. > >> =20 > >> * gnu/packages/virtualization.scm (qemu)[arguments]: Change =20 > >#:configure-flags to =20 > >> a list, add --smbd flag. > >> [inputs]: Add samba. =20 > > > >I see that you have since reverted this commit, but I still thought > >I'd mention that when adding optional features to 'qemu', it would > >be good to remove them from 'qemu-minimal', which inherits from > >'qemu'. =20 >=20 > Maybe this relationship could be turned around? It seems like it'd > make more sense. >=20 > Maxim --Sig_/5buzayO6R2_s_XcKZdRaI9S Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEAVThuRzJ2e93ZI3n86cn20T8yjYFAlpEhTQACgkQ86cn20T8 yjaEwAf+I293zCZmeI/b/vl2Tgaall0LYx+8XWtuplr3G3mq3UDwtVmdxeSaA0W8 8nynzNOZ8OnbGY6QDoO8EcDySCd9Yy/cw5aPRNS5kaIAAR1sIKGbncz+1Vyv5El7 sY1puKKbxFZTEFLcxzz4iGe5Q5OkqM1I4XGEIOcz8jVwxGpbtPFNhm/47NNhTlZF AYxHEOHFM8AfEMOojeathNTp1FL9GXulX73u9RTAO3W6Y/3GZgc9yBudzqaDihTl U0MFF82ltpGHP0fUVY5d7vbvWVl5XvtBiYmCWvhnCnoBlVate/u1rFL6YFS7mW1l +tt1Cr17decOYwpkmlWVmFEwHDKNMQ== =Bmwn -----END PGP SIGNATURE----- --Sig_/5buzayO6R2_s_XcKZdRaI9S--