Re: 01/01: gnu: qemu: Enable Samba support.

[Rutger Helling <rhelling@mykolab.com>]

[-- Attachment #1: Type: text/plain, Size: 1088 bytes --]

That does seem more logical IMO.

On Wed, 27 Dec 2017 23:41:31 +0000
Maxim Cournoyer <maxim.cournoyer@gmail.com> wrote:

> Hello,
> 
> On December 27, 2017 5:53:19 PM EST, Mark H Weaver <mhw@netris.org>
> wrote:
> >Hi,
> >
> >rhelling@mykolab.com (Rutger Helling) writes:
> >  
> >> rhelling pushed a commit to branch master
> >> in repository guix.
> >>
> >> commit 84276503059d46c0a42240f8770f59090614d863
> >> Author: Rutger Helling <rhelling@mykolab.com>
> >> Date:   Wed Dec 27 10:09:26 2017 +0100
> >>
> >>     gnu: qemu: Enable Samba support.
> >>     
> >>     * gnu/packages/virtualization.scm (qemu)[arguments]: Change  
> >#:configure-flags to  
> >>     a list, add --smbd flag.
> >>     [inputs]: Add samba.  
> >
> >I see that you have since reverted this commit, but I still thought
> >I'd mention that when adding optional features to 'qemu', it would
> >be good to remove them from 'qemu-minimal', which inherits from
> >'qemu'.  
> 
> Maybe this relationship could be turned around? It seems like it'd
> make more sense.
> 
> Maxim


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]