[rhelling@mykolab.com: 02/02: gnu: mpv: Update to 0.28.0.]

[rhelling@mykolab.com: 02/02: gnu: mpv: Update to 0.28.0.]

[Leo Famulari]

[-- Attachment #1: Type: text/plain, Size: 1263 bytes --]

Hi Rutger,

----- Forwarded message from Rutger Helling <rhelling@mykolab.com> -----

Date: Wed, 27 Dec 2017 04:52:26 -0500 (EST)
From: Rutger Helling <rhelling@mykolab.com>
To: guix-commits@gnu.org
Subject: 02/02: gnu: mpv: Update to 0.28.0.

rhelling pushed a commit to branch master
in repository guix.

commit abc5ef5a7f7fecb99ca8213c0962f42cc1a65552
Author: Rutger Helling <rhelling@mykolab.com>
Date:   Wed Dec 27 10:46:26 2017 +0100

    gnu: mpv: Update to 0.28.0.
    
    * gnu/packages/video.scm (mpv): Update to 0.28.0.
    [inputs]: Change ffmpeg to ffmpeg-git, add wayland-protocols.

-----

As a frequent user of mpv, I also noticed that its latest release
requires this unreleased branch of FFmpeg (it will eventually be
released as FFmpeg 3.5).

I wonder, does mpv 0.28.0 bring some new features that make it worth it
to build three copies of FFmpeg? There was already ffmpeg-2.8 and
ffmpeg@3.4.1 (the latest upstream release). And, do we know if this copy
of FFmpeg is ready to be deployed?

If I remember correctly, FFmpeg is pretty expensive to build from
source. But maybe it's no big deal, or the new features are worth it. Or
maybe we should replace ffmpeg@3.4.1 with this unreleased development
branch.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [rhelling@mykolab.com: 02/02: gnu: mpv: Update to 0.28.0.]

[Rutger Helling]

[-- Attachment #1: Type: text/plain, Size: 2321 bytes --]

Hi Leo,

You can find the new features at:
https://github.com/mpv-player/mpv/blob/master/RELEASE_NOTES

There are two reasons for me personally why I wanted to update:
1. The mpv developers only support the latest release.
2. The initial Vulkan support, which I've got working (x86_64 only for
now). I can't merge it yet until core-updates is merged though.

I agree having three ffmpeg versions is undesirable. However, looking
at the release notes ("This release needs recent FFmpeg (newer than
3.4) due to major refactoring.") this is hopefully a one-time thing.

When stable ffmpeg is updated we can get rid of the -git version. mpv is
the only one using the -git version and it's been very solid for me, so
I don't foresee problems there. Replacing ffmpeg@3.4.1 entirely with
this -git version seems too extreme a solution to me.

Hopefully that explains my rationale a bit!

On Wed, 27 Dec 2017 14:18:32 -0500
Leo Famulari <leo@famulari.name> wrote:

> Hi Rutger,
> 
> ----- Forwarded message from Rutger Helling <rhelling@mykolab.com>
> -----
> 
> Date: Wed, 27 Dec 2017 04:52:26 -0500 (EST)
> From: Rutger Helling <rhelling@mykolab.com>
> To: guix-commits@gnu.org
> Subject: 02/02: gnu: mpv: Update to 0.28.0.
> 
> rhelling pushed a commit to branch master
> in repository guix.
> 
> commit abc5ef5a7f7fecb99ca8213c0962f42cc1a65552
> Author: Rutger Helling <rhelling@mykolab.com>
> Date:   Wed Dec 27 10:46:26 2017 +0100
> 
>     gnu: mpv: Update to 0.28.0.
>     
>     * gnu/packages/video.scm (mpv): Update to 0.28.0.
>     [inputs]: Change ffmpeg to ffmpeg-git, add wayland-protocols.
> 
> -----
> 
> As a frequent user of mpv, I also noticed that its latest release
> requires this unreleased branch of FFmpeg (it will eventually be
> released as FFmpeg 3.5).
> 
> I wonder, does mpv 0.28.0 bring some new features that make it worth
> it to build three copies of FFmpeg? There was already ffmpeg-2.8 and
> ffmpeg@3.4.1 (the latest upstream release). And, do we know if this
> copy of FFmpeg is ready to be deployed?
> 
> If I remember correctly, FFmpeg is pretty expensive to build from
> source. But maybe it's no big deal, or the new features are worth it.
> Or maybe we should replace ffmpeg@3.4.1 with this unreleased
> development branch.


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [rhelling@mykolab.com: 02/02: gnu: mpv: Update to 0.28.0.]

[Leo Famulari]

[-- Attachment #1: Type: text/plain, Size: 1906 bytes --]

On Wed, Dec 27, 2017 at 08:52:12PM +0100, Rutger Helling wrote:
> Hi Leo,
> 
> You can find the new features at:
> https://github.com/mpv-player/mpv/blob/master/RELEASE_NOTES
> 
> There are two reasons for me personally why I wanted to update:
> 1. The mpv developers only support the latest release.
> 2. The initial Vulkan support, which I've got working (x86_64 only for
> now). I can't merge it yet until core-updates is merged though.
> 
> I agree having three ffmpeg versions is undesirable. However, looking
> at the release notes ("This release needs recent FFmpeg (newer than
> 3.4) due to major refactoring.") this is hopefully a one-time thing.
> 
> When stable ffmpeg is updated we can get rid of the -git version. mpv is
> the only one using the -git version and it's been very solid for me, so
> I don't foresee problems there. Replacing ffmpeg@3.4.1 entirely with
> this -git version seems too extreme a solution to me.
> 
> Hopefully that explains my rationale a bit!

Okay, let's keep this mpv and FFmpeg. I'm always eager to update to the
latest releases of C-language programs that handle untrusted input, and
it sounds like the mpv team is moving on from mpv 0.27.0.

Personally I think it's bad practice for mpv to depend on some random
commit of FFmpeg, but that is mpv's choice.

In the future, please send patches that introduce unreleased versions of
widely used libraries like FFmpeg to guix-patches for review.

The packaging guidelines say, "We usually package only the latest
version of a given free software project." [0]

I interpret "latest version" to mean the latest version released in the
way that the upstream developers typically do their releases. For
FFmpeg, this is a tarball.

Thank you very much for taking the time to explain your rationale!

[0]
https://www.gnu.org/software/guix/manual/html_node/Version-Numbers.html

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [rhelling@mykolab.com: 02/02: gnu: mpv: Update to 0.28.0.]

[Rutger Helling]

[-- Attachment #1: Type: text/plain, Size: 2298 bytes --]

Hi Leo,

On Wed, 27 Dec 2017 18:20:01 -0500
Leo Famulari <leo@famulari.name> wrote:

> On Wed, Dec 27, 2017 at 08:52:12PM +0100, Rutger Helling wrote:
> > Hi Leo,
> > 
> > You can find the new features at:
> > https://github.com/mpv-player/mpv/blob/master/RELEASE_NOTES
> > 
> > There are two reasons for me personally why I wanted to update:
> > 1. The mpv developers only support the latest release.
> > 2. The initial Vulkan support, which I've got working (x86_64 only
> > for now). I can't merge it yet until core-updates is merged though.
> > 
> > I agree having three ffmpeg versions is undesirable. However,
> > looking at the release notes ("This release needs recent FFmpeg
> > (newer than 3.4) due to major refactoring.") this is hopefully a
> > one-time thing.
> > 
> > When stable ffmpeg is updated we can get rid of the -git version.
> > mpv is the only one using the -git version and it's been very solid
> > for me, so I don't foresee problems there. Replacing ffmpeg@3.4.1
> > entirely with this -git version seems too extreme a solution to me.
> > 
> > Hopefully that explains my rationale a bit!  
> 
> Okay, let's keep this mpv and FFmpeg. I'm always eager to update to
> the latest releases of C-language programs that handle untrusted
> input, and it sounds like the mpv team is moving on from mpv 0.27.0.
> 
> Personally I think it's bad practice for mpv to depend on some random
> commit of FFmpeg, but that is mpv's choice.
> 

I agree, it's an unfortunate situation that hopefully shouldn't take
too long.

> In the future, please send patches that introduce unreleased versions
> of widely used libraries like FFmpeg to guix-patches for review.
> 
> The packaging guidelines say, "We usually package only the latest
> version of a given free software project." [0]
> 

I'll send a patch in next time first, sorry about any inconvenience.
Hopefully this is a one-time situation though.

> I interpret "latest version" to mean the latest version released in
> the way that the upstream developers typically do their releases. For
> FFmpeg, this is a tarball.
> 
> Thank you very much for taking the time to explain your rationale!
> 
> [0]
> https://www.gnu.org/software/guix/manual/html_node/Version-Numbers.html


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]