[bug#29836] [PATCH] Add The Butterfly Effect (tbe)

[bug#29836] [PATCH] Add The Butterfly Effect (tbe)

[Nicolas Goaziou]

[-- Attachment #1: Type: text/plain, Size: 140 bytes --]

Hello,

This patch adds The Butterfly Effect game.

Regards,

-- 
Nicolas Goaziou                                                0x80A93738

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Add tbe. --]
[-- Type: text/x-diff, Size: 3128 bytes --]

From e2ff716723aadd9bab7a09998d5ee65641e8d063 Mon Sep 17 00:00:00 2001
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Date: Sun, 24 Dec 2017 16:09:57 +0100
Subject: [PATCH] gnu: games: Add tbe.

* gnu/packages/games.scm (tbe): New variable.
---
 gnu/packages/games.scm | 55 ++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 55 insertions(+)

diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
index 981163c3d..0d9eca6c9 100644
--- a/gnu/packages/games.scm
+++ b/gnu/packages/games.scm
@@ -5294,3 +5294,58 @@ making Yamagi Quake II one of the most solid Quake II implementations available.
                     "file://LICENSE"
                     "See Info-Zip section.")
                    license:public-domain)))) ; stb
+
+(define-public tbe
+  (package
+    (name "tbe")
+    (version "0.9.3.1")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "https://github.com/the-butterfly-effect/tbe/archive/"
+             "v" version ".tar.gz"))
+       (file-name (string-append name "-" version ".tar.gz"))
+       (sha256
+        (base32
+         "18qkp7fgdvyl3haqqa693mgyic7afsznsxgz98z9wn4csaqxsnby"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (delete 'configure)
+         ;; There is no "install" phase.  By default, tbe is installed
+         ;; in the build directory.  Provide our own installation.
+         (replace 'install
+           (lambda* (#:key outputs #:allow-other-keys)
+             (and (system* "make" "DESTDIR=.." "install")
+                  (let* ((out (assoc-ref outputs "out"))
+                         (bin (string-append out "/bin"))
+                         (share (string-append out "/share")))
+                    (install-file "usr/games/tbe" bin)
+                    (mkdir-p share)
+                    (copy-recursively "usr/share" share)
+                    #t)))))
+       ;; Test suite requires a running Xorg server. Even when
+       ;; provided, it fails with "D-Bus library appears to be
+       ;; incorrectly set up; failed to read machine uuid: Failed to
+       ;; open "/etc/machine-id": No such file or directory" along
+       ;; with multiple "QPainter:: ... Painter not active" warnings.
+       #:tests? #f))
+    (inputs
+     `(("gettext-minimal" ,gettext-minimal)
+       ("qtbase" ,qtbase)
+       ("qtsvg" ,qtsvg)
+       ("qtxmlpatternn" ,qtxmlpatterns)))
+    (native-inputs
+     `(("cmake" ,cmake)
+       ("qttools" ,qttools)))
+    (synopsis "Realistic physics puzzle game")
+    (description "The Butterfly Effect (tbe) is a game that uses
+realistic physics simulations to combine lots of simple mechanical
+elements to achieve a simple goal in the most complex way possible.")
+    (home-page "http://the-butterfly-effect.org/")
+    ;; Main license is GPL2-only.  However, artwork is distributed
+    ;; under various licenses, listed here.
+    (license (list license:gpl2 license:public-domain license:expat
+                   license:cc-by-sa3.0 license:gpl3+ license:wtfpl2))))
-- 
2.15.1

[bug#29836] [PATCH] Add The Butterfly Effect (tbe)

[Leo Famulari]

[-- Attachment #1: Type: text/plain, Size: 1026 bytes --]

On Sun, Dec 24, 2017 at 04:11:20PM +0100, Nicolas Goaziou wrote:
> Hello,
> 
> This patch adds The Butterfly Effect game.

Cool!

> +(define-public tbe
> +  (package
> +    (name "tbe")

How about calling it the-butterfly-effect, which I think is more clear?

> +    (inputs
> +     `(("gettext-minimal" ,gettext-minimal)
> +       ("qtbase" ,qtbase)
> +       ("qtsvg" ,qtsvg)
> +       ("qtxmlpatternn" ,qtxmlpatterns)))
> +    (native-inputs
> +     `(("cmake" ,cmake)
> +       ("qttools" ,qttools)))

gettext-minimal can be a native-input.

qtxmlpatterns doesn't seem to be used. At least, it's not referenced by
the built package:

$ guix gc --references $(./pre-inst-env guix build tbe)
/gnu/store/14gzwy1hyzyqnrdwcfcnpvm0wl0v7bs6-qtsvg-5.9.3
/gnu/store/3x53yv4v144c9xp02rs64z7j597kkqax-gcc-5.4.0-lib
/gnu/store/jzh36z7bvwkv363xjmxsp5vvlaa7ajf0-qtbase-5.9.3
/gnu/store/n6nvxlk2j8ysffjh3jphn1k5silnakh6-glibc-2.25
/gnu/store/pmgb6kgwpci0iv06v0pq190048i258rm-the-butterfly-effect-0.9.3.1

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

bug#29836: [PATCH] Add The Butterfly Effect (tbe)

[Nicolas Goaziou]

Leo Famulari <leo@famulari.name> writes:

> How about calling it the-butterfly-effect, which I think is more
> clear?

Fair enough. I renamed the variable and updated the `name' field.

> gettext-minimal can be a native-input.

Fixed.

> qtxmlpatterns doesn't seem to be used. At least, it's not referenced by
> the built package:

Indeed. Also fixed.

I pushed the commit with the changes above and an additional fix. Thank
you for the review.

Regards,