From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38897) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eQLef-00020K-IN for guix-patches@gnu.org; Sat, 16 Dec 2017 18:14:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eQLec-0005W1-EG for guix-patches@gnu.org; Sat, 16 Dec 2017 18:14:05 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:57343) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eQLec-0005Vq-A6 for guix-patches@gnu.org; Sat, 16 Dec 2017 18:14:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eQLec-0006GS-4J for guix-patches@gnu.org; Sat, 16 Dec 2017 18:14:02 -0500 Subject: [bug#29745] [PATCH 0/3] Disallow phase returning . Resent-Message-ID: Received: from eggs.gnu.org ([2001:4830:134:3::10]:38814) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eQLeA-0001ww-WE for guix-patches@gnu.org; Sat, 16 Dec 2017 18:13:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eQLe7-0004ez-QY for guix-patches@gnu.org; Sat, 16 Dec 2017 18:13:34 -0500 Received: from [2001:19f0:5:274f:4827:c39:448f:6777] (port=45204 helo=vultr.systemreboot.net) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eQLe7-0004a9-9f for guix-patches@gnu.org; Sat, 16 Dec 2017 18:13:31 -0500 From: Arun Isaac Date: Sun, 17 Dec 2017 04:42:42 +0530 Message-Id: <20171216231242.12032-1-arunisaac@systemreboot.net> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: 29745@debbugs.gnu.org Patch 1 modifies gnu-build-system to explicitly check the return value of each phase for an unspecified value, and if found consider that phase to have failed. Patch 2 fixes several phases in gnu-build-system by making them return #t instead of an unspecified value. Patch 3 fixes the phases in several packages to return #t instead of an unspecified value. I was testing patch 1, by trying to build bash. In doing so, I found that the custom phases of many packages were not properly returning #t, and fixed all those packages. No doubt, there are many more packages that need fixing. Arun Isaac (3): build: gnu-build-system: Disallow phase returning . build: gnu-build-system: Return #t from phases. gnu: Return #t from phases. gnu/packages/attr.scm | 3 ++- gnu/packages/autotools.scm | 3 ++- gnu/packages/base.scm | 3 ++- gnu/packages/bash.scm | 3 ++- gnu/packages/commencement.scm | 15 ++++++++++----- gnu/packages/gcc.scm | 3 ++- gnu/packages/libffi.scm | 3 ++- gnu/packages/m4.scm | 3 ++- gnu/packages/ncurses.scm | 6 ++++-- gnu/packages/perl.scm | 3 ++- gnu/packages/readline.scm | 3 ++- guix/build/gnu-build-system.scm | 18 +++++++++++++----- 12 files changed, 45 insertions(+), 21 deletions(-) -- 2.15.1