From mboxrd@z Thu Jan  1 00:00:00 1970
From: Danny Milosavljevic <dannym@scratchpost.org>
Subject: bug#22050: [PATCH v4 1/2] linux-boot: Add make-static-device-nodes.
Date: Fri, 15 Dec 2017 18:27:17 +0100
Message-ID: <20171215182717.478928f4@scratchpost.org>
References: <20171213223240.605-1-dannym@scratchpost.org>
	<20171214195636.787-1-dannym@scratchpost.org>
	<20171214195636.787-2-dannym@scratchpost.org>
	<87374cmipa.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39439)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ePtmJ-0004pi-Gz
	for bug-guix@gnu.org; Fri, 15 Dec 2017 12:28:08 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ePtmE-0002Io-IL
	for bug-guix@gnu.org; Fri, 15 Dec 2017 12:28:07 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:55548)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1ePtmE-0002IJ-Fi
	for bug-guix@gnu.org; Fri, 15 Dec 2017 12:28:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ePtmE-0001Ju-3e
	for bug-guix@gnu.org; Fri, 15 Dec 2017 12:28:02 -0500
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.22050.B22050.15133588475031@debbugs.gnu.org>
In-Reply-To: <87374cmipa.fsf@gnu.org>
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix/>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
To: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: 22050@debbugs.gnu.org

Hi Ludo,

On Fri, 15 Dec 2017 10:41:37 +0100
ludo@gnu.org (Ludovic Court=C3=A8s) wrote:

> This looks good, but would it be enough to do:
>=20
>   (mkdir-p (dirname (string-append "/dev/" name)))

mkdir permission needs to be specified to be #o755.

I've seen some variants in guix - but they are all buried somewhere deep:

./gnu/services/cups.scm:        (define (mkdir-p/perms directory owner perm=
s)
./gnu/services/dns.scm:      (define (mkdir-p/perms directory owner perms)
./gnu/services/mail.scm:      (define (mkdir-p/perms directory owner perms)
./guix/build/utils.scm:(define (mkdir-p dir)
./guix/build/graft.scm:(define* (mkdir-p* dir #:optional (mode #o755))

I don't feel good relying on magical unspecified permissions in code requir=
ed to boot the system.  I think mkdir-p itself subtracts the umask or somet=
hing.  Is the umask guaranteed to be 0 at the point of usage of make-static=
-device-nodes ?