From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tobias Geerinckx-Rice Subject: [PATCH] gnu: python2-pyicu: Disable failing test. Date: Fri, 15 Dec 2017 11:47:59 +0100 Message-ID: <20171215104759.28107-1-me@tobias.gr> References: <7d6b06d4-c637-e605-70fa-10f21bbbe843@tobias.gr> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:43086) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ePnUj-0005OU-4T for guix-devel@gnu.org; Fri, 15 Dec 2017 05:45:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ePnUi-0000Gl-44 for guix-devel@gnu.org; Fri, 15 Dec 2017 05:45:33 -0500 Received: from tobias.gr ([2001:470:cc92::1]:55908) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ePnUh-0000F4-Mc for guix-devel@gnu.org; Fri, 15 Dec 2017 05:45:32 -0500 In-Reply-To: <7d6b06d4-c637-e605-70fa-10f21bbbe843@tobias.gr> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: mark@ofosos.org Cc: guix-devel@gnu.org * gnu/packages/python.scm (python2-pyicu)[arguments]: Add ‘delete-failing-test’ phase. --- Mark, ...of course it finishes right after I send that previous e-mail. This patch makes the build pass for me. Could you confirm whether it works for you? Kind regards, T G-R gnu/packages/python.scm | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm index e36056d45..372b5afe3 100644 --- a/gnu/packages/python.scm +++ b/gnu/packages/python.scm @@ -1130,7 +1130,20 @@ Python 3.3+.") (license license:x11))) (define-public python2-pyicu - (package-with-python2 python-pyicu)) + (let ((base (package-with-python2 + (strip-python2-variant python-pyicu)))) + (package + (inherit base) + (arguments + `(,@(package-arguments base) + #:phases + (modify-phases %standard-phases + (add-before 'check 'delete-failing-test + (lambda _ + ;; XXX: This fails due to Unicode issues unique to Python 2, + ;; it seems: . + (delete-file "test/test_Script.py") + #t)))))))) (define-public python2-dogtail ;; Python 2 only, as it leads to "TabError: inconsistent use of tabs and -- 2.15.0