From mboxrd@z Thu Jan 1 00:00:00 1970 From: ng0 Subject: Re: [bug#29708] Update s-shell Date: Thu, 14 Dec 2017 17:38:35 +0000 Message-ID: <20171214173835.u7elrv4lrnlv3mqr@abyayala> References: <20171214133123.ymo5dxscjqhsbkfn@abyayala> <87efnx8bm4.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="evmzm7r2w3jyxwhg" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:45188) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ePXTC-0006eB-M2 for guix-devel@gnu.org; Thu, 14 Dec 2017 12:38:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ePXTB-0000Et-Mm for guix-devel@gnu.org; Thu, 14 Dec 2017 12:38:54 -0500 Content-Disposition: inline In-Reply-To: <87efnx8bm4.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ludovic =?utf-8?Q?Court=C3=A8s?= Cc: guix-devel@gnu.org --evmzm7r2w3jyxwhg Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s transcribed 0.4K bytes: > ng0 skribis: >=20 > > From cf2cbe9e9e525aa9dd697fcedb255a0fbc194ac9 Mon Sep 17 00:00:00 2001 > > From: ng0 > > Date: Thu, 14 Dec 2017 13:22:58 +0000 > > Subject: [PATCH] s-shell: Update to commit > > da2e5c20c0c5f477ec3426dc2584889a789b1659. > > > > * gnu/packages/shells.scm (s-shell): Update to commit da2e5c20c0c5f477e= c3426dc2584889a789b1659. > > (version): Use 'git-version'. >=20 > I adjusted the commit log and pushed. Why is it [version]? Shouldn't it be (version)? Even though [version] now makes sense, I've seen mostly [] when it followed a () - and that's why I've been using ()[] and never(?) [] on its own. I haven't read HACKING or the chapter 'Contributing' in a while, so you might be describing something that's already in there. If it isn't, does it matter to agree on a fixed grammar for this? I've come to appreciate the strong QA and checks, but what matters is the content of the brackets, not the chosen form of brackets. For ()[] it makes sense. > Thanks! >=20 > Ludo=E2=80=99. >=20 --=20 GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588 GnuPG: https://c.n0.is/ng0_pubkeys/tree/keys WWW: https://n0.is --evmzm7r2w3jyxwhg Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEqIyK3RKYKNfqwC5S4i+bv+40hYgFAloytxsACgkQ4i+bv+40 hYhIlg/9ERxyudwjjrnMuxjInrwpfBxeaZPWDNSUj460LKyCFA9eA0YpgMUZLAXm 71IChyrNHmsMMIOh55sAAwOOrOpfVWOXFDIzzD7ml/RYkxeGPMuvy+HjJAkNqoSJ PWCM9fYa7O8Vh6fSrPbP4AewTH1vjVB0cXYNzxR+x88++3PZUHOVBfK0WR1jrfh+ mOM3LUbSVFmkRfYJeYthvLbZ3i5OhQrqDps6vnFBHIvdoFVDHDqZ7ePwnaBVIEfx nv+PJRQa2kUXky1XjrCqLddByECZQ6Dyuii5kNSpPEUG1TP7mZ1Ca3BvMkpKWJbQ pbOEvRdzdwpRh0CCbUk4JAnbiMbMu4ZF8AwODsJ6mbIUgwBfTlXnO/6KpBUkXRAk tqR2RFZXbwqOsY9TxvqVf13hTvj8GsZRAVxVptYLT8L3uEUsomF7d5LOYu46jyLP 8cbnjCqEuW76/UI7Am/alS/iu+n/yq3mS0ZWt+nxzc7/ID5oge/WEoCAIeudd+/S tYjQqbcxlgmAhyG0gnoAirHljrFNFooc3aaCV96s9ZQ5gREkQ/oYs16iwnPasZVY SPHW792ie7ohBuNTKVFX98k6kMPW5CUmC+MKNsEHxH4VXcniyc7SGMqmqLZVH8ox VqSRut3kjv4jUla5xbg1dnHm2GU7OtyEisgJNItXAHo6CGNCjPE= =LAkL -----END PGP SIGNATURE----- --evmzm7r2w3jyxwhg--