From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47101) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ePUgA-0005JU-Ut for guix-patches@gnu.org; Thu, 14 Dec 2017 09:40:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ePUg6-0003Rn-SL for guix-patches@gnu.org; Thu, 14 Dec 2017 09:40:06 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:52710) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ePUg6-0003Rc-Na for guix-patches@gnu.org; Thu, 14 Dec 2017 09:40:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ePUg6-0005V2-Ec for guix-patches@gnu.org; Thu, 14 Dec 2017 09:40:02 -0500 Subject: [bug#29703] Improve Krita Resent-Message-ID: Date: Thu, 14 Dec 2017 14:39:21 +0000 From: ng0 Message-ID: <20171214143921.blzsslbcig76ysob@abyayala> References: <1513210726.1193324.1204381152.68C7761A@webmail.messagingengine.com> <20171214115531.llwpyqjzjbwepvep@abyayala> <1513260171.940424.1204970752.5399B230@webmail.messagingengine.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="b2kxr62effomd3te" Content-Disposition: inline In-Reply-To: <1513260171.940424.1204970752.5399B230@webmail.messagingengine.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Mark Meyer Cc: 29703@debbugs.gnu.org --b2kxr62effomd3te Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, we're almost there. It's just a couple of fixes that need to be applied: Mark Meyer transcribed 7.7K bytes: > Ok, see the following patch. This should also be aligned with the commit > message conventions. >=20 > On Thu, Dec 14, 2017, at 12:55, ng0 wrote: > > Hi Mark, > >=20 > > Mark Meyer transcribed 5.4K bytes: > > > Hi, > > > I'm currently testing several changes to Krita, I've broken stuff up > > > into three commits/patches which are attached. > > >=20 > > > These > > > - add a dependency to vc (vectorize Krita) > > > - enable OpenEXR > > > - enable JPEG (via libjpeg-turbo) > >=20 > > Thanks for the work on Krita. > > I haven't tested them, but it looks good. > > It would be okay to squash these commits into one, we've done this > > in the past in similar cases (see `git log gnu/packages/gnunet.scm` > > for libextractor for example). > >=20 > > > Cheers, Mark > From 158497a7bf1b5672018189101fa5448623cecb1b Mon Sep 17 00:00:00 2001 > From: Mark Meyer > Date: Wed, 13 Dec 2017 23:49:09 +0100 > Subject: [PATCH] gnu: krita: Enhance krita >=20 > * gnu/packages/kde.scm (kirta)[inputs]: Add libjpeg-turbo to inputs. > * gnu/packages/kde.scm (krita)[inputs]: Add vc to native-inputs. > * gnu/packages/kde.scm (krita)[inputs]: Add OpenEXR support. I would write: gnu: krita: Enhance krita. * gnu/packages/kde.scm (krita)[inputs]: Add 'libjpeg-turbo', 'ilmbase', 'op= enexr'. (native-inputs): Add 'vc'. (arguments)[configure-flags]: Add 'CMAKE_CXX_FLAGS' for ilmbase. Or something like that. I'm not sure about the configure-flags wording. I don't know Krita so I can't really review if your changes work. I'll build it later tonight and see if it builds for me. > --- > gnu/packages/kde.scm | 13 ++++++++++--- > 1 file changed, 10 insertions(+), 3 deletions(-) >=20 > diff --git a/gnu/packages/kde.scm b/gnu/packages/kde.scm > index b5a3df2ca..89ad30ecd 100644 > --- a/gnu/packages/kde.scm > +++ b/gnu/packages/kde.scm > @@ -256,14 +256,18 @@ plugins, as well as code to create plugins, or comp= lete applications.") > (string-append "-DWITH_LibRaw=3D" > (assoc-ref %build-inputs "libraw")) > (string-append "-DWITH_TIFF=3D" > - (assoc-ref %build-inputs "libtiff"))))) > + (assoc-ref %build-inputs "libtiff")) > + (string-append "-DCMAKE_CXX_FLAGS=3D-I" > + (assoc-ref %build-inputs "ilmbase") > + "/include/OpenEXR")))) > (native-inputs > `(("curl" ,curl) > ("eigen" ,eigen) > ("extra-cmake-modules" ,extra-cmake-modules) > ("gettext-minimal" ,gettext-minimal) > ("kitemmodels" ,kitemmodels) > - ("qwt" ,qwt))) > + ("qwt" ,qwt) > + ("vc" ,vc))) > (inputs > `(("qtbase" ,qtbase) > ("qtdeclarative" ,qtdeclarative) > @@ -287,6 +291,7 @@ plugins, as well as code to create plugins, or comple= te applications.") > ("exiv2" ,exiv2) > ("lcms" ,lcms) > ("libpng" ,libpng) > + ("libjpeg-turbo" ,libjpeg-turbo) > ("zlib" ,zlib) > ("libx11" ,libx11) > ("libxcb" ,libxcb) > @@ -296,7 +301,9 @@ plugins, as well as code to create plugins, or comple= te applications.") > ("poppler-qt5" ,poppler-qt5) > ("libraw" ,libraw) > ("libtiff" ,libtiff) > - ("perl" ,perl))) > + ("perl" ,perl) > + ("ilmbase" ,ilmbase) > + ("openexr" ,openexr))) > (home-page "https://krita.org") > (synopsis "Digital painting application") > (description > --=20 > 2.15.0 >=20 --=20 GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588 GnuPG: https://c.n0.is/ng0_pubkeys/tree/keys WWW: https://n0.is --b2kxr62effomd3te Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEqIyK3RKYKNfqwC5S4i+bv+40hYgFAloyjRkACgkQ4i+bv+40 hYhjdw//QpFJgY0JQ4IEJBlTGvYdUTerHBpg46sqO6gVxWaNQynd4v8kkQBP/JlZ DD62iVMfY+9VsttojtncvSOVl8+H4fvAPiYpBTkA/aKgbb4WkILSyJtGaMgaXKSS EHs70f/TxolzAq5/OPqMG/qQeOYcuEc6oy6xBKDazJCJTGfd9HtTZ5otzNZnfj8h oLKBo3B/E5jKCyMn4WTulKejoOC+KzekLYIyDjMLTPIovt851j34kFpEGjZVHHne bWldJjxKtjy/c1al/cjUfcUJd/FRIb6Nz9cvL6RhmjOIxARmc9cyspUlC18QG9Gs tS73Qb6J/WZ84xFDscqaG9lPIf8zcgvXYkBfXx60aRvIzzAE4+BiB6/Q9naEMsIX /7Yjxk6TNk/X2etTHBH/iqGrKW7curVaiSPbOszT3dMRNlT4AdJwbxrshs/RFOjG 9k3/ATKmB8x6FEAwL/069GirzMw+FmczntfVvGUEA4hSzO5YwaYCWUugUlsE9qNJ NMYC6N91O9wIrZ8gVQPS2YntAlpigU8Jt79xmCgIsx3E7L+MwsX2hltQNaOF2nBP UYtrHoXK3eetDc53Mbw35VAgCLCBsIQtE10D5efUkDPnSs1ENJ1NJvDH0BPHn0Zy fV46/h6pFdLhrRj+JT7LAZ3OGH1FrTmmJ7EiNIQhJcQgw5n1HrI= =28b8 -----END PGP SIGNATURE----- --b2kxr62effomd3te--