* [bug#28976] [PATCH] gnu: calcurse: Used the "fixed" test-only tzdata for tests.
@ 2017-10-24 20:13 Leo Famulari
2017-10-24 21:13 ` Marius Bakke
2017-10-25 23:45 ` Eric Bavier
0 siblings, 2 replies; 4+ messages in thread
From: Leo Famulari @ 2017-10-24 20:13 UTC (permalink / raw)
To: 28976
* gnu/packages/calcurse.scm (calcurse)[inputs]: Remove tzdata and add ...
[native-inputs]: tzdata-2017a.
[arguments]: Add tzdata-2017a to #:disallowed-references.
---
gnu/packages/calcurse.scm | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/gnu/packages/calcurse.scm b/gnu/packages/calcurse.scm
index 20a9a8fb4..826b1f1d0 100644
--- a/gnu/packages/calcurse.scm
+++ b/gnu/packages/calcurse.scm
@@ -1,5 +1,6 @@
;;; GNU Guix --- Functional package management for GNU
;;; Copyright © 2014, 2015, 2017 Eric Bavier <bavier@member.fsf.org>
+;;; Copyright © 2014, 2015, 2017 Leo Famulari <leo@famulari.name>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -38,13 +39,17 @@
(base32
"0il0y06akdqgy0f9p40m4x6arn66nh7sr1w1i41bszycs7div266"))))
(build-system gnu-build-system)
- (inputs `(("ncurses" ,ncurses)
- ("tzdata" ,tzdata)))
+ (inputs `(("ncurses" ,ncurses)))
+ (native-inputs `(("tzdata" ,tzdata-2017a)))
(arguments
;; The ical tests all want to create a ".calcurse" directory, and may
;; fail with "cannot create directory '.calcurse': File exists" if run
;; concurently.
- '(#:parallel-tests? #f
+ `(#:parallel-tests? #f
+ ;; Since this tzdata is only used for tests and not referenced by the
+ ;; built package, used the "fixed" obsolete version of tzdata and ensure
+ ;; it does not sneak in to the closure.
+ #:disallowed-references (,tzdata-2017a)
#:phases (modify-phases %standard-phases
(add-before 'check 'check-setup
(lambda* (#:key inputs #:allow-other-keys)
--
2.14.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [bug#28976] [PATCH] gnu: calcurse: Used the "fixed" test-only tzdata for tests.
2017-10-24 20:13 [bug#28976] [PATCH] gnu: calcurse: Used the "fixed" test-only tzdata for tests Leo Famulari
@ 2017-10-24 21:13 ` Marius Bakke
2017-10-25 23:45 ` Eric Bavier
1 sibling, 0 replies; 4+ messages in thread
From: Marius Bakke @ 2017-10-24 21:13 UTC (permalink / raw)
To: Leo Famulari, 28976
[-- Attachment #1: Type: text/plain, Size: 218 bytes --]
Leo Famulari <leo@famulari.name> writes:
> * gnu/packages/calcurse.scm (calcurse)[inputs]: Remove tzdata and add ...
> [native-inputs]: tzdata-2017a.
> [arguments]: Add tzdata-2017a to #:disallowed-references.
LGTM.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* [bug#28976] [PATCH] gnu: calcurse: Used the "fixed" test-only tzdata for tests.
2017-10-24 20:13 [bug#28976] [PATCH] gnu: calcurse: Used the "fixed" test-only tzdata for tests Leo Famulari
2017-10-24 21:13 ` Marius Bakke
@ 2017-10-25 23:45 ` Eric Bavier
2017-10-26 14:46 ` Leo Famulari
1 sibling, 1 reply; 4+ messages in thread
From: Eric Bavier @ 2017-10-25 23:45 UTC (permalink / raw)
To: Leo Famulari; +Cc: 28976
On Tue, 24 Oct 2017 16:13:04 -0400
Leo Famulari <leo@famulari.name> wrote:
> * gnu/packages/calcurse.scm (calcurse)[inputs]: Remove tzdata and add ...
> [native-inputs]: tzdata-2017a.
> [arguments]: Add tzdata-2017a to #:disallowed-references.
> ---
> gnu/packages/calcurse.scm | 11 ++++++++---
> 1 file changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/gnu/packages/calcurse.scm b/gnu/packages/calcurse.scm
> index 20a9a8fb4..826b1f1d0 100644
> --- a/gnu/packages/calcurse.scm
> +++ b/gnu/packages/calcurse.scm
> @@ -1,5 +1,6 @@
> ;;; GNU Guix --- Functional package management for GNU
> ;;; Copyright © 2014, 2015, 2017 Eric Bavier <bavier@member.fsf.org>
> +;;; Copyright © 2014, 2015, 2017 Leo Famulari <leo@famulari.name>
Do you want all the copyright years? or copy-paste error?
Otherwise LGTM!
Thanks,
`~Eric
^ permalink raw reply [flat|nested] 4+ messages in thread
* [bug#28976] [PATCH] gnu: calcurse: Used the "fixed" test-only tzdata for tests.
2017-10-25 23:45 ` Eric Bavier
@ 2017-10-26 14:46 ` Leo Famulari
0 siblings, 0 replies; 4+ messages in thread
From: Leo Famulari @ 2017-10-26 14:46 UTC (permalink / raw)
To: Eric Bavier; +Cc: 28976
[-- Attachment #1: Type: text/plain, Size: 1007 bytes --]
On Wed, Oct 25, 2017 at 06:45:47PM -0500, Eric Bavier wrote:
> On Tue, 24 Oct 2017 16:13:04 -0400
> Leo Famulari <leo@famulari.name> wrote:
>
> > * gnu/packages/calcurse.scm (calcurse)[inputs]: Remove tzdata and add ...
> > [native-inputs]: tzdata-2017a.
> > [arguments]: Add tzdata-2017a to #:disallowed-references.
> > ---
> > gnu/packages/calcurse.scm | 11 ++++++++---
> > 1 file changed, 8 insertions(+), 3 deletions(-)
> >
> > diff --git a/gnu/packages/calcurse.scm b/gnu/packages/calcurse.scm
> > index 20a9a8fb4..826b1f1d0 100644
> > --- a/gnu/packages/calcurse.scm
> > +++ b/gnu/packages/calcurse.scm
> > @@ -1,5 +1,6 @@
> > ;;; GNU Guix --- Functional package management for GNU
> > ;;; Copyright © 2014, 2015, 2017 Eric Bavier <bavier@member.fsf.org>
> > +;;; Copyright © 2014, 2015, 2017 Leo Famulari <leo@famulari.name>
>
> Do you want all the copyright years? or copy-paste error?
Copy-paste error! :)
Fixed in commit 17650569d44efbd6425f0bd93a8ff57f220034ed.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-10-26 14:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-24 20:13 [bug#28976] [PATCH] gnu: calcurse: Used the "fixed" test-only tzdata for tests Leo Famulari
2017-10-24 21:13 ` Marius Bakke
2017-10-25 23:45 ` Eric Bavier
2017-10-26 14:46 ` Leo Famulari
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.