From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47225) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e3G1Q-0002Ch-Hu for guix-patches@gnu.org; Sat, 14 Oct 2017 02:34:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e3G1K-0000ME-2C for guix-patches@gnu.org; Sat, 14 Oct 2017 02:34:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:58254) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e3G1J-0000MA-U7 for guix-patches@gnu.org; Sat, 14 Oct 2017 02:34:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e3G1J-0008MP-NY for guix-patches@gnu.org; Sat, 14 Oct 2017 02:34:01 -0400 Subject: [bug#28594] nototools (required for building Noto from source) Resent-Message-ID: Date: Sat, 14 Oct 2017 07:32:48 +0100 From: Christopher Baines Message-ID: <20171014073248.23ffc244@cbaines.net> In-Reply-To: <20171013200037.3lcr7xcz5umjxpou@abyayala> References: <20170925121841.hcaukrjxftvbyvnk@abyayala> <20171001184151.i3nilckvtk4onfo6@abyayala> <20171001184737.o2rsy6dz3b2i5avp@abyayala> <20171013081252.1d028d36@cbaines.net> <20171013082319.siqlkd6gbzzt7ipz@abyayala> <20171013203421.5662d8a3@cbaines.net> <20171013200037.3lcr7xcz5umjxpou@abyayala> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/eX=YksP1b4UjBTZxrYsaIQO"; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: ng0 Cc: 28594@debbugs.gnu.org --Sig_/eX=YksP1b4UjBTZxrYsaIQO Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Fri, 13 Oct 2017 20:00:37 +0000 ng0 wrote: > Christopher Baines transcribed 5.4K bytes: > > On Fri, 13 Oct 2017 08:23:19 +0000 > > ng0 wrote: > > =20 > > > Christopher Baines transcribed 4.7K bytes: =20 > > > > On Sun, 1 Oct 2017 18:47:37 +0000 > > > > ng0 wrote: > > > > =20 > > > > > * gnu/packages/fontutils.scm (nototools): New variable. > > > > > --- > > > > > gnu/packages/fontutils.scm | 44 > > > > > +++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 43 > > > > > insertions(+), 1 deletion(-) > > > > >=20 > > > > > diff --git a/gnu/packages/fontutils.scm > > > > > b/gnu/packages/fontutils.scm index 15401f652..ca10c10b0 100644 > > > > > --- a/gnu/packages/fontutils.scm > > > > > +++ b/gnu/packages/fontutils.scm > > > > > @@ -5,6 +5,7 @@ > > > > > ;;; Copyright =C2=A9 2016, 2017 Efraim Flashner > > > > > ;;; Copyright =C2=A9 2017 Rene Saavedra > > > > > ;;; Copyright =C2=A9 2017 Leo Famulari > > > > > +;;; Copyright =C2=A9 2017 ng0 > > > > > ;;; > > > > > ;;; This file is part of GNU Guix. > > > > > ;;; > > > > > @@ -44,7 +45,8 @@ > > > > > #:use-module (guix svn-download) > > > > > #:use-module (guix git-download) > > > > > #:use-module (guix build-system cmake) > > > > > - #:use-module (guix build-system gnu)) > > > > > + #:use-module (guix build-system gnu) > > > > > + #:use-module (guix build-system python)) > > > > > =20 > > > > > (define-public freetype > > > > > (package > > > > > @@ -565,3 +567,43 @@ opentype fonts. You can save fonts in many > > > > > different outline formats, and generate bitmaps.") > > > > > (license license:gpl3+) > > > > > (home-page "https://fontforge.github.io/en-US/"))) > > > > > + > > > > > +(define-public nototools > > > > > + (package > > > > > + (name "nototools") > > > > > + (version "20170925") > > > > > + (source > > > > > + (origin > > > > > + (method url-fetch) > > > > > + (uri (string-append > > > > > "https://github.com/googlei18n/nototools/" > > > > > + > > > > > "archive/v2017-09-25-tooling-for-phase3-" > > > > > + "update.tar.gz")) > > > > > + (file-name (string-append name "-" version ".tar.gz")) > > > > > + (sha256 > > > > > + (base32 > > > > > + > > > > > "1pvacw18cm9l4sb66pqyjc7hc74xhhfxc7kd5ald8lixf4wzg0s8")))) > > > > > + (build-system python-build-system) > > > > > + (arguments > > > > > + `(#:python ,python-2)) > > > > > + (propagated-inputs > > > > > + `(("python2-booleanoperations" ,python2-booleanoperations) > > > > > + ("python2-defcon" ,python2-defcon) > > > > > + ("python2-fonttools" ,python2-fonttools) > > > > > + ("python2-pillow" ,python2-pillow) > > > > > + ("python2-pyclipper" ,python2-pyclipper) > > > > > + ("python2-ufolib" ,python2-ufolib))) > > > > > + (home-page "https://github.com/googlei18n/nototools") > > > > > + (synopsis "Noto fonts support tools and scripts") > > > > > + (description > > > > > + "Nototools is a python package containing python scripts > > > > > used to +maintain the Noto Fonts project.") > > > > > + (license (list license:asl2.0 > > > > > + ;; Sample texts are attributed to UN and > > > > > OHCHR. > > > > > + ;; The permissions on the UDHR are pretty lax: > > > > > + ;; > > > > > http://www.ohchr.org/EN/UDHR/Pages/Introduction.aspx > > > > > + ;; "If UDHR translations or materials are > > > > > reproduced, users > > > > > + ;; should make reference to this website as a > > > > > source by > > > > > + ;; providing a link." > > > > > + license:public-domain > > > > > + license:non-copyleft > > > > > "file://sample_texts/attributions.txt" > > > > > + "See sample_texts/attributions.txt in the > > > > > distribution.")))) =20 > > > >=20 > > > > This whole patchset looks pretty good to me. I've built all the > > > > packages, but haven't tested them. > > > >=20 > > > > guix lint has one complaint here about the license: > > > >=20 > > > > gnu/packages/fontutils.scm:591:13: nototools@20170925: invalid > > > > license field > > > >=20 > > > > I'm not quite sure what this means. =20 > > >=20 > > > I think I know it, the non-copyleft needs to be adjusted to the list. > > > Thanks. I really should run lint for longer patchseries. I admit I do > > > this not very often. > > > Thanks for your review. =20 > >=20 > > You're welcome :) > >=20 > > It looks to me like the python-fonttools patch could be merged now, > > shall I merge it? I only ask as I don't want to mess up your workflow? = =20 >=20 >=20 > I have no time this weekend to work on it, I am busy with other things. > If you want to clean up the bits that are necessary and want to merge > it that would be very kind of you. I've gone ahead and merged the python-fonttools related patch, but I'm not planning to look at the other patches, at least not at the moment :) --Sig_/eX=YksP1b4UjBTZxrYsaIQO Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAlnhr5BfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9Xegbw/9HEJ0Y215qeJt2OuPqJbpTDr9SGRqcHdO848mEEQkcXRB+IRwa1buo9ci oEtanoQJJAgGTM4TRgv3GLqhQL0WsLlycQGczofp0ZLOQ2I9FFm99nj//qSdZA4K zSAaVqQDIezDB/ieSpMnqNVjDJm4CBPNXmpQyUJ4CsrXj5WXfvpbkIm8Zsiga24o XQC+UcbEvJSUq9/V8LzeHQCdrKAwpfkbl//nNgE7x/D2hHI1vWltaDARCgBcNNzM JaxB4epp6p4ut2t8Q4fMhArCffSvU01WdOs+7/NGxjp+t8Nl3kwnqwlSXttbEL15 6CvUD7G2rUDHL2juFs9+fc/OxBMtQSfPJaPbm56EfquO2rBi04AIcElS7Sj5mdcK J+YSe9Wvw65ZvJ6qHGTgAmgg+WmXgMd3QuU21qF1dsctIk+WiWM2F2dg/mIINfPi NwV7gaaWmI22f3VxGNb/2iehIAh0jKydug38LsOCKUe+1qUTR/7RP7VGIylqGIAq 73uUANJLAsCpRT45qeQdunlUoYb6216uQhoJSN8SIKuXOYdUpTk/WVlNpd2WIGDP uF1S5X2xmD+XBRna3ZPeomnIJM/PxQCGztDmDBZqfGg6oPa8/hJbEgB8bAB8xmal YaiVKaf+Db1mM2yplBnUZM1tfISDxtc/Mt+2UK+2juVajP+cWlk= =5h3z -----END PGP SIGNATURE----- --Sig_/eX=YksP1b4UjBTZxrYsaIQO--