From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41198) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e36Ed-0000Dc-8C for guix-patches@gnu.org; Fri, 13 Oct 2017 16:07:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e36Ea-0001gZ-3j for guix-patches@gnu.org; Fri, 13 Oct 2017 16:07:07 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:57999) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e36Ea-0001gM-0P for guix-patches@gnu.org; Fri, 13 Oct 2017 16:07:04 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e36EY-0003KO-9W for guix-patches@gnu.org; Fri, 13 Oct 2017 16:07:03 -0400 Subject: [bug#28769] [PATCH] gnu: services: Add php-fpm. Resent-Message-ID: Date: Fri, 13 Oct 2017 21:06:08 +0100 From: Christopher Baines Message-ID: <20171013210608.69664320@cbaines.net> In-Reply-To: <9fe1701f-d78f-ba3a-37eb-64417337a55b@cock.li> References: <9fe1701f-d78f-ba3a-37eb-64417337a55b@cock.li> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/O+fRgFTDr6o3OgWnbmgL/pC"; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: nee Cc: 28769@debbugs.gnu.org --Sig_/O+fRgFTDr6o3OgWnbmgL/pC Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Mon, 9 Oct 2017 23:54:24 +0200 nee wrote: > Subject: [PATCH 1/2] guix: utils: add version-major. >=20 > * guix/utils.scm (version-major): New function. I think procedure, rather than function is the usual, at least within the context of commit messages in the guix repository. > --- > guix/utils.scm | 5 +++++ > 1 file changed, 5 insertions(+) >=20 > diff --git a/guix/utils.scm b/guix/utils.scm > index de4aa6531..cec209a8f 100644 > --- a/guix/utils.scm > +++ b/guix/utils.scm > @@ -72,6 +72,7 @@ > version>=3D? =20 > version-prefix > version-major+minor > + version-major > guile-version>? > string-replace-substring > arguments-from-environment-variable > @@ -488,6 +489,10 @@ For example, (version-prefix \"2.1.47.4.23\" 3) > returns \"2.1.47\"" minor version numbers from version-string." > (version-prefix version-string 2)) > =20 > +(define (version-major version-string) > + "Return the major version number as string from the > version-string." > + (version-prefix version-string 1)) > + Seems fine to me. I'm guessing that you added this because it was convenient, but I can't see it being used in the next patch, have I missed it? --Sig_/O+fRgFTDr6o3OgWnbmgL/pC Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAlnhHLBfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XfqAA//dXi/rbR2zWFZy2Bq0WnOx9zV7mj5kw+oNKd3VK+8nQ3V4SgvpD/5eM8J vf6exWiZuo1w7ZjNjSVdgEm/+zz9ZrwsdaYfDdOqPa23i3t3VYUp9AJIyhILVNwt 65UtzQwpwB0HOEDpqbq60k+GkpPJEeBMkSgpNwZEcR8cWBNHrvzIlTSq6/98R02N sK4IjPbrbHs3EX2/eSVn71DiNPB2b9EQT4eSbY2mxMa1dwiMfigfa5ashlUYg7V0 Iq5iXhKGa/Ily/x1pYyUcZMDuxivV/C488uWkBc98Kn1psjselIjTJ5rTeXSjSAU AzXFhxQFiJ2LOzPySoH0zi8y+gaKnsVVY2H7rbCfVtQ0CP8OBzSXDg6DieKU4Zwo kIDm74flNy0VYlXh8ogrrl6j7HmYdbRYZgw+QQijp2YZtJh4eG2Dv6XvVN7F6yHP 63LyEU7gy4yuXj6AI6hovkZwdKWuM0b1/kGHGo5xKFavPFj94bWKbbDuplyWvp1+ NvitNq/xD92sUvDPUt9TzdA+ZUlV2EW1POiZmt1IaCma55sm5IhZ6EfCl31H3qSd 4VZkWsC9xmAiYvSPbl6R4ci6pcxTsxe5MpMeNz8FC/JLOPJwDlOUwA1V0ITkylL0 MHuPZ3wdCaHmsvr5iaEc/aGb+v3JOLkz5leFMH5hSfldtxxHhz8= =FK1Z -----END PGP SIGNATURE----- --Sig_/O+fRgFTDr6o3OgWnbmgL/pC--