On Mon, 9 Oct 2017 23:54:24 +0200 nee wrote: > Subject: [PATCH 1/2] guix: utils: add version-major. > > * guix/utils.scm (version-major): New function. I think procedure, rather than function is the usual, at least within the context of commit messages in the guix repository. > --- > guix/utils.scm | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/guix/utils.scm b/guix/utils.scm > index de4aa6531..cec209a8f 100644 > --- a/guix/utils.scm > +++ b/guix/utils.scm > @@ -72,6 +72,7 @@ > version>=? > version-prefix > version-major+minor > + version-major > guile-version>? > string-replace-substring > arguments-from-environment-variable > @@ -488,6 +489,10 @@ For example, (version-prefix \"2.1.47.4.23\" 3) > returns \"2.1.47\"" minor version numbers from version-string." > (version-prefix version-string 2)) > > +(define (version-major version-string) > + "Return the major version number as string from the > version-string." > + (version-prefix version-string 1)) > + Seems fine to me. I'm guessing that you added this because it was convenient, but I can't see it being used in the next patch, have I missed it?