From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32896) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e35je-000236-8W for guix-patches@gnu.org; Fri, 13 Oct 2017 15:35:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e35ja-0007Hq-9h for guix-patches@gnu.org; Fri, 13 Oct 2017 15:35:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:57974) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e35ja-0007Hb-6e for guix-patches@gnu.org; Fri, 13 Oct 2017 15:35:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e35jZ-0002TA-UN for guix-patches@gnu.org; Fri, 13 Oct 2017 15:35:01 -0400 Subject: [bug#28594] nototools (required for building Noto from source) Resent-Message-ID: Date: Fri, 13 Oct 2017 20:34:21 +0100 From: Christopher Baines Message-ID: <20171013203421.5662d8a3@cbaines.net> In-Reply-To: <20171013082319.siqlkd6gbzzt7ipz@abyayala> References: <20170925121841.hcaukrjxftvbyvnk@abyayala> <20171001184151.i3nilckvtk4onfo6@abyayala> <20171001184737.o2rsy6dz3b2i5avp@abyayala> <20171013081252.1d028d36@cbaines.net> <20171013082319.siqlkd6gbzzt7ipz@abyayala> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/F8dRzk/h9N/6R=qB3aW.er1"; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: ng0 Cc: 28594@debbugs.gnu.org --Sig_/F8dRzk/h9N/6R=qB3aW.er1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Fri, 13 Oct 2017 08:23:19 +0000 ng0 wrote: > Christopher Baines transcribed 4.7K bytes: > > On Sun, 1 Oct 2017 18:47:37 +0000 > > ng0 wrote: > > =20 > > > * gnu/packages/fontutils.scm (nototools): New variable. > > > --- > > > gnu/packages/fontutils.scm | 44 > > > +++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 43 > > > insertions(+), 1 deletion(-) > > >=20 > > > diff --git a/gnu/packages/fontutils.scm > > > b/gnu/packages/fontutils.scm index 15401f652..ca10c10b0 100644 > > > --- a/gnu/packages/fontutils.scm > > > +++ b/gnu/packages/fontutils.scm > > > @@ -5,6 +5,7 @@ > > > ;;; Copyright =C2=A9 2016, 2017 Efraim Flashner > > > ;;; Copyright =C2=A9 2017 Rene Saavedra > > > ;;; Copyright =C2=A9 2017 Leo Famulari > > > +;;; Copyright =C2=A9 2017 ng0 > > > ;;; > > > ;;; This file is part of GNU Guix. > > > ;;; > > > @@ -44,7 +45,8 @@ > > > #:use-module (guix svn-download) > > > #:use-module (guix git-download) > > > #:use-module (guix build-system cmake) > > > - #:use-module (guix build-system gnu)) > > > + #:use-module (guix build-system gnu) > > > + #:use-module (guix build-system python)) > > > =20 > > > (define-public freetype > > > (package > > > @@ -565,3 +567,43 @@ opentype fonts. You can save fonts in many > > > different outline formats, and generate bitmaps.") > > > (license license:gpl3+) > > > (home-page "https://fontforge.github.io/en-US/"))) > > > + > > > +(define-public nototools > > > + (package > > > + (name "nototools") > > > + (version "20170925") > > > + (source > > > + (origin > > > + (method url-fetch) > > > + (uri (string-append > > > "https://github.com/googlei18n/nototools/" > > > + > > > "archive/v2017-09-25-tooling-for-phase3-" > > > + "update.tar.gz")) > > > + (file-name (string-append name "-" version ".tar.gz")) > > > + (sha256 > > > + (base32 > > > + > > > "1pvacw18cm9l4sb66pqyjc7hc74xhhfxc7kd5ald8lixf4wzg0s8")))) > > > + (build-system python-build-system) > > > + (arguments > > > + `(#:python ,python-2)) > > > + (propagated-inputs > > > + `(("python2-booleanoperations" ,python2-booleanoperations) > > > + ("python2-defcon" ,python2-defcon) > > > + ("python2-fonttools" ,python2-fonttools) > > > + ("python2-pillow" ,python2-pillow) > > > + ("python2-pyclipper" ,python2-pyclipper) > > > + ("python2-ufolib" ,python2-ufolib))) > > > + (home-page "https://github.com/googlei18n/nototools") > > > + (synopsis "Noto fonts support tools and scripts") > > > + (description > > > + "Nototools is a python package containing python scripts > > > used to +maintain the Noto Fonts project.") > > > + (license (list license:asl2.0 > > > + ;; Sample texts are attributed to UN and > > > OHCHR. > > > + ;; The permissions on the UDHR are pretty lax: > > > + ;; > > > http://www.ohchr.org/EN/UDHR/Pages/Introduction.aspx > > > + ;; "If UDHR translations or materials are > > > reproduced, users > > > + ;; should make reference to this website as a > > > source by > > > + ;; providing a link." > > > + license:public-domain > > > + license:non-copyleft > > > "file://sample_texts/attributions.txt" > > > + "See sample_texts/attributions.txt in the > > > distribution.")))) =20 > >=20 > > This whole patchset looks pretty good to me. I've built all the > > packages, but haven't tested them. > >=20 > > guix lint has one complaint here about the license: > >=20 > > gnu/packages/fontutils.scm:591:13: nototools@20170925: invalid > > license field > >=20 > > I'm not quite sure what this means. =20 >=20 > I think I know it, the non-copyleft needs to be adjusted to the list. > Thanks. I really should run lint for longer patchseries. I admit I do > this not very often. > Thanks for your review. You're welcome :) It looks to me like the python-fonttools patch could be merged now, shall I merge it? I only ask as I don't want to mess up your workflow? --Sig_/F8dRzk/h9N/6R=qB3aW.er1 Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAlnhFT1fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XcAEQ/+JZyluYebt9QfEPKVqzQ6myOr6msE0z2l/36MP2qC/s2ecyHiBZDB0cn1 NA4Wjz4PJKG1sBvoLrYi0a1eYjdXHz0OCPccE727ggkcLVncYKxfs7O2hZwHE/k1 VUeTR3qcOzpm1upmgv3JTjKcnqTYOGFmSAEvML2Ezw+5Q7eHLpAw+uDoJzrPmIvL nKEn+4nMBiXn5Qf7mTBPUYGPzclZwniKIOHCFQrz1ogzAd/jYCLNpuZDmNq9kRmE 7/klCNbdKwAIz4gJI0kcC3IAzhxL6v8Y21+xt2xsHjXNfoJGlS022/qMRAs3un4g UoXh5pEE5gIoLVyNeM0Hzu0kDS8da6TxEePw0HphD3QjIxCOJ6FVKdgQ1URD3uZh ZsJ3XYX1qsBUA+6Sba3pjZe0TTcOfgiPxaRYLxaLHEdbnlz2OsHb6smuLSlAoPRX uxzaYBrfi1Eij772WomVy3HcJH293EmeLgEviNgVl+W4rmlD2EpNnUxIQ3VPkkoI JN2JOPNBBEaxvh1C6A035ImnV6TRpc4yXufieECAGcetrPBGFkFYYAL/2+IqRLqT uC2IBPP/2cBAFpPmsFwUGxMwP9fc+CtADuQE9ItdsZFc3+X2xe7glnqknKSottPy ysRATbS8K+/Vhou5RpD8ugvyQt5Lfz9Ulu6X/eEnaxqyiJLK6LU= =/eAb -----END PGP SIGNATURE----- --Sig_/F8dRzk/h9N/6R=qB3aW.er1--