From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55378) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e2vGJ-0002OQ-9Z for guix-patches@gnu.org; Fri, 13 Oct 2017 04:24:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e2vGE-0002kV-PD for guix-patches@gnu.org; Fri, 13 Oct 2017 04:24:07 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:56358) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e2vGE-0002kK-KJ for guix-patches@gnu.org; Fri, 13 Oct 2017 04:24:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e2vGE-0006Jt-F5 for guix-patches@gnu.org; Fri, 13 Oct 2017 04:24:02 -0400 Subject: [bug#28594] nototools (required for building Noto from source) Resent-Message-ID: Date: Fri, 13 Oct 2017 08:23:19 +0000 From: ng0 Message-ID: <20171013082319.siqlkd6gbzzt7ipz@abyayala> References: <20170925121841.hcaukrjxftvbyvnk@abyayala> <20171001184151.i3nilckvtk4onfo6@abyayala> <20171001184737.o2rsy6dz3b2i5avp@abyayala> <20171013081252.1d028d36@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="nufuf434leqjre7x" Content-Disposition: inline In-Reply-To: <20171013081252.1d028d36@cbaines.net> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Christopher Baines Cc: 28594@debbugs.gnu.org --nufuf434leqjre7x Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Christopher Baines transcribed 4.7K bytes: > On Sun, 1 Oct 2017 18:47:37 +0000 > ng0 wrote: >=20 > > * gnu/packages/fontutils.scm (nototools): New variable. > > --- > > gnu/packages/fontutils.scm | 44 > > +++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 43 > > insertions(+), 1 deletion(-) > >=20 > > diff --git a/gnu/packages/fontutils.scm b/gnu/packages/fontutils.scm > > index 15401f652..ca10c10b0 100644 > > --- a/gnu/packages/fontutils.scm > > +++ b/gnu/packages/fontutils.scm > > @@ -5,6 +5,7 @@ > > ;;; Copyright =C2=A9 2016, 2017 Efraim Flashner > > ;;; Copyright =C2=A9 2017 Rene Saavedra > > ;;; Copyright =C2=A9 2017 Leo Famulari > > +;;; Copyright =C2=A9 2017 ng0 > > ;;; > > ;;; This file is part of GNU Guix. > > ;;; > > @@ -44,7 +45,8 @@ > > #:use-module (guix svn-download) > > #:use-module (guix git-download) > > #:use-module (guix build-system cmake) > > - #:use-module (guix build-system gnu)) > > + #:use-module (guix build-system gnu) > > + #:use-module (guix build-system python)) > > =20 > > (define-public freetype > > (package > > @@ -565,3 +567,43 @@ opentype fonts. You can save fonts in many > > different outline formats, and generate bitmaps.") > > (license license:gpl3+) > > (home-page "https://fontforge.github.io/en-US/"))) > > + > > +(define-public nototools > > + (package > > + (name "nototools") > > + (version "20170925") > > + (source > > + (origin > > + (method url-fetch) > > + (uri (string-append "https://github.com/googlei18n/nototools/" > > + "archive/v2017-09-25-tooling-for-phase3-" > > + "update.tar.gz")) > > + (file-name (string-append name "-" version ".tar.gz")) > > + (sha256 > > + (base32 > > + "1pvacw18cm9l4sb66pqyjc7hc74xhhfxc7kd5ald8lixf4wzg0s8")))) > > + (build-system python-build-system) > > + (arguments > > + `(#:python ,python-2)) > > + (propagated-inputs > > + `(("python2-booleanoperations" ,python2-booleanoperations) > > + ("python2-defcon" ,python2-defcon) > > + ("python2-fonttools" ,python2-fonttools) > > + ("python2-pillow" ,python2-pillow) > > + ("python2-pyclipper" ,python2-pyclipper) > > + ("python2-ufolib" ,python2-ufolib))) > > + (home-page "https://github.com/googlei18n/nototools") > > + (synopsis "Noto fonts support tools and scripts") > > + (description > > + "Nototools is a python package containing python scripts used to > > +maintain the Noto Fonts project.") > > + (license (list license:asl2.0 > > + ;; Sample texts are attributed to UN and OHCHR. > > + ;; The permissions on the UDHR are pretty lax: > > + ;; > > http://www.ohchr.org/EN/UDHR/Pages/Introduction.aspx > > + ;; "If UDHR translations or materials are > > reproduced, users > > + ;; should make reference to this website as a > > source by > > + ;; providing a link." > > + license:public-domain > > + license:non-copyleft > > "file://sample_texts/attributions.txt" > > + "See sample_texts/attributions.txt in the > > distribution.")))) >=20 > This whole patchset looks pretty good to me. I've built all the > packages, but haven't tested them. >=20 > guix lint has one complaint here about the license: >=20 > gnu/packages/fontutils.scm:591:13: nototools@20170925: invalid license > field >=20 > I'm not quite sure what this means. I think I know it, the non-copyleft needs to be adjusted to the list. Thanks. I really should run lint for longer patchseries. I admit I do this not very often. Thanks for your review. > I think it would be good to fix at least the linting issues, then this > can be merged. --=20 ng0 GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588 GnuPG: https://dist.ng0.infotropique.org/dist/keys/ https://www.infotropique.org https://ng0.infotropique.org --nufuf434leqjre7x Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEqIyK3RKYKNfqwC5S4i+bv+40hYgFAlngd/cACgkQ4i+bv+40 hYhodw//fZdCcL8oaZjgaCWedbO7vQh5N+tfSu3Rfd9veahuDOUL4n0KLTeIsibz 6rSv7DVGFhfSvXDweKr0SkkwrMwq9KxbR4iAgIs7JfCfZA8nFhqsQ/Ta/4u8jOGi 3J9hLc6GZrvNcCGqPRTOMPntfq116Qhl1s1qKFlOVjnjGoC0TEqPNg3SuK5bPQ4k 6rY8ZsOsfO8wjMvBLsK0GWC3Q5ctthcDH6AN6YaT9gHdHap+G6XQCgg8teKgoxKS KIVKI3zjpcor9oOTeM7qJH9x4CfcsF0OrakR6rOBNJCqcuIIj7tgyjKczP2NTK3B D5UdLHJlbvCPmXFZX4XcrD1U+UiIJLx5QKiWankOw5BmjcBWwuQcKla/U3hjmBIx 0eVELbvMIOJ/T/fQEsBcZdDJpgpRIZYdRdG9LVKTLhSsXibgXTI6t0EEYzFbQxzr fEA1ttqehcIfqI37drhZhyVGrFzmh20VRG4w3eSmrfyzJNxqaz0+dbwyhfjirxYb zk+acDH0fwBR2L+D9hIMJatDHBrO9LwOiS+E/Psr9UNNjZkJd4WJsT1oprDQ7Wgu nY7GM3P/fjz9UKgwPVE8TUrkLzmxMekks9joolxov/zyCw8dEtFyR+ajLCcvUDCU bkyz0mpSYwM62BJomwVwTk1xV3RFn3y4ZzCiGyvFSzcAaW4bqsc= =4cFD -----END PGP SIGNATURE----- --nufuf434leqjre7x--