From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41818)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1e2uAX-00073X-20
	for guix-patches@gnu.org; Fri, 13 Oct 2017 03:14:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1e2uAT-0005Ug-TI
	for guix-patches@gnu.org; Fri, 13 Oct 2017 03:14:05 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:56243)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1e2uAT-0005Uc-Oq
	for guix-patches@gnu.org; Fri, 13 Oct 2017 03:14:01 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1e2uAT-0000eD-Jw
	for guix-patches@gnu.org; Fri, 13 Oct 2017 03:14:01 -0400
Subject: [bug#28594] nototools (required for building Noto from source)
Resent-Message-ID: <handler.28594.B28594.15078787842402@debbugs.gnu.org>
Date: Fri, 13 Oct 2017 08:12:52 +0100
From: Christopher Baines <mail@cbaines.net>
Message-ID: <20171013081252.1d028d36@cbaines.net>
In-Reply-To: <20171001184737.o2rsy6dz3b2i5avp@abyayala>
References: <20170925121841.hcaukrjxftvbyvnk@abyayala>
	<20171001184151.i3nilckvtk4onfo6@abyayala>
	<20171001184737.o2rsy6dz3b2i5avp@abyayala>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	boundary="Sig_/Zm9zq1VAX_/2qcIr=wPNf8s";
	protocol="application/pgp-signature"
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: ng0 <ng0@infotropique.org>
Cc: 28594@debbugs.gnu.org

--Sig_/Zm9zq1VAX_/2qcIr=wPNf8s
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Sun, 1 Oct 2017 18:47:37 +0000
ng0 <ng0@infotropique.org> wrote:

> * gnu/packages/fontutils.scm (nototools): New variable.
> ---
>  gnu/packages/fontutils.scm | 44
> +++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 43
> insertions(+), 1 deletion(-)
>=20
> diff --git a/gnu/packages/fontutils.scm b/gnu/packages/fontutils.scm
> index 15401f652..ca10c10b0 100644
> --- a/gnu/packages/fontutils.scm
> +++ b/gnu/packages/fontutils.scm
> @@ -5,6 +5,7 @@
>  ;;; Copyright =C2=A9 2016, 2017 Efraim Flashner <efraim@flashner.co.il>
>  ;;; Copyright =C2=A9 2017 Rene Saavedra <rennes@openmailbox.org>
>  ;;; Copyright =C2=A9 2017 Leo Famulari <leo@famulari.name>
> +;;; Copyright =C2=A9 2017 ng0 <ng0@infotropique.org>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -44,7 +45,8 @@
>    #:use-module (guix svn-download)
>    #:use-module (guix git-download)
>    #:use-module (guix build-system cmake)
> -  #:use-module (guix build-system gnu))
> +  #:use-module (guix build-system gnu)
> +  #:use-module (guix build-system python))
> =20
>  (define-public freetype
>    (package
> @@ -565,3 +567,43 @@ opentype fonts.  You can save fonts in many
> different outline formats, and generate bitmaps.")
>     (license license:gpl3+)
>     (home-page "https://fontforge.github.io/en-US/")))
> +
> +(define-public nototools
> +  (package
> +    (name "nototools")
> +    (version "20170925")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "https://github.com/googlei18n/nototools/"
> +                           "archive/v2017-09-25-tooling-for-phase3-"
> +                           "update.tar.gz"))
> +       (file-name (string-append name "-" version ".tar.gz"))
> +       (sha256
> +        (base32
> +         "1pvacw18cm9l4sb66pqyjc7hc74xhhfxc7kd5ald8lixf4wzg0s8"))))
> +    (build-system python-build-system)
> +    (arguments
> +     `(#:python ,python-2))
> +    (propagated-inputs
> +     `(("python2-booleanoperations" ,python2-booleanoperations)
> +       ("python2-defcon" ,python2-defcon)
> +       ("python2-fonttools" ,python2-fonttools)
> +       ("python2-pillow" ,python2-pillow)
> +       ("python2-pyclipper" ,python2-pyclipper)
> +       ("python2-ufolib" ,python2-ufolib)))
> +    (home-page "https://github.com/googlei18n/nototools")
> +    (synopsis "Noto fonts support tools and scripts")
> +    (description
> +     "Nototools is a python package containing python scripts used to
> +maintain the Noto Fonts project.")
> +    (license (list license:asl2.0
> +                   ;; Sample texts are attributed to UN and OHCHR.
> +                   ;; The permissions on the UDHR are pretty lax:
> +                   ;;
> http://www.ohchr.org/EN/UDHR/Pages/Introduction.aspx
> +                   ;; "If UDHR translations or materials are
> reproduced, users
> +                   ;; should make reference to this website as a
> source by
> +                   ;; providing a link."
> +                   license:public-domain
> +                   license:non-copyleft
> "file://sample_texts/attributions.txt"
> +                   "See sample_texts/attributions.txt in the
> distribution."))))

This whole patchset looks pretty good to me. I've built all the
packages, but haven't tested them.

guix lint has one complaint here about the license:

gnu/packages/fontutils.scm:591:13: nototools@20170925: invalid license
field

I'm not quite sure what this means.

I think it would be good to fix at least the linting issues, then this
can be merged.

--Sig_/Zm9zq1VAX_/2qcIr=wPNf8s
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAlngZ3RfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF
ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE
9Xcr8g/9H2vbDw/0gv+NMZBw2NKEy+jfNIdBI1TaX53CeVu7EsnKbPkhnSL1XnPk
N4CRfw6SN33WZo6yYdNThYRmI1j+ZQoHHw9uZCUUC0nP4CP51flhimu1wgeMUJlm
AFRIo0fny31Ge66QhvFycQDKJx4gDV2psOkSj9X+ZIECTEmi5EyNPecZQTi53RnB
nR7EIoriiQioQvujyNNAK3Fnqgm4vqufO7Qh625R2gUDPLHITUAoXuFfdZ059RDU
NYtZeRXgqL72Eck/YsuNcrJz7SXFvdC3z1GM6dDR+HlZ5ijy7rRacMGhDh6E9bo8
mpf45Adp1/0TVZrqOKEAm/mjK4DfoLQUhypTruEoiIfsdK3Fp22RcUJgbROOnnCx
Thto8kq200r+TZmo+Sdkfyz0NQeB4fa2xoeBR+UrQwaQDH6I1xaXQ8CKDDSvlvNX
6ghjERYduh7yZL0h8F5kcSzz1CW1o+kwj+ZIR4StaOzZ9jpa6wm7X5W2t0QkUOmq
2yLKEVl8Yyrf/lkiHwcQXAlf4yTAynPsRHnIrvmmGroe8zzVkJFjqw6Sbu3/ZGVF
rnNHqJik7bA7NVB8D8y19Nkb5h7RVgh5fwSZyJnLZwJg+7ZdcE9fshqDGNsPloQs
6NT3S9dXxAgbPI1ZLRJGDgIzPEJUCQ/t+Hpa3YXmMjSgHs0FUaM=
=ADU7
-----END PGP SIGNATURE-----

--Sig_/Zm9zq1VAX_/2qcIr=wPNf8s--