From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36362) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dzeRT-0007Yz-JR for guix-patches@gnu.org; Wed, 04 Oct 2017 03:50:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dzeRP-0003cd-Be for guix-patches@gnu.org; Wed, 04 Oct 2017 03:50:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:38728) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dzeRP-0003cU-7Y for guix-patches@gnu.org; Wed, 04 Oct 2017 03:50:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dzeRO-0002X8-WF for guix-patches@gnu.org; Wed, 04 Oct 2017 03:50:03 -0400 Subject: [bug#28660] [PATCH] gnu: python-numpy: Give sh store location instead of setting $SHELL. Resent-Message-ID: Date: Wed, 4 Oct 2017 08:49:44 +0100 From: Christopher Baines Message-ID: <20171004084944.16af59c8@cbaines.net> In-Reply-To: <20171004.090436.431865073991228123.post@thomasdanckaert.be> References: <20171001.144404.698351802734865623.post@thomasdanckaert.be> <20171004073048.1187465b@cbaines.net> <20171004.090436.431865073991228123.post@thomasdanckaert.be> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/UfDuSVxH8+wWiIjKk1pghlD"; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Thomas Danckaert Cc: 28660@debbugs.gnu.org --Sig_/UfDuSVxH8+wWiIjKk1pghlD Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Wed, 04 Oct 2017 09:04:36 +0200 (CEST) Thomas Danckaert wrote: > From: Christopher Baines > Subject: Re: [bug#28660] [PATCH] gnu: python-numpy: Give sh store=20 > location instead of setting $SHELL. > Date: Wed, 4 Oct 2017 07:30:48 +0100 >=20 > > Could bash be specified as an input, and that used instead? This=20 > > would > > mean that the behaviour of the package is more isolated from the > > environment. =20 >=20 > Sounds good, but I'm afraid I don't understand what you mean (maybe=20 > it's still too early in the morning). If we add a "bash" to the=20 > package inputs, it will still come from the store. So probably you=20 > mean something else by =E2=80=9Cspecified as an input=E2=80=9D? >=20 > > For example, on non GuixSD systems, /bin/sh could be something other > > than bash. But, if the numpy package depends on some bash in the=20 > > store, > > and uses that, then it would be isolated from this. =20 >=20 > That's true, though users on such systems could set $SHELL to=20 > override the default one from the store. But maybe avoiding having=20 > to do that is what you mean by =E2=80=9Cmore isolated from the environmen= t=E2=80=9D? >=20 > The shell is used for very limited purposes anyway (essentially to=20 > run C and Fortran compilers to build extenstions, AFAIU), but I'm=20 > happy to improve the patch if it's useful. If you have a solution=20 > that allows users to use their own /bin/sh if they want, but still=20 > works for all builds of dependent packages on Guix, please explain :-) Sorry Thomas, ignore what I originally said. I thought from reading the patch that this was patching numpy to use /bin/sh . Now after building it and looking at the resulting files, I can see that it makes the default use bash from the store [1]. Which was exactly what I was suggesting, but you were already doing that. With this new, hopefully more correct interpretation, this patch looks fine to me :) 1:=20 sh =3D os.environ.get('SHELL', '/gnu/store/kpxi8h3669afr9r1bgvaf9ij3y4wdyyn= -bash-minimal-4.4.12/bin/sh') --Sig_/UfDuSVxH8+wWiIjKk1pghlD Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAlnUkphfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XePhxAAn6uJ3ZH8K2hfy8RfDkHZFiN7daQzr6VhF4gvHIqBOZE5VMZ+wAQnQuOP rhwpbiQYdL3Z10heu21R8xEfW92eRVGgoAqL6LCNN5FbMxtujYpXJnD3mJw0PIXr RdeGVQ7BgJExpP762nK5exACu2cSWrgPwFJ+cg/ZYpIZTSeOKTkplaYAtoGnGsHl t9ksmUh6RFcIgxUpvgNj/cuezCWF32YJFTFvFxU3Wa+SjzBiLOqeS/H/4oE1CiYx Sfs3C3JeSwweOePederBTTfieDAzhExEG5fPX19LJXjpqj4vm0vyQ4W5clNcLGlH xQpm7jbHgdQwCqparTF9ko08u2UdCYe4g7HaVCXFM5Ojp9/g1ARRv31ZjGZMRWxg NN68qfX5i/q7LPoCsH9T2tDDpGBCCGSh4hhxzOt/COYwbqeZ0wOHMtPxdZ3rAShm OjJNn+0lc+sLLTi+FzHHbxyWmZwHZd1nrMtbWmmO/+mj2bGlE7nbAXJda6AL0y2B ISRFMQ4hPf2xijNr/TSr8Bo1LmJYRDsoKCLxwmutsKxRtZO8kmKYS3vUhxSGSFzU jWZ2BMrBqYX4ZfIgwohSgkpdzKZkd+csCsJFnGSJymI//8qLIZ7D7jMw885+dBNw dLO545nFOmao2e/Hq6rLQNH0FSVEtUt+VMeQE0D1/HBFPvtMfz8= =Zwpp -----END PGP SIGNATURE----- --Sig_/UfDuSVxH8+wWiIjKk1pghlD--