From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43359) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dzdD0-00083J-UF for guix-patches@gnu.org; Wed, 04 Oct 2017 02:31:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dzdCw-0005aV-0d for guix-patches@gnu.org; Wed, 04 Oct 2017 02:31:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:38605) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dzdCv-0005aP-TO for guix-patches@gnu.org; Wed, 04 Oct 2017 02:31:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dzdCv-0000LB-JS for guix-patches@gnu.org; Wed, 04 Oct 2017 02:31:01 -0400 Subject: [bug#28660] [PATCH] gnu: python-numpy: Give sh store location instead of setting $SHELL. Resent-Message-ID: Date: Wed, 4 Oct 2017 07:30:48 +0100 From: Christopher Baines Message-ID: <20171004073048.1187465b@cbaines.net> In-Reply-To: <20171001.144404.698351802734865623.post@thomasdanckaert.be> References: <20171001.144404.698351802734865623.post@thomasdanckaert.be> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/_jmNpOO3ncg33Tx=J=HdMnR"; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Thomas Danckaert Cc: 28660@debbugs.gnu.org --Sig_/_jmNpOO3ncg33Tx=J=HdMnR Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Sun, 01 Oct 2017 14:44:04 +0200 (CEST) Thomas Danckaert wrote: > Hi Guix, >=20 > I slightly botched the last numpy update: setting $SHELL works, but=20 > then we have to set $SHELL for every package which uses numpy's=20 > distutils. I don't know how many packages there are, but it includes=20 > scipy and python-hdf (and therefore those builds are currently broken=20 > on master...). >=20 > The attached patch should fix the issue for all packages, by setting=20 > the default shell to the =E2=80=9C/bin/sh=E2=80=9D of the build environme= nt's bash=20 > package (i.e. bash-minimal). Could bash be specified as an input, and that used instead? This would mean that the behaviour of the package is more isolated from the environment. For example, on non GuixSD systems, /bin/sh could be something other than bash. But, if the numpy package depends on some bash in the store, and uses that, then it would be isolated from this. What do you think? --Sig_/_jmNpOO3ncg33Tx=J=HdMnR Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAlnUgBhfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XcU7g//XoiEEA5ueJqiTVCOoMA+t30/s9Ncur0oGAOfc/Hjmj9M1YW8TRwEQHZd pCzHcxQQxyKV4wIyCZ5OAM5B6eJoe9pJ9L1ZaRom4BGZ2BQe9GKA9tyhKTZJ07w/ jew+A455lE3JEIiJwT0FMcfKzd8wBO3k8+PDH8w8VCpwHOG1+wUvBcXptp0wnMnm /mg+WcwwxwOac8TyWYABxlXONdIL4J0QlPN9kgpsrq7R3hG6xs5cI12Y6RCnBwiL cUzG8QaBhUXvyIZcK1NfU92ai1HykFPIotiS0AaScAxUj1CPx7XkVQc+U1pLqHeD E32lSqEtbkVgZ814pmYhTCa8zsZqRjtaf31KIqOn6w6r29iTe+DDOKcwfQXkksdn JcXt2zd6PBnZiL6oTWNNGretS0P9Ba97bHxFRXDlH9avr6RSa/Lu+NQAhDpyjNzd 1F6AgiZmCUxp7BJRdpahYOoVSfmf/vAhffLPgLj0Kf1VFb+Nza/tH4UPp1izTS1j SoWb+utzvf1xZcwsYxTFFxflq1rYBq8CgiqEiBhwwAt0Wmytr4+hDm83VCYpKW5c 66rlRyEVyoYkgnUV0zs8ERXv3wRqkYpzzkh4Am9wWSqG3uNZRar39bgVU2xGYtVF Lls/UrtUsV9S20UWfkVe/NIvtFCqPDHypdOPDpZuUqryrNFuPyU= =B1jR -----END PGP SIGNATURE----- --Sig_/_jmNpOO3ncg33Tx=J=HdMnR--