From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47503) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dyavp-0007EQ-Vw for guix-patches@gnu.org; Sun, 01 Oct 2017 05:53:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dyavm-00041S-Tn for guix-patches@gnu.org; Sun, 01 Oct 2017 05:53:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:33067) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dyavm-000418-Ql for guix-patches@gnu.org; Sun, 01 Oct 2017 05:53:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dyavm-0000Kl-IR for guix-patches@gnu.org; Sun, 01 Oct 2017 05:53:02 -0400 Subject: bug#28170: Add gnutls/dane + use it where its needed (gnurl, libmicrohttpd, gnunet) Resent-To: guix-patches@gnu.org Resent-Message-ID: Date: Sun, 1 Oct 2017 10:52:39 +0100 From: Christopher Baines Message-ID: <20171001105239.491d5919@cbaines.net> In-Reply-To: <20170930163605.x4sl5irccreah67l@abyayala> References: <20170821095726.qtf2ko526nup4yba@abyayala> <20170930122616.17079913@cbaines.net> <20170930122309.akl2dxa46eru36pb@abyayala> <20170930134346.54a4c54a@cbaines.net> <20170930140144.yenmf7pr2ffecmll@abyayala> <20170930141255.yrnasw4aenfl77n4@abyayala> <20170930153444.3e49436f@cbaines.net> <20170930145636.dpri5bh7ipy22mib@abyayala> <20170930150152.oqwfd7ff5xshkt4s@abyayala> <20170930170504.1c476ed8@cbaines.net> <20170930163605.x4sl5irccreah67l@abyayala> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/8GjceARPhDjGo5OSSAU+oEM"; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: ng0 Cc: 28170-done@debbugs.gnu.org --Sig_/8GjceARPhDjGo5OSSAU+oEM Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Sat, 30 Sep 2017 16:36:05 +0000 ng0 wrote: > Christopher Baines transcribed 3.6K bytes: > > On Sat, 30 Sep 2017 15:01:52 +0000 > > ng0 wrote: > > =20 > > > ng0 transcribed 2.1K bytes: =20 > > > > Christopher Baines transcribed 1.7K bytes: =20 > > > > > On Sat, 30 Sep 2017 14:12:55 +0000 > > > > > ng0 wrote: > > > > > =20 > > > > > > The fix in this version is to only add the necessary input > > > > > > to the inherited gnutls. =20 > > > > >=20 > > > > > Ok. One hopefully final thing. From the commit message [1], > > > > > it's not clear to me if this is fixing an issue with the > > > > > GNUnet package, by providing it with the right dependencies, > > > > > or, adding additional functionality to the GNUnet package, by > > > > > providing a more capable GnuTLS? > > > > >=20 > > > > > 1: "GNUnet and its dependency chain needs GnuTLS with DANE > > > > > support." =20 > > > > It provides the right GnuTLS to GNUnet, libmicrohttpd and gnURL. > > > > Certain features of these applications will not work without it. > > > > GnuTLS without Dane is not fatal error for these packages, but > > > > Dane is recommended. > > > > I have no idea how I should put this into the very strict > > > > dictionary we have in commit messages=E2=80=A6 In more free-form it > > > > would be no problem for me. > > > > --=20 > > > > ng0 > > > > GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588 > > > > GnuPG: https://krosos.org/dist/keys/ > > > > https://www.infotropique.org https://krosos.org =20 > > >=20 > > > Okay, I now see what you mean. > > >=20 > > > To make it short: the correct dependency is provided in place > > > of the current working-but-not-correct GnuTLS. > > >=20 > > > Is that more clear? =20 > >=20 > > I think you've made it clear to me now. > >=20 > > From what you're saying, I think its the 2nd thing I said. Making > > this change will enable some functionality in the GNUnet package > > (and possibly some of the other packages changed). > >=20 > > I'm not sure using the word "correct" helps, unless you say what the > > dependencies are correct/incorrect with respect to, for example, if > > the GNUnet documentation says that it should be built with GnuTLS > > with Dane support, then that would be a reason to talk about > > correctness. =20 >=20 > Yes it does state this, in the documentation and all these > applications list the dependency in README aswell. > This is why I thought the original, first version, comment I made in > gnutls/dane was enough. But I'll have to be more clear then. > Well if gnURL doesn't state it in its README I have to add it, if it's > not in there it's my mistake - it's correct nevertheless. >=20 > > As for the commit format. As I understand the conventions, you can > > put anything in between the first line, and the changelog at the > > bottom. For example, one case where I ended up writing quite a bit > > is here [1]. > >=20 > > It doesn't have to be very specific, but something about the intent > > or intended effect of the change in each commit would be very > > useful. > >=20 > > 1: > > http://git.savannah.gnu.org/cgit/guix.git/commit/?id=3D6230e155afd8c43c= 12ee3f03032aac34433db11a =20 >=20 > Okay, thanks. I will change the commit messages and > reference our (GNUnet) README and documentation sections. I've now merged the patches that were attached to this email :) Thanks, Chris --Sig_/8GjceARPhDjGo5OSSAU+oEM Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAlnQuudfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XdfGw//SVHX9ypTUv6qIERdhRKN+ejWCWQt5QfRw/m4KCCtCdocjjjhvbs1vGUL 6nFn9z8UPaWco+2C0IrcwEFw63P4OfM1SaOeR5zy+JeE2MI5lXa/oDGyIUyqalYA E78JflB+4yNKPVW8VVHxunLPFw7QvR5SVNCixeeZrsQmV6WvOfzj0rCvd1+7Tq4h szAp9wJcxWXLQpsLfT+W97e2Wlfj2uNX0sTAYBsdBXaC+RfDpwMU40ETezetBS8k X8Sj1yKoQN7nTiWm8t+OwY2ylr3CAVmbbLJTllU4BH/v9UKYYGRhYwsW8+MgSLD8 n/tThT0P+tMcCWGd3DCMANSMJeP+sGJTdxDMAKFxWD5PwP7uXnFP1gfpDrypvqzm vTmJZ1zWKHG2ymeH8kvlzjckVR+2gXnrpa1XZlvDsM3L7XqwiNBlAwgDVD9evQnK PSyKGCH+ErL2T6IjflF3VHyD0tdFfa5tZfdVyBD7HjC/LEEgIz2gr/4h9tpzGqF3 zxRk3jjrm94NQtCSIKqsf32cbBpiKhC+UztYMXOYRgRn05iArpyO1vFDZdZAIgup /X0RFdrzPNInYPRa1loeRPoIyHsRt/HwledSG2CJc3HU51efE1wLQpLUGSiRqF4o jiTFBjB/DNuL+qVpnqsTCGcDbN9P6GNzgINbY/hd2eJEaSSw7LE= =Zu28 -----END PGP SIGNATURE----- --Sig_/8GjceARPhDjGo5OSSAU+oEM--