From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57090) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dyJmH-00025n-EL for guix-patches@gnu.org; Sat, 30 Sep 2017 11:34:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dyJmE-0007dV-A1 for guix-patches@gnu.org; Sat, 30 Sep 2017 11:34:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:60875) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dyJmE-0007dR-6C for guix-patches@gnu.org; Sat, 30 Sep 2017 11:34:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dyJmE-0006fR-10 for guix-patches@gnu.org; Sat, 30 Sep 2017 11:34:02 -0400 Subject: [bug#28398] Xfburn Resent-Message-ID: Date: Sat, 30 Sep 2017 15:33:05 +0000 From: ng0 Message-ID: <20170930153305.zxnazcebzcfodmez@abyayala> References: <20170909141504.5nhlbp5ocrygqwhw@abyayala> <20170930161423.5a8f5a8d@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="nxfyc5dldmvopq4p" Content-Disposition: inline In-Reply-To: <20170930161423.5a8f5a8d@cbaines.net> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Christopher Baines Cc: 28398@debbugs.gnu.org --nxfyc5dldmvopq4p Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Christopher Baines transcribed 3.8K bytes: > On Sat, 9 Sep 2017 14:15:04 +0000 > ng0 wrote: >=20 > > This adds Xfburn + 2 libburnia packages it depends on. > >=20 > > What I could not test was actually burning a disk, > > as I can't afford to buy new optical disks at the moment. > >=20 > > It builds. >=20 > It builds for me too :) >=20 > Looking at the libburn package. >=20 > > + (synopsis "library for reading, mastering and writing optical > > discs") >=20 > guix lint says: >=20 > gnu/packages/cdrom.scm:717:14: libburn@1.4.6: synopsis should start > with an upper-case letter or digit Ok. > > + (description > > + "libburn is the library by which preformatted data get onto optic= al media. > > +It uses either @file{/dev/sgN} (e.g. on kernel 2.4 with ide-scsi) or @= file{/dev/srM} > > +or @file{/dev/hdX} (e.g. on kernel 2.6). libburn is the foundation of= the > > +libburnia-project cdrecord emulation. Its code is independent of cdre= cord.") >=20 > I'm unsure about the first sentence, "libburn is the library" makes it > sounds like there is only one library (this one) that does this. Would > something like "libburn is a library to write preformatted data to > optical media" work? >=20 > Also, I don't get the cdrecord reference at the end. Tbh I took this 1:1 from upstream. They don't really provide a good insight= into what's what as far as I remember. > Looking at the libisofs package. >=20 > > + (synopsis "library for reading, mastering and writing optical disc= s") >=20 > guix lint says: >=20 > gnu/packages/cdrom.scm:742:14: libisofs@1.4.6: synopsis should start > with an upper-case letter or digit >=20 > Also, this is the same as the libburn package, which probably means > they need tweaking to be more useful. >=20 > > + (description > > + "libisofs is a library to create an ISO-9660 filesystem, supports= extensions >=20 > I think this would read better split in to two sentences, as in "... > filesystem. It supports" >=20 > > +like RockRidge or Joliet, and introduces an own extension AAIP. It is= a full >=20 > I think this would read better if you swap out "an" for "its". >=20 > > +featured ISO-9660 editor which composes and changes the directory tree= of an > > +ISO image. This tree and its newly imported data file contents get th= en >=20 > I think this would read better if you swap the order of "get" and > "then", as in "imported data file contents then get". >=20 > Looking finally at the xfburn package. >=20 > The description seems a bit odd to me, as things like blanking CDs, or > compositions are not terms I've heard commonly, but I think this is ok. >=20 > I had some broken icons when I tried running this, and got some > corresponding warnings, but this could be because I'm using Gnome and > not XFCE. >=20 > (xfburn:15797): Gtk-WARNING **: Error loading theme icon > 'stock_xfburn-audio-cd' for stock: Icon 'stock_xfburn-audio-cd' not > present in theme Not a blocking issue (the icons) but Xfburn is not limited to Xfce, so we should figure out which icon-set is needed. >=20 > Thanks for the patches, and let me know if the proofreading the > descriptions is helpful?=09 Well I still don't know more about burning disk application interiors. Can you come up with better descriptions? It is hard for me to take https://dev.lovelyhq.com/libburnia/web/wikis/home and the descriptions linked in there and to decide what is useful. --=20 ng0 GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588 GnuPG: https://krosos.org/dist/keys/ https://www.infotropique.org https://krosos.org --nxfyc5dldmvopq4p Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEqIyK3RKYKNfqwC5S4i+bv+40hYgFAlnPuTEACgkQ4i+bv+40 hYidLg/9Ggy0+MTZjJvHUckIc7O7WnBw5K08Uci6NL8MV3f3KIBHhVaLyJOLWB/3 cjSZgRAe7hZMQ+qONHpTee+lV+r2gNEIMUnUifJbIuDBFXr6Q7QQ7Hj1OUy1VZr+ EvER2ixbHz81cPDyMPbkbeWvHuywSo+IBzcczc7MUtnkaZ4a6B+R4nwGygHpo3YB L4Cjf0ukclIyj82+CWxNL1W3yYoRTboJMooRgv1sSsjFWrK9IeeSxl+vpOy49Q/m yEUhWbzYl+meHhWEoxl/Z5U5BXcHby0lTez167ch9KD8A+ZS8/+6sgMxyNGKbC/X xQyoap+rz1/69zkbQubmaOQBE0JhvqyJf+vy/Mi94xZvypuK52+TmOn0Ke/8UDz2 0qCCp2sx0BSO7t2XEGMjBbEXeEChBjVZ9V2pFo56+k8Hu4gZzMIwDMSkE93Gulgq aitP4X7a6gYuTbnAU2THkw4aIVJt9eirU0kayulFbKkTSZkr+HTDiOZdNmtn//sz qPfUyZ0UuvCjyzQx/9V/g+GpDnZyEktUj9LuNon/iBfS09yioIYoBHyHZBXQ6KHN Ox21EKMf00AjLYDIN/pDlK+5wqhbzYRnPj0thzlGHF80KCcM22y38oWXBZRuI1MJ yNTJuMDyQbdZpHWENE1ZHVzXrihlxFopPScHOu3Lw9mjobSwB3I= =qyMs -----END PGP SIGNATURE----- --nxfyc5dldmvopq4p--