From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43698) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dyD65-0006cQ-4q for guix-patches@gnu.org; Sat, 30 Sep 2017 04:26:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dyD61-0002eO-Vw for guix-patches@gnu.org; Sat, 30 Sep 2017 04:26:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:59560) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dyD61-0002eH-SE for guix-patches@gnu.org; Sat, 30 Sep 2017 04:26:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dyD61-0000qq-ID for guix-patches@gnu.org; Sat, 30 Sep 2017 04:26:01 -0400 Subject: [bug#28583] [PATCH 7/7] gnu: Add es-dump-restore. Resent-Message-ID: Date: Sat, 30 Sep 2017 09:25:23 +0100 From: Christopher Baines Message-ID: <20170930092523.4f4fcf34@cbaines.net> In-Reply-To: <5ee025a9-da9b-b178-8649-f72f532467b5@uq.edu.au> References: <20170924171717.3855-1-mail@cbaines.net> <20170924171717.3855-7-mail@cbaines.net> <5ee025a9-da9b-b178-8649-f72f532467b5@uq.edu.au> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/k_HpX.HO5h0Vm859Zrx_IXJ"; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ben Woodcroft Cc: 28583@debbugs.gnu.org --Sig_/k_HpX.HO5h0Vm859Zrx_IXJ Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Thu, 28 Sep 2017 18:38:19 +1000 Ben Woodcroft wrote: > On 25/09/17 03:17, Christopher Baines wrote: > > * gnu/packages/databases.scm (es-dump-restore): New variable. =20 > [..] > > + (arguments > > + '(#:tests? #f =20 > Including a reason here would be good. Done, turns out the reason is that there is no testsuite. > > + #:phases > > + (modify-phases %standard-phases > > + (add-after 'install 'wrap-bin-es_dump_restore > > + (lambda* (#:key outputs #:allow-other-keys) > > + (wrap-program (string-append (assoc-ref outputs "out") > > + "/bin/es_dump_restore") > > + `("GEM_PATH" ":" prefix (,(string-append > > + (getenv "GEM_PATH") > > + ":" > > + (getenv "GEM_HOME"))))) > > + #t))))) =20 > Again, it would be preferable to have this done as part of the build=20 > system, but OK. >=20 > > + (propagated-inputs > > + `(("ruby-httpclient" ,ruby-httpclient) > > + ("ruby-multi-json" ,ruby-multi-json) > > + ("ruby-progress_bar" ,ruby-progress_bar) > > + ("ruby-rubyzip" ,ruby-rubyzip) > > + ("ruby-thor" ,ruby-thor))) > > + (synopsis > > + "Utility for dumping and restoring ElasticSearch indexes") =20 > This can be moved onto the previous line. >=20 > > + (description > > + "This package provides a utility for dumping the contents of > > an +ElasticSearch index to a compressed file and restoring the > > dumpfile back to an +ElasticSearch server") > > + (home-page > > + "https://github.com/patientslikeme/es_dump_restore") =20 > As can this. Otherwise LGTM - thanks for this series. These two formatting issues should be fixed now. Thanks for the review and patches Ben. I've sent an updated set of patches. --Sig_/k_HpX.HO5h0Vm859Zrx_IXJ Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAlnPVPNfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9Xfkcg//fsdyCJrvj13t5c1CKSmYnbTO719F12IKWlBD0Ms2D8lhICarZKulH8na 7aWZjkS8KlvN9pDQh/KZk4GbdvezNbzfbZFKmG22uq0yMf3vok+94brPaUvmdNY4 6OZPy67EQ94LF2Y1lE/FwtS+OXy3/IG/htHjIDohhXR3WIXuNULudzFRodVcq8eH TyMU4sEz7qnTkWEwxxqNnEhkVnf8lmL3Pgtmfp2I7Svao4zdKcF0U8qOv6+C5uW9 qtCexyXOiySiAXiRWlKRop0TPT4Cz5ZB4og/T37+zEUVZBvCNVvql0FxTH8gNAqa 8yInKI8fC930GNoPLbTniEV46mt7TUnKmAAThKzPzMaoYTZmQ8pz1dz/4PaONt+1 RXWVZbh8qcbFoa0F82fotov1EntZXTG7tPuxcANLsbfNeQfw+CwJcbNx5fSOvOHQ XBJ3bOKbg7f36u7hcSfytIYTf384e12xenFs5PvsUe2cBVEvEv59a7z+20qHYeKQ rlpvU0njVjPBfvpws81kYO0f9QN4MimkBrdsLyzVHPOdkuBYiZUH10Ya9mzYECxd iQ4ic0HkQew6SFC/telT1n7nAbmj/MplFL0KPFp16UIteMJGZ0N6t+3CWPzXwePd TJoy7wYokr8oovMTRTfXiaGuEdJs888COdytDrfB9ynRTJlCwYI= =y72y -----END PGP SIGNATURE----- --Sig_/k_HpX.HO5h0Vm859Zrx_IXJ--