all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* [bug#28619] [PATCH] doc: Fix rottlog configuration sample code.
@ 2017-09-27 15:36 Thomas Danckaert
  2017-09-28 20:10 ` Ludovic Courtès
  2017-09-30 17:26 ` bug#28619: " Thomas Danckaert
  0 siblings, 2 replies; 3+ messages in thread
From: Thomas Danckaert @ 2017-09-27 15:36 UTC (permalink / raw)
  To: 28619

[-- Attachment #1: Type: Text/Plain, Size: 319 bytes --]

I believe the current example code for a basic rottlog-service does 
not work. (mcron-service) requires an argument specifying the list of 
jobs.

I think either (service mcron-service-type) or (mcron-service '()) 
would be ok.  I use the former and attached patch updates the manual 
in this way.  Is that ok?

Thomas

[-- Attachment #2: 0001-doc-Fix-rottlog-configuration-sample-code.patch --]
[-- Type: Text/X-Patch, Size: 807 bytes --]

From 46b54b38ceea9c1e20e68be6e2d1127b41a14e72 Mon Sep 17 00:00:00 2001
From: Thomas Danckaert <thomas.danckaert@gmail.com>
Date: Wed, 27 Sep 2017 17:31:31 +0200
Subject: [PATCH] doc: Fix rottlog configuration sample code.

* doc/guix.texi (Log Rotation): Correct code for the default mcron-service.
---
 doc/guix.texi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/doc/guix.texi b/doc/guix.texi
index 1356a357c..9fd99fd53 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -9959,7 +9959,7 @@ with the default settings, for commonly encountered log files.
 
 (operating-system
   ;; @dots{}
-  (services (cons* (mcron-service)
+  (services (cons* (service mcron-service-type)
                    (service rottlog-service-type)
                    %base-services)))
 @end lisp
-- 
2.14.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [bug#28619] [PATCH] doc: Fix rottlog configuration sample code.
  2017-09-27 15:36 [bug#28619] [PATCH] doc: Fix rottlog configuration sample code Thomas Danckaert
@ 2017-09-28 20:10 ` Ludovic Courtès
  2017-09-30 17:26 ` bug#28619: " Thomas Danckaert
  1 sibling, 0 replies; 3+ messages in thread
From: Ludovic Courtès @ 2017-09-28 20:10 UTC (permalink / raw)
  To: Thomas Danckaert; +Cc: 28619

Thomas Danckaert <post@thomasdanckaert.be> skribis:

>>From 46b54b38ceea9c1e20e68be6e2d1127b41a14e72 Mon Sep 17 00:00:00 2001
> From: Thomas Danckaert <thomas.danckaert@gmail.com>
> Date: Wed, 27 Sep 2017 17:31:31 +0200
> Subject: [PATCH] doc: Fix rottlog configuration sample code.
>
> * doc/guix.texi (Log Rotation): Correct code for the default mcron-service.

Good catch!  LGTM.

Thanks,
Ludo'.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#28619: [PATCH] doc: Fix rottlog configuration sample code.
  2017-09-27 15:36 [bug#28619] [PATCH] doc: Fix rottlog configuration sample code Thomas Danckaert
  2017-09-28 20:10 ` Ludovic Courtès
@ 2017-09-30 17:26 ` Thomas Danckaert
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Danckaert @ 2017-09-30 17:26 UTC (permalink / raw)
  To: 28619-done



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-09-30 17:27 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-27 15:36 [bug#28619] [PATCH] doc: Fix rottlog configuration sample code Thomas Danckaert
2017-09-28 20:10 ` Ludovic Courtès
2017-09-30 17:26 ` bug#28619: " Thomas Danckaert

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.