From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50615) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dwA3d-0006L6-C9 for guix-patches@gnu.org; Sun, 24 Sep 2017 12:47:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dwA3a-0001hC-3F for guix-patches@gnu.org; Sun, 24 Sep 2017 12:47:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:47615) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dwA3Z-0001h0-UF for guix-patches@gnu.org; Sun, 24 Sep 2017 12:47:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dwA3Z-0005uw-NE for guix-patches@gnu.org; Sun, 24 Sep 2017 12:47:01 -0400 Subject: [bug#28579] gpa Resent-Message-ID: Date: Sun, 24 Sep 2017 16:45:56 +0000 From: ng0 Message-ID: <20170924164556.jkqzdlnoqqdvdqbu@abyayala> References: <20170924155452.lsq7mbnbuwa6clei@abyayala> <87fubc5ayl.fsf@nicolasgoaziou.fr> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="r6kgbm3xe2lo4l4b" Content-Disposition: inline In-Reply-To: <87fubc5ayl.fsf@nicolasgoaziou.fr> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Nicolas Goaziou Cc: 28579@debbugs.gnu.org --r6kgbm3xe2lo4l4b Content-Type: multipart/mixed; boundary="vccohswgekhkuv3u" Content-Disposition: inline --vccohswgekhkuv3u Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Nicolas Goaziou transcribed 1.6K bytes: > Hello, >=20 > ng0 writes: >=20 > > A GUI for GnuPG. > > > > Builds. > > GUI works, Preferences pick up my $HOME/.gnupg settings. > > More wasn't tested. >=20 > Thank you. I have some comments about your patch. >=20 > > +(define-public gpa > > + (package > > + (name "gpa") > > + (version "0.9.9") >=20 > version 0.9.10 is out since 2016. Would it make sense to package it inste= ad? I did only find 0.9.9, but I'll try again. I've catched a cold. > > + (source > > + (origin > > + (method url-fetch) > > + (uri (string-append "ftp://ftp.gnupg.org/gcrypt/gpa/" > > + name "-" version ".tar.bz2")) >=20 > Guix lint reports: >=20 > URL should be "mirror://gnupg/gpa/gpa-0.9.9.tar.bz2" Well I had a mirror first but did not find gpa on it. I'll try this. > > + (sha256 > > + (base32 > > + "0d235hcqai7m3qb7m9kvr2r4qg4714f87j9fdplwrlz1p4wdfa38")))) > > + (build-system gnu-build-system) > > + (native-inputs > > + `(("pkg-config" ,pkg-config))) > > + (inputs > > + `(("gnupg" ,gnupg) > > + ("gpgme" ,gpgme) > > + ("libassuan" ,libassuan) > > + ("libgpg-error" ,libgpg-error) > > + ("gtk+-2" ,gtk+-2))) > > + (home-page "https://gnupg.org/software/gpa/index.html") > > + (synopsis "GUI for GnuPG") > > + (description > > + "@defn{GNU Privacy Assistant} (GPA) is a graphical user > > +interface for the @defn{GNU Privacy Guard} (GnuPG).") >=20 > Guix lint reports an error about invalid Texinfo markup. Right! It's @dfn{} not @defn{}. > I'm not sure about what to do to fix it, if there is anything to do at > all. IMO, @defn is not adequate here. Why? It is a definition being used. Although I have to admit it looks unusual compared to the rest of the file. =E2=80=A6 synopsis: GUI for GnuPG description: "GNU Privacy Assistant" (GPA) is a graphical user interface fo= r the "GNU Privacy Guard" (GnuPG). > > + (license license:gpl3))) >=20 > Every ".c" file I checked use "or any later version". I think this > should be "gpl3+". WDYT? Okay. > Regards, >=20 > --=20 > Nicolas Goaziou 0x80A93738 >=20 Thanks for finding the mistakes. Correction appended. --=20 ng0 GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588 GnuPG: https://krosos.org/dist/keys/ https://www.infotropique.org https://www.krosos.org --vccohswgekhkuv3u Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0001-gnu-Add-gpa.patch" Content-Transfer-Encoding: quoted-printable =46rom 5d5749da28f4943a356970c142ce63dc3ec541a6 Mon Sep 17 00:00:00 2001 =46rom: ng0 Date: Sun, 24 Sep 2017 15:52:05 +0000 Subject: [PATCH] gnu: Add gpa. * gnu/packages/gnupg.scm (gpa): New variable. --- gnu/packages/gnupg.scm | 30 +++++++++++++++++++++++++++++- 1 file changed, 29 insertions(+), 1 deletion(-) diff --git a/gnu/packages/gnupg.scm b/gnu/packages/gnupg.scm index c6af5caa4..075eec4a2 100644 --- a/gnu/packages/gnupg.scm +++ b/gnu/packages/gnupg.scm @@ -7,7 +7,7 @@ ;;; Copyright =C2=A9 2015, 2016, 2017 Efraim Flashner ;;; Copyright =C2=A9 2015, 2016 Ricardo Wurmus ;;; Copyright =C2=A9 2016 Christopher Allan Webber -;;; Copyright =C2=A9 2016 ng0 +;;; Copyright =C2=A9 2016, 2017 ng0 ;;; Copyright =C2=A9 2016 Christopher Baines ;;; Copyright =C2=A9 2016 Mike Gerwitz ;;; Copyright =C2=A9 2016 Troy Sankey @@ -822,3 +822,31 @@ qualities. To reconstruct a secret key, you re-enter = those bytes (whether by hand, OCR, QR code, or the like) and paperkey can use them to transform your existing public key into a secret key.") (license license:gpl2+))) + +(define-public gpa + (package + (name "gpa") + (version "0.9.10") + (source + (origin + (method url-fetch) + (uri (string-append "mirror://gnupg/gpa/" + name "-" version ".tar.bz2")) + (sha256 + (base32 + "09xphbi2456qynwqq5n0yh0zdmdi2ggrj3wk4hsyh5lrzlvcrff3")))) + (build-system gnu-build-system) + (native-inputs + `(("pkg-config" ,pkg-config))) + (inputs + `(("gnupg" ,gnupg) + ("gpgme" ,gpgme) + ("libassuan" ,libassuan) + ("libgpg-error" ,libgpg-error) + ("gtk+-2" ,gtk+-2))) + (home-page "https://gnupg.org/software/gpa/index.html") + (synopsis "GUI for GnuPG") + (description + "@dfn{GNU Privacy Assistant} (GPA) is a graphical user +interface for the @dfn{GNU Privacy Guard} (GnuPG).") + (license license:gpl3+))) --=20 2.14.1 --vccohswgekhkuv3u-- --r6kgbm3xe2lo4l4b Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEqIyK3RKYKNfqwC5S4i+bv+40hYgFAlnH4UQACgkQ4i+bv+40 hYigXw/9FzlAcH0awGndDr/nrK4wtNWJC9zM3BlNVIcHQGOQHluXSQkXWEp7MPo6 IQbqisOyLgfJBuZHZTte9rXVBgzGiBJPROHwKszif1yAR3dmcOlqYBrJQmNczwFp rOzI20OXVLbYWKdnAqL92rbQqwum6QEDtGYDnF7nrg4twPCZc9oGr8YDGDxwA1kv KboAOBJQFyzc2TKM7V5BDqAI/Tlq96COe4K3cHX5MCWGM4n9WvlhC6Os3afQ8HHA VTKwispBzEo/lCq6ca4JoMZdf6vbG828RYz+7A23POUWGyKtL6Kin5YXzmrszWsh Z9bWU9UTHhtiEHy1gfLXBa3Nq7XKUzYhDP7+nmwAkZ2QFLER6Ni4M7Upe3GbHQDW KKwps9xNqqrk+W9ys/8Yb9dsUJ/fZZVB5fbJSjcYTSQrN5Sbq9Z3FFH2fV39ydc1 bl4vwwmUP9+2MUgaMvF3B/Q5cvoZXIGSGKueAJ2upwU7qq+ZWEMA2DYRN4xKqrk0 kpaUXgJhk9n6Gw2MeFPqmR+20yejIYe5rdBXhByIaQoGWH07JbPzFkRcIj5UgOGr s55cqVyljqTZ5nOrSZVW+ipo76+SNa4GSzU4mXHRGcr0Mp6Ch23KuDuEDOWYdJCw olSEemehLHM3HEvG3eraP6JqRMp8A+yQB9Ftb4faO7vk7KpMqLo= =GGJ5 -----END PGP SIGNATURE----- --r6kgbm3xe2lo4l4b--