all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: ng0 <ng0@infotropique.org>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: 28579@debbugs.gnu.org
Subject: [bug#28579] gpa
Date: Sun, 24 Sep 2017 16:45:56 +0000	[thread overview]
Message-ID: <20170924164556.jkqzdlnoqqdvdqbu@abyayala> (raw)
In-Reply-To: <87fubc5ayl.fsf@nicolasgoaziou.fr>


[-- Attachment #1.1: Type: text/plain, Size: 2496 bytes --]

Nicolas Goaziou transcribed 1.6K bytes:
> Hello,
> 
> ng0 <ng0@infotropique.org> writes:
> 
> > A GUI for GnuPG.
> >
> > Builds.
> > GUI works, Preferences pick up my $HOME/.gnupg settings.
> > More wasn't tested.
> 
> Thank you. I have some comments about your patch.
> 
> > +(define-public gpa
> > +  (package
> > +    (name "gpa")
> > +    (version "0.9.9")
> 
> version 0.9.10 is out since 2016. Would it make sense to package it instead?

I did only find 0.9.9, but I'll try again. I've catched a cold.

> > +    (source
> > +     (origin
> > +      (method url-fetch)
> > +      (uri (string-append "ftp://ftp.gnupg.org/gcrypt/gpa/"
> > +                          name "-" version ".tar.bz2"))
> 
> Guix lint reports:
> 
>   URL should be "mirror://gnupg/gpa/gpa-0.9.9.tar.bz2"

Well I had a mirror first but did not find gpa on it.
I'll try this.

> > +      (sha256
> > +       (base32
> > +        "0d235hcqai7m3qb7m9kvr2r4qg4714f87j9fdplwrlz1p4wdfa38"))))
> > +    (build-system gnu-build-system)
> > +    (native-inputs
> > +     `(("pkg-config" ,pkg-config)))
> > +    (inputs
> > +     `(("gnupg" ,gnupg)
> > +       ("gpgme" ,gpgme)
> > +       ("libassuan" ,libassuan)
> > +       ("libgpg-error" ,libgpg-error)
> > +       ("gtk+-2" ,gtk+-2)))
> > +    (home-page "https://gnupg.org/software/gpa/index.html")
> > +    (synopsis "GUI for GnuPG")
> > +    (description
> > +     "@defn{GNU Privacy Assistant} (GPA) is a graphical user
> > +interface for the @defn{GNU Privacy Guard} (GnuPG).")
> 
> Guix lint reports an error about invalid Texinfo markup.

Right! It's @dfn{} not @defn{}.

> I'm not sure about what to do to fix it, if there is anything to do at
> all. IMO, @defn is not adequate here.

Why? It is a definition being used.
Although I have to admit it looks unusual compared to the rest of the file.

…
synopsis: GUI for GnuPG
description: "GNU Privacy Assistant" (GPA) is a graphical user interface for the "GNU Privacy Guard" (GnuPG).

> > +    (license license:gpl3)))
> 
> Every ".c" file I checked use "or any later version". I think this
> should be "gpl3+". WDYT?

Okay.

> Regards,
> 
> -- 
> Nicolas Goaziou                                                0x80A93738
> 

Thanks for finding the mistakes. Correction appended.
-- 
ng0
GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
GnuPG: https://krosos.org/dist/keys/
https://www.infotropique.org https://www.krosos.org

[-- Attachment #1.2: 0001-gnu-Add-gpa.patch --]
[-- Type: text/plain, Size: 2163 bytes --]

From 5d5749da28f4943a356970c142ce63dc3ec541a6 Mon Sep 17 00:00:00 2001
From: ng0 <ng0@infotropique.org>
Date: Sun, 24 Sep 2017 15:52:05 +0000
Subject: [PATCH] gnu: Add gpa.

* gnu/packages/gnupg.scm (gpa): New variable.
---
 gnu/packages/gnupg.scm | 30 +++++++++++++++++++++++++++++-
 1 file changed, 29 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/gnupg.scm b/gnu/packages/gnupg.scm
index c6af5caa4..075eec4a2 100644
--- a/gnu/packages/gnupg.scm
+++ b/gnu/packages/gnupg.scm
@@ -7,7 +7,7 @@
 ;;; Copyright © 2015, 2016, 2017 Efraim Flashner <efraim@flashner.co.il>
 ;;; Copyright © 2015, 2016 Ricardo Wurmus <rekado@elephly.net>
 ;;; Copyright © 2016 Christopher Allan Webber <cwebber@dustycloud.org>
-;;; Copyright © 2016 ng0 <ng0@we.make.ritual.n0.is>
+;;; Copyright © 2016, 2017 ng0 <ng0@infotropique.org>
 ;;; Copyright © 2016 Christopher Baines <mail@cbaines.net>
 ;;; Copyright © 2016 Mike Gerwitz <mtg@gnu.org>
 ;;; Copyright © 2016 Troy Sankey <sankeytms@gmail.com>
@@ -822,3 +822,31 @@ qualities.  To reconstruct a secret key, you re-enter those
 bytes (whether by hand, OCR, QR code, or the like) and paperkey can use
 them to transform your existing public key into a secret key.")
     (license license:gpl2+)))
+
+(define-public gpa
+  (package
+    (name "gpa")
+    (version "0.9.10")
+    (source
+     (origin
+      (method url-fetch)
+      (uri (string-append "mirror://gnupg/gpa/"
+                          name "-" version ".tar.bz2"))
+      (sha256
+       (base32
+        "09xphbi2456qynwqq5n0yh0zdmdi2ggrj3wk4hsyh5lrzlvcrff3"))))
+    (build-system gnu-build-system)
+    (native-inputs
+     `(("pkg-config" ,pkg-config)))
+    (inputs
+     `(("gnupg" ,gnupg)
+       ("gpgme" ,gpgme)
+       ("libassuan" ,libassuan)
+       ("libgpg-error" ,libgpg-error)
+       ("gtk+-2" ,gtk+-2)))
+    (home-page "https://gnupg.org/software/gpa/index.html")
+    (synopsis "GUI for GnuPG")
+    (description
+     "@dfn{GNU Privacy Assistant} (GPA) is a graphical user
+interface for the @dfn{GNU Privacy Guard} (GnuPG).")
+    (license license:gpl3+)))
-- 
2.14.1


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2017-09-24 16:47 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-24 15:54 [bug#28579] gpa ng0
2017-09-24 16:16 ` Nicolas Goaziou
2017-09-24 16:45   ` ng0 [this message]
2017-09-24 21:05     ` Nicolas Goaziou
2017-09-24 21:42       ` ng0
2017-09-25 10:41         ` ng0
2017-09-25 10:44           ` ng0
2017-09-26  8:36             ` bug#28579: gpa Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170924164556.jkqzdlnoqqdvdqbu@abyayala \
    --to=ng0@infotropique.org \
    --cc=28579@debbugs.gnu.org \
    --cc=mail@nicolasgoaziou.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.