From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50088) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1drsFy-0007V6-3J for guix-patches@gnu.org; Tue, 12 Sep 2017 16:58:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1drsFu-0004qb-P9 for guix-patches@gnu.org; Tue, 12 Sep 2017 16:58:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:55965) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1drsFu-0004qX-Ly for guix-patches@gnu.org; Tue, 12 Sep 2017 16:58:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1drsFu-0002tb-A6 for guix-patches@gnu.org; Tue, 12 Sep 2017 16:58:02 -0400 Subject: [bug#28177] [PATCH 01/12] gnu: Add discount. Resent-Message-ID: Date: Tue, 12 Sep 2017 21:57:23 +0100 From: Christopher Baines Message-ID: <20170912215723.729b6015@cbaines.net> In-Reply-To: <87ingq7kma.fsf@gnu.org> References: <20170821190443.7056f624@cbaines.net> <20170821180832.23356-1-mail@cbaines.net> <87ingq7kma.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/=F_Zwv1R=H24Skteww0h/rD"; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 28177@debbugs.gnu.org --Sig_/=F_Zwv1R=H24Skteww0h/rD Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Sun, 10 Sep 2017 15:23:41 +0200 ludo@gnu.org (Ludovic Court=C3=A8s) wrote: > Christopher Baines skribis: >=20 > > This is required by perl-text-markdown-discount, which is required > > by ikiwiki. > > > > * gnu/packages/markdown.scm (discount) New variable. =20 >=20 > [...] >=20 > > + (add-before 'configure 'set_ac_default_path > > + (lambda args > > + (substitute* "configure.inc" > > + (("ac_default_path=3D\".*\"") > > + (string-append "ac_default_path=3D\"" (getenv > > "PATH") "\""))) > > + #t))))) =20 >=20 > Did you check the references of the resulting store item? It seems to > me that we might end up referring too much if this value is recorded > in the binary (GCC, Binutils, Make, etc.). >=20 > Perhaps we should instead set it to a very specific list, say > coreutils, grep, sed, or whatever is expected? The store item references look fine, I think this is just the path the configure.inc script searches. In looking at this again, I discovered that setting the AC_PATH environment variable has the same effect, so I've updated the patch to do that, as well as adding a comment to clarify that these are used at build time only. --Sig_/=F_Zwv1R=H24Skteww0h/rD Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAlm4SjNfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XexSw//ZCI1060swRJ9Li9RjUyzk/ntQHVHyKMZVdVBWjEk+3zkpd65DDYCCTGt xfdEu3gf9FS4x5qlGVKoYwIHFUKbtV5Ajv+vaIPxKxPwwmVYhOoCw0/a9TJ9vhQT VV8Ax3rqhT9/m+B4IxB3OEJorNDBWh2vrSWz+SBdXI6a3LyTgeYPSWWBUrrwEHqe KNKqBj+J4LLJhb462k0QFfR5H1rr7GkaZI3IGE/du3rij/GEdzPpNZritjQFpEzH FmmJc4ryQwYc0GVHLKfptIF9AS755MMXjs+VZ+f093q1hmFZDVIw0CT9dVrVZg+S TRpq9QVWVYe/oOLshQo6M6+F55Y4TqYMZHNU3OOqOs9uQksBdBkQSv8g5tSeb/16 f7eSJBGOfKX2KYe8lwLbckHsqo7TpxME8EhZWumMAd1ocSbfhgpAm6flG9Kxk/Jx edOhyqJWQby5L+4HNB+qHblUhICPuIfAsH6H9FUxX0J8ikprS2XEyQ2Ui8z6Jaa9 2YqIFVhP+F5cMaLVpXJVdKNopBii1YINqdv//RklltT7ugY/4pseeRRMi2Kwf3M7 sXO8FTZWH5GUAokwgKNAeh4v2kFnfGXoB3X9JliOO63l6wmyZr37bSs7Ni0tpuRj HJWtDp1Pw+zMCuTNzWLItfr1bSh+H70RIU18eSKYHwjxmSN8wZU= =8PVp -----END PGP SIGNATURE----- --Sig_/=F_Zwv1R=H24Skteww0h/rD--