[PATCH 00/11] Add python{,2}-twine.

[PATCH 00/11] Add python{,2}-twine.

[Cyril Roelandt]

This patch series adds Twine.

---
Cyril Roelandt (11):
  gnu: Add python-pydiff.
  gnu: python-autopep8: Update to 1.3.2.
  gnu: python-requests-toolbelt: Update to 0.8.0.
  gnu: Add python2-requests-toolbelt.
  gnu: python-tox: Update to 2.8.1.
  gnu: Add python-nose-timer.
  gnu: Add python-ipaddress.
  gnu: Update the propagated inputs of python-urllib3.
  gnu: Add python-tqdm.
  gnu: Add python-pkginfo.
  gnu: Add python-twine.

 gnu/packages/python.scm | 183 ++++++++++++++++++++++++++++++++++++++++++++----
 1 file changed, 169 insertions(+), 14 deletions(-)

-- 
2.14.1

[PATCH 01/11] gnu: Add python-pydiff.

[Cyril Roelandt]

* gnu/packages/python.scm (python-pydiff, python2-pydiff): New variables.
---
 gnu/packages/python.scm | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index d7156bf51..2efe8d2be 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -16282,3 +16282,25 @@ Templates.")
 
 (define-public python2-uritemplate
   (package-with-python2 python-uritemplate))
+
+(define-public python-pydiff
+  (package
+    (name "python-pydiff")
+    (version "0.2")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (pypi-uri "pydiff" version))
+        (sha256
+          (base32
+            "1als83h9w0gab24ipyna6khm390qmpnpkc5jksmdbs2xc8hp2z44"))))
+    (build-system python-build-system)
+    (home-page "https://github.com/myint/pydiff")
+    (synopsis "Library to diff two Python files at the bytecode level.")
+    (description
+      "@code{pydiff} makes it easy to look for actual code changes while
+ignoring formatting changes.")
+    (license license:expat)))
+
+(define-public python2-pydiff
+  (package-with-python2 python-pydiff))
-- 
2.14.1

[PATCH 02/11] gnu: python-autopep8: Update to 1.3.2.

[Cyril Roelandt]

* gnu/packages/python.scm (python-autopep8): Update to 1.3.2.
---
 gnu/packages/python.scm | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 2efe8d2be..673c3afd7 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -4877,17 +4877,17 @@ SQLAlchemy Database Toolkit for Python.")
 (define-public python-autopep8
   (package
   (name "python-autopep8")
-  (version "1.2.4")
+  (version "1.3.2")
   (source
    (origin
      (method url-fetch)
      (uri (pypi-uri "autopep8" version))
      (sha256
       (base32
-       "18parm383lfn42a00wklv3qf20p4v277f1x3cn58x019dqk1xqrq"))))
+       "1p9pa1ffg4iy96l918808jggg9a69iaka5awmj8xid36yc5mk0ky"))))
   (build-system python-build-system)
   (propagated-inputs
-    `(("python-pep8" ,python-pep8)))
+    `(("python-pycodestyle" ,python-pycodestyle)))
   (home-page "https://github.com/hhatto/autopep8")
   (synopsis "Format Python code according to the PEP 8 style guide")
   (description
-- 
2.14.1

[PATCH 03/11] gnu: python-requests-toolbelt: Update to 0.8.0.

[Cyril Roelandt]

* gnu/packages/python.scm (python-requests-toolbelt): Udpate to 0.8.0.
---
 gnu/packages/python.scm | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 673c3afd7..faa4750ee 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -9213,16 +9213,13 @@ for atomic file system operations.")
 (define-public python-requests-toolbelt
   (package
     (name "python-requests-toolbelt")
-    (version "0.6.2")
+    (version "0.8.0")
     (source (origin
              (method url-fetch)
-             (uri (string-append
-                    "https://pypi.python.org/packages/"
-                    "e1/a4/a94c037bc72ad70441aff1403d3243510d2542ddca7759faaeffeb11aefe/"
-                    "requests-toolbelt-" version ".tar.gz"))
+             (uri (pypi-uri "requests-toolbelt" version))
              (sha256
               (base32
-               "15q9nrgp85nqlr4kdz1zvj8z2npafi2sr12y7fqgxbkq28j1aci6"))))
+               "1dc7l42i4080r8i4m9fj51jx367lqkai170vrv7wd93gdj9k39gn"))))
     (build-system python-build-system)
     (native-inputs
      `(("python-betamax" ,python-betamax)
-- 
2.14.1

[PATCH 04/11] gnu: Add python2-requests-toolbelt.

[Cyril Roelandt]

* gnu/packages/python.scm (python2-requests-toolbelt): New variable.
---
 gnu/packages/python.scm | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index faa4750ee..677aab407 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -9233,6 +9233,9 @@ with python-requests.")
     (home-page "https://github.com/sigmavirus24/requests-toolbelt")
     (license license:asl2.0)))
 
+(define-public python2-requests-toolbelt
+  (package-with-python2 python-requests-toolbelt))
+
 (define-public python-click-threading
   (package
     (name "python-click-threading")
-- 
2.14.1

[PATCH 05/11] gnu: python-tox: Update to 2.8.1.

[Cyril Roelandt]

* gnu/packages/python.scm (python-tox): Update to 2.8.1.
---
 gnu/packages/python.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 677aab407..0487ae32b 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -9896,14 +9896,14 @@ Pytest but stripped of Pytest specific details.")
 (define-public python-tox
   (package
    (name "python-tox")
-   (version "2.8.0")
+   (version "2.8.1")
    (source
     (origin
      (method url-fetch)
      (uri (pypi-uri "tox" version))
      (sha256
       (base32
-       "00lrql2cfzhb712v70inac6mrgdv8s8fmvz7qpggkk623hkm2pgc"))))
+       "1drp6mwm8wdypjym15ia8lwjxbhcksb9vzxg4ay5dh4ji57by2ny"))))
    (build-system python-build-system)
    (arguments
     ;; FIXME: Tests require pytest-timeout, which itself requires
-- 
2.14.1

[PATCH 06/11] gnu: Add python-nose-timer.

[Cyril Roelandt]

* gnu/packages/python.scm (python-nose-time, python2-nose-timer): New variables.
---
 gnu/packages/python.scm | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 0487ae32b..e0b577afe 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -16304,3 +16304,31 @@ ignoring formatting changes.")
 
 (define-public python2-pydiff
   (package-with-python2 python-pydiff))
+
+(define-public python-nose-timer
+  (package
+    (name "python-nose-timer")
+    (version "0.7.0")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (pypi-uri "nose-timer" version))
+        (patches
+         (search-patches
+          ;; This patch will not be needed in the next version.
+          ;; It is taken from the master branch.
+          "python-nose-timer-drop-ordereddict.patch"))
+        (sha256
+          (base32
+            "1s32ymsnby8lz2qk55ifj9zi50dqcg6swnj5cz2rmwxg2jsslsxp"))))
+    (build-system python-build-system)
+    (propagated-inputs
+     `(("python-nose" ,python-nose)
+       ("python-termcolor" ,python-termcolor)))
+    (home-page "https://github.com/mahmoudimus/nose-timer")
+    (synopsis "Timer plugin for nosetests")
+    (description "Shows how much time was needed to run individual tests.")
+    (license license:expat)))
+
+(define-public python2-nose-timer
+  (package-with-python2 python-nose-timer))
-- 
2.14.1

[PATCH 07/11] gnu: Add python-ipaddress.

[Cyril Roelandt]

* gnu/packages/python.scm (python-ipaddress, python2-ipaddress): New variables.
---
 gnu/packages/python.scm | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index e0b577afe..e565d3683 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -16332,3 +16332,23 @@ ignoring formatting changes.")
 
 (define-public python2-nose-timer
   (package-with-python2 python-nose-timer))
+
+(define-public python-ipaddress
+  (package
+    (name "python-ipaddress")
+    (version "1.0.18")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (pypi-uri "ipaddress" version))
+        (sha256
+          (base32
+            "1q8klj9d84cmxgz66073x1j35cplr3r77vx1znhxiwl5w74391ax"))))
+    (build-system python-build-system)
+    (home-page "https://github.com/phihag/ipaddress")
+    (synopsis "IPv4/IPv6 manipulation library")
+    (description "Port of the 3.3+ ipaddress module to 2.6, 2.7, 3.2.")
+    (license license:psfl)))
+
+(define-public python2-ipaddress
+  (package-with-python2 python-ipaddress))
-- 
2.14.1

[PATCH 08/11] gnu: Update the propagated inputs of python-urllib3.

[Cyril Roelandt]

* gnu/packages/python.scm (python-urllib3, python2-urllib3): Update propagated
  inputs.
---
 gnu/packages/python.scm | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index e565d3683..9db16c5be 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -9810,10 +9810,11 @@ concurrent.futures package from Python 3.2")
        ("python-mock" ,python-mock)
        ("python-tornado" ,python-tornado)))
     (propagated-inputs
-     `(;; extra packages for https security
+     `(;; These 5 inputs are used to build urrlib3[secure]
        ("python-certifi" ,python-certifi)
-       ("python-ndg-httpsclient" ,python-ndg-httpsclient)
-       ("python-pyasn1" ,python-pyasn1)
+       ("python-cryptography" ,python-cryptography) ;
+       ("python-idna" ,python-idna)
+       ("python-ipaddress" ,python-ipaddress)
        ("python-pyopenssl" ,python-pyopenssl)))
     (home-page "https://urllib3.readthedocs.org/")
     (synopsis "HTTP library with thread-safe connection pooling")
-- 
2.14.1

[PATCH 09/11] gnu: Add python-tqdm.

[Cyril Roelandt]

* gnu/packages/python.scm (python-tqdm, python2-tqdm): New variables.
---
 gnu/packages/python.scm | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 9db16c5be..99ef1a06b 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -16353,3 +16353,29 @@ ignoring formatting changes.")
 
 (define-public python2-ipaddress
   (package-with-python2 python-ipaddress))
+
+(define-public python-tqdm
+  (package
+    (name "python-tqdm")
+    (version "4.15.0")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (pypi-uri "tqdm" version))
+         (sha256
+           (base32
+             "0lwrmby8qz23gvqwkpivfrv4q8nfh90cz9ml6slwvwmcxxsdrhbf"))))
+    (build-system python-build-system)
+    (native-inputs
+     `(("python-flake8" ,python-flake8)
+       ("python-nose" ,python-nose)
+       ("python-nose-timer" ,python-nose-timer)
+       ("python-coverage" ,python-coverage)
+       ("python-virtualenv" ,python-virtualenv)))
+    (home-page "https://github.com/tqdm/tqdm")
+    (synopsis "Fast, Extensible Progress Meter")
+    (description "Make for loops show a progress bar.")
+    (license license:asl2.0)))
+
+(define-public python2-tqdm
+  (package-with-python2 python-tqdm))
-- 
2.14.1

[PATCH 10/11] gnu: Add python-pkginfo.

[Cyril Roelandt]

* gnu/packages/python.scm (python-pkginfo, python2-pkginfo): New variables.
---
 gnu/packages/python.scm | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 99ef1a06b..979862775 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -16379,3 +16379,33 @@ ignoring formatting changes.")
 
 (define-public python2-tqdm
   (package-with-python2 python-tqdm))
+
+(define-public python-pkginfo
+  (package
+    (name "python-pkginfo")
+    (version "1.4.1")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (pypi-uri "pkginfo" version))
+        (sha256
+          (base32
+            "17pqjfpq3c6xzdmk8pski6jcjgjv78q00zjf2bgzb668pzm6l6mv"))))
+    (build-system python-build-system)
+    (arguments
+     ;; The tests are broken upstream.
+     '(#:tests? #f))
+    (home-page
+      "https://code.launchpad.net/~tseaver/pkginfo/trunk")
+    (synopsis
+      "Query metadatdata from sdists / bdists / installed packages.")
+    (description
+      "API to query the distutils metadata written in the PKG-INFO file inside a
+source distriubtion (an sdist) or a binary distribution (e.g., created by
+running bdist_egg).  It can also query the EGG-INFO directory of an installed
+distribution, and the *.egg-info stored in a “development checkout” (e.g,
+created by running setup.py develop).")
+    (license license:expat)))
+
+(define-public python2-pkginfo
+  (package-with-python2 python-pkginfo))
-- 
2.14.1

[PATCH 11/11] gnu: Add python-twine.

[Cyril Roelandt]

* gnu/packages/python.scm (python-twine, python2-twine): New variables.
---
 gnu/packages/python.scm | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 979862775..74d294b11 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -16409,3 +16409,31 @@ created by running setup.py develop).")
 
 (define-public python2-pkginfo
   (package-with-python2 python-pkginfo))
+
+(define-public python-twine
+  (package
+    (name "python-twine")
+    (version "1.9.1")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (pypi-uri "twine" version))
+        (sha256
+          (base32
+            "1ay1b6kdq6k4bfbjsvf6ymj41wrgpvinhxndb09355pwhxwmp96a"))))
+    (build-system python-build-system)
+    (propagated-inputs
+     `(("python-tqdm" ,python-tqdm)
+       ("python-pkginfo", python-pkginfo)
+       ("python-requests" ,python-requests)
+       ("python-requests-toolbelt" ,python-requests-toolbelt)))
+    (home-page "https://github.com/pypa/twine")
+    (synopsis "Collection of utilities for interacting with PyPI")
+    (description
+      "@code{twine} currently supports registering projects and uploading
+distributions.  It authenticates the user over HTTPS, allows them to pre-sign
+their files and supports any packaging format (including wheels).")
+    (license license:asl2.0)))
+
+(define-public python2-twine
+  (package-with-python2 python-twine))
-- 
2.14.1

Re: [PATCH 07/11] gnu: Add python-ipaddress.

[Hartmut Goebel]

Am 11.09.2017 um 20:22 schrieb Cyril Roelandt:
> +(define-public python-ipaddress
> +  (package
> +    (name "python-ipaddress")

This package already exists, only the Python2-variant is missing.

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel@crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |

Re: [PATCH 09/11] gnu: Add python-tqdm.

[Hartmut Goebel]

Am 11.09.2017 um 20:22 schrieb Cyril Roelandt:
> +    (synopsis "Fast, Extensible Progress Meter")
I suggest: "Fast and extensible progress bar for the console"
> +    (description "Make for loops show a progress bar.")
This is a bit terse (and it's not only "for" loops, AFAICT). Maybe
something like

Make loops show a progress bar on the console by just wrapping any
iterable with @code{|tqdm(iterable)|}. Offers many options to define
design and layout.

> +    (license license:asl2.0)))

The LICENCE file says: MPL and MIT. Please check again.

-- 

Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel@crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |

Re: [PATCH 10/11] gnu: Add python-pkginfo.

[Hartmut Goebel]

Am 11.09.2017 um 20:22 schrieb Cyril Roelandt:
> +    (description
> +      "API to query the distutils metadata written in the PKG-INFO file inside a
> +source distriubtion (an sdist) or a binary distribution (e.g., created by
> +running bdist_egg).  It can also query the EGG-INFO directory of an installed
> +distribution, and the *.egg-info stored in a “development checkout” (e.g,
> +created by running setup.py develop).")

Syntax error: Quotes inside quotes need to be escaped.

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel@crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |

Re: [PATCH 07/11] gnu: Add python-ipaddress.

[Cyril Roelandt]

On 09/12/2017 09:31 AM, Hartmut Goebel wrote:
> This package already exists, only the Python2-variant is missing.
Oh apparently the Py2 version is there as well. I deleted this patch.
Thanks for the review!

Cyril.

[PATCH 08/10] gnu: Add python-tqdm.

[Cyril Roelandt]

* gnu/packages/python.scm (python-tqdm, python2-tqdm): New variables.
---
 gnu/packages/python.scm | 29 +++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 7f48b8dae..cfe97b495 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -16333,3 +16333,32 @@ ignoring formatting changes.")
 
 (define-public python2-nose-timer
   (package-with-python2 python-nose-timer))
+
+(define-public python-tqdm
+  (package
+    (name "python-tqdm")
+    (version "4.15.0")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (pypi-uri "tqdm" version))
+         (sha256
+           (base32
+             "0lwrmby8qz23gvqwkpivfrv4q8nfh90cz9ml6slwvwmcxxsdrhbf"))))
+    (build-system python-build-system)
+    (native-inputs
+     `(("python-flake8" ,python-flake8)
+       ("python-nose" ,python-nose)
+       ("python-nose-timer" ,python-nose-timer)
+       ("python-coverage" ,python-coverage)
+       ("python-virtualenv" ,python-virtualenv)))
+    (home-page "https://github.com/tqdm/tqdm")
+    (synopsis "Fast, Extensible Progress Meter")
+    (description
+      "Make loops show a progress bar on the console by just wrapping any
+iterable with @code{|tqdm(iterable)|}.  Offers many options to define
+design and layout.")
+    (license (list license:mpl2.0 license:expat))))
+
+(define-public python2-tqdm
+  (package-with-python2 python-tqdm))
-- 
2.14.1

[PATCH 09/10] gnu: Add python-pkginfo.

[Cyril Roelandt]

* gnu/packages/python.scm (python-pkginfo, python2-pkginfo): New variables.
---
 gnu/packages/python.scm | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index cfe97b495..0da26b9d9 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -16362,3 +16362,33 @@ design and layout.")
 
 (define-public python2-tqdm
   (package-with-python2 python-tqdm))
+
+(define-public python-pkginfo
+  (package
+    (name "python-pkginfo")
+    (version "1.4.1")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (pypi-uri "pkginfo" version))
+        (sha256
+          (base32
+            "17pqjfpq3c6xzdmk8pski6jcjgjv78q00zjf2bgzb668pzm6l6mv"))))
+    (build-system python-build-system)
+    (arguments
+     ;; The tests are broken upstream.
+     '(#:tests? #f))
+    (home-page
+      "https://code.launchpad.net/~tseaver/pkginfo/trunk")
+    (synopsis
+      "Query metadatdata from sdists / bdists / installed packages.")
+    (description
+      "API to query the distutils metadata written in the PKG-INFO file inside a
+source distriubtion (an sdist) or a binary distribution (e.g., created by
+running bdist_egg).  It can also query the EGG-INFO directory of an installed
+distribution, and the *.egg-info stored in a \"development checkout\" (e.g,
+created by running setup.py develop).")
+    (license license:expat)))
+
+(define-public python2-pkginfo
+  (package-with-python2 python-pkginfo))
-- 
2.14.1

Re: [PATCH 01/11] gnu: Add python-pydiff.

[Ludovic Courtès]

Hello!

Cyril Roelandt <tipecaml@gmail.com> skribis:

> * gnu/packages/python.scm (python-pydiff, python2-pydiff): New variables.
> ---
>  gnu/packages/python.scm | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
>
> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index d7156bf51..2efe8d2be 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -16282,3 +16282,25 @@ Templates.")
>  
>  (define-public python2-uritemplate
>    (package-with-python2 python-uritemplate))
> +
> +(define-public python-pydiff
> +  (package
> +    (name "python-pydiff")
> +    (version "0.2")
> +    (source
> +      (origin
> +        (method url-fetch)
> +        (uri (pypi-uri "pydiff" version))
> +        (sha256
> +          (base32
> +            "1als83h9w0gab24ipyna6khm390qmpnpkc5jksmdbs2xc8hp2z44"))))
> +    (build-system python-build-system)
> +    (home-page "https://github.com/myint/pydiff")
> +    (synopsis "Library to diff two Python files at the bytecode level.")
                                                                        ^
Please placate ‘guix lint’.  :-)

Otherwise LGTM.

Ludo’.

Re: [PATCH 02/11] gnu: python-autopep8: Update to 1.3.2.

[Ludovic Courtès]

Cyril Roelandt <tipecaml@gmail.com> skribis:

> * gnu/packages/python.scm (python-autopep8): Update to 1.3.2.

OK!

Re: [PATCH 03/11] gnu: python-requests-toolbelt: Update to 0.8.0.

[Ludovic Courtès]

Cyril Roelandt <tipecaml@gmail.com> skribis:

> * gnu/packages/python.scm (python-requests-toolbelt): Udpate to 0.8.0.

OK!

Re: [PATCH 04/11] gnu: Add python2-requests-toolbelt.

[Ludovic Courtès]

Cyril Roelandt <tipecaml@gmail.com> skribis:

> * gnu/packages/python.scm (python2-requests-toolbelt): New variable.

OK!

Re: [PATCH 05/11] gnu: python-tox: Update to 2.8.1.

[Ludovic Courtès]

Cyril Roelandt <tipecaml@gmail.com> skribis:

> * gnu/packages/python.scm (python-tox): Update to 2.8.1.

OK!

Re: [PATCH 06/11] gnu: Add python-nose-timer.

[Ludovic Courtès]

Cyril Roelandt <tipecaml@gmail.com> skribis:

> * gnu/packages/python.scm (python-nose-time, python2-nose-timer): New variables.

LGTM!

Re: [PATCH 08/11] gnu: Update the propagated inputs of python-urllib3.

[Ludovic Courtès]

Cyril Roelandt <tipecaml@gmail.com> skribis:

> * gnu/packages/python.scm (python-urllib3, python2-urllib3): Update propagated
>   inputs.

OK!

Re: [PATCH 09/11] gnu: Add python-tqdm.

[Ludovic Courtès]

Cyril Roelandt <tipecaml@gmail.com> skribis:

> * gnu/packages/python.scm (python-tqdm, python2-tqdm): New variables.

[...]

> +    (home-page "https://github.com/tqdm/tqdm")
> +    (synopsis "Fast, Extensible Progress Meter")

No need to capitalize.  :-)

Otherwise LGTM.

Re: [PATCH 10/11] gnu: Add python-pkginfo.

[Ludovic Courtès]

Cyril Roelandt <tipecaml@gmail.com> skribis:

> * gnu/packages/python.scm (python-pkginfo, python2-pkginfo): New variables.

[...]

> +    (arguments
> +     ;; The tests are broken upstream.
> +     '(#:tests? #f))

If there’s a URL explaining this, please add it.

> +    (synopsis
> +      "Query metadatdata from sdists / bdists / installed packages.")

Rather:  “Query metadata from sdists, bdists, and installed packages”

> +    (description
> +      "API to query the distutils metadata written in the PKG-INFO file inside a
> +source distriubtion (an sdist) or a binary distribution (e.g., created by
> +running bdist_egg).  It can also query the EGG-INFO directory of an installed
> +distribution, and the *.egg-info stored in a “development checkout” (e.g,
> +created by running setup.py develop).")

Please use @code, @file, etc. as appropriate.

Otherwise LGTM!

Re: [PATCH 11/11] gnu: Add python-twine.

[Ludovic Courtès]

Cyril Roelandt <tipecaml@gmail.com> skribis:

> * gnu/packages/python.scm (python-twine, python2-twine): New variables.

OK!

BTW, in the future, please consider emailing guix-patches@gnu.org:

  https://www.gnu.org/software/guix/manual/html_node/Submitting-Patches.html

Thank you!

Ludo’.

Re: [PATCH 11/11] gnu: Add python-twine.

[Cyril Roelandt]

On 09/18/2017 10:35 PM, Ludovic Courtès wrote:
> 
> BTW, in the future, please consider emailing guix-patches@gnu.org:

OK.

I pushed this patch series on master after applying the requested
changes. Thanks for the reviews!

Cyril.