From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46743) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dpUPW-0005HN-1U for guix-patches@gnu.org; Wed, 06 Sep 2017 03:06:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dpUPS-0000Kv-Nl for guix-patches@gnu.org; Wed, 06 Sep 2017 03:06:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:43512) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dpUPS-0000Kr-K9 for guix-patches@gnu.org; Wed, 06 Sep 2017 03:06:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dpUPS-00037y-6m for guix-patches@gnu.org; Wed, 06 Sep 2017 03:06:02 -0400 Subject: [bug#28288] [PATCH 1/5] vm: Add support for registering closures to make-iso9660-image. Resent-Message-ID: Date: Wed, 6 Sep 2017 08:05:32 +0100 From: Christopher Baines Message-ID: <20170906080515.4764be7b@cbaines.net> In-Reply-To: <877exds2s3.fsf@gnu.org> References: <20170830071714.75f88e47@cbaines.net> <20170903105041.2925-1-mail@cbaines.net> <877exds2s3.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/CKeCvlMRM//bV31ZLQ2B3G0"; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 28288@debbugs.gnu.org --Sig_/CKeCvlMRM//bV31ZLQ2B3G0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Tue, 05 Sep 2017 15:17:32 +0200 ludo@gnu.org (Ludovic Court=C3=A8s) wrote: > Hi! >=20 > Christopher Baines skribis: >=20 > > This mimics the functionality in the root-partition-initializer > > used in creating the QEMU image. This helps when trying to run guix > > system init from the generated ISO image. > > > > * gnu/build/vm.scm (make-iso9660-image): Add support for > > registering closures. =20 >=20 > [...] >=20 > > + (when register-closures? > > + (display "registering closures...\n") > > + (for-each (lambda (closure) > > + (register-closure > > + "/tmp/root" > > + (string-append "/xchg/" closure) > > + #:deduplicate? #f)) > > + closures)) =20 >=20 > Was there any specific reason for #:deduplicate? #f here? Yep, the image creation process fails if this is not specified. error: cannot link `/tmp/root/gnu/store/.links/1wj8bqv0ygz606a0day0gk7w37prsnbg5z2im2yf025r0y6= lqfs0' to `/tmp/root/gnu/store/00lgsgxvv1hfhl22yqmzsa3lrs5qa9my-firmware/lib/firmware= /b43-open': Invalid cross-device link There is probably another way around this though. I'm not sure what impact skipping the deduplication has on the size of the image. > Otherwise LGTM! >=20 > Ludo=E2=80=99. --Sig_/CKeCvlMRM//bV31ZLQ2B3G0 Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAlmvnjxfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XfJ/w/+KF+vED7ESj9+SI91bVgaGeUoTa1iMI9IZypuknPkjntJPiobGCAx5P2y Iq7b/y+svPgQEPNdXI7yOacbKrz8UyY7prnXgAuQeE73u+bPiKef999fCRVRVkUv qWeNXMNCL9FlqHz4ASQxlsAKqVW974w2e2fgO6qYyeR6gVoV1+Cqe0rJS4EG0dK9 YgTKu+3WXepGhsAOU2LEqCYo3+PTCROjjx6Xb2Y25G2I7WZOIquyUjR++78X7+h6 BBmRY3kZ1IUA4NQ48IssbIpf9voB7rD6j/XYppDncKqSSoic3CwueczsyakF5LaT xODRlTJiI8U3JUtrdhDlWuivfl0HQu9cXjzTqPxpspgoL01O0K0Ma3gm7a/fmCg+ rfs+iGJj8kgvyCaMIxe/UzRvFTHdpcUA1kbD4nIL6d4DaPWcR30g719Fb+2Yeidy am3Wg1xC30cWqztNfLnklVeRY8oLFDGq8oORFiObpjB4bm8p3IEF7FHtFWjuj5kc Y3N4WkfXQS6OHZyq4XDDv17qPMq2npsc9cS7/1YiBLjUOA+vmkqwBxYv5yJPjxIp /wY5ZyDlHB3S1tpWdG4/sUAzaSd3DNV5KjyI7Oq8ZWqGfbUufg860JTaq3o6T1/W XxSHsQ6kr+yZsPXW08pmE0fQebcgTIJ7U/yC9uBhWJv9klKNGRE= =AC6Y -----END PGP SIGNATURE----- --Sig_/CKeCvlMRM//bV31ZLQ2B3G0--