From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53813) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1doavD-0002Fl-3S for guix-patches@gnu.org; Sun, 03 Sep 2017 15:51:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1doav8-0008Mx-CY for guix-patches@gnu.org; Sun, 03 Sep 2017 15:51:07 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:38194) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1doav8-0008Mm-8y for guix-patches@gnu.org; Sun, 03 Sep 2017 15:51:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1doav7-0005mP-Tm for guix-patches@gnu.org; Sun, 03 Sep 2017 15:51:01 -0400 Subject: [bug#28116] mate partial review Resent-Message-ID: Date: Sun, 3 Sep 2017 19:50:49 +0000 From: ng0 Message-ID: <20170903195049.dbm5je33dpwjhfoy@abyayala> References: <20170816205650.7pfzuyul3wcdltbx@abyayala> <20170824204246.GL2484@macbook42.flashner.co.il> <20170825181125.dfsc4wiav4lkocb2@abyayala> <20170828113220.GA1618@macbook42.flashner.co.il> <20170831125444.faps346nfm2xdhwg@abyayala> <20170831132109.3m3ep73jolm5nzqb@abyayala> <20170903150918.GA2239@macbook42.flashner.co.il> <20170903194441.pkinlretz2odv44f@abyayala> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="zoryxkjmmnqoy5dh" Content-Disposition: inline In-Reply-To: <20170903194441.pkinlretz2odv44f@abyayala> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Efraim Flashner Cc: 28116@debbugs.gnu.org --zoryxkjmmnqoy5dh Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable ng0 transcribed 38K bytes: > Efraim Flashner transcribed 27K bytes: > > On Thu, Aug 31, 2017 at 01:21:09PM +0000, ng0 wrote: > > > ng0 transcribed 47K bytes: > > > > I did the best I could guess with this updated patch series. > > > > If I missed something you addressed already, please point it > > > > out in a format which is more friendly to read than a mono-patch. > > > >=20 > > > > If this series is alright I want to sort the inputs of the > > > > longest packages with the version which is then good to go. > > > >=20 > > > > Thanks for taking the time to review! > > >=20 > > > You could also read through them here: > > > https://gitweb.krosos.org/ng0_guix/guix/log/?h=3Dsystem/mate > > > http://gitweb.xpcbqhqx6ynktue7.onion/ng0_guix/guix/log/?h=3Dsystem/ma= te > > > --=20 > >=20 > > That worked out well. I think we're about there, I just want you to > > check that it works well when used as a DE. >=20 > I applied all of your corrections with the exception of: >=20 > `(#:phases -> '(#:phases >=20 > I see no point or any reason at all to use this for the package definition > it was applied to, used 2 times. The majority of packages uses the first = one. >=20 > Then there was a cosmetical change with something like > (add-before > 'foo 'bar >=20 > becoming >=20 > (add-before 'foo 'bar >=20 > I haven't applied this because it was outside of the packages I > worked on and didn't fit into any logical set of patches I had. >=20 > This can be commited after this series. >=20 > Thanks for going through all of this. Now what we achieved with this > change is: > - mate-panel has actual readable/recognizable symbols instead > of the garbage I assumed that was caused by individual applications > but turns out it wasn't. > - Mate Control Center looks better. > - Everything is still working. >=20 >=20 > So, your fixes to my patches LGTM. > Rebased and edited series attached. Actually one issue, but not related to MATE: Please check if on a system with only Mate and not additionally XFCE or GNOME you have harddrives accessible. I removed both (XFCE and GNOME) from the system and as a normal user my unmounted disks disappeared from the system view. Not bad, but this has happened with other WMs/DMs before so I just assume something is missing. Still good to go though. --=20 ng0 GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588 GnuPG: https://n0is.noblogs.org/my-keys https://www.infotropique.org https://krosos.org --zoryxkjmmnqoy5dh Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEqIyK3RKYKNfqwC5S4i+bv+40hYgFAlmsXRkACgkQ4i+bv+40 hYiiLQ//egQ063aNbdrDycqEbHhDIBXrG3B1qXdyA5n9gcOP3T6d1EDnLelD4Geh HT1yxgFpc8a+zI6Cc866dpitdOAMWzlEntWXjSszPCrm1sr1cm8XRCSgJu0n8YcL Z/dRpstXgXJdVXrhSZwq5pfBgrkIEDZaUzDhWoAjvkZUfhp81Aw3Nyh7bt5ma4dA dwttBbJOwSAkk9orvgxwuRHXlmY2U3ChLRxzEs71w/I9LFU79y6RwoFFvXs2nXY4 7BfsJ6JLOO2h29C0vlEb75O7qrCNKpZdVhqVG0WvEGdfkDhw3gH3d6TcZK+/mo3I RWdnuk5u7nYVUZJdPt8CZGSrcJTkt16tS7sMPWGKFCFeHGzoIQtIxecPq5Ws7TfA SchAEqwItEC5se1Z7XNu063uJ1eqjkzCEyqXz5FqjiUQNQ8exa21lcXyYlEdYrl7 YwNK1Bb1ogV0Mvlv72ZnbSMXtUOf5aImmuQ0vVAS/Scw4FQd3kQzx4rS4Lah/qPf pncY7sGnosgZdoWqawqxBNjUCFMjdJuEQJdx+g5m2j5j1yQjZhrz/V06zD94KXzp QssHiajb+8y4md8lKbIuOn+RVHPqijw/ajPLmG3PtOUogBDNnj7eD4rBKIIo7Pjk LO1Aa1LXuzKHBMGVIgigQxxsck5/iZ9LOD28Oc03jjGjZZoDlcQ= =dvj4 -----END PGP SIGNATURE----- --zoryxkjmmnqoy5dh--