all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: ng0 <ng0@infotropique.org>
To: Efraim Flashner <efraim@flashner.co.il>
Cc: 28116@debbugs.gnu.org
Subject: [bug#28116] mate partial review
Date: Sun, 3 Sep 2017 19:50:49 +0000	[thread overview]
Message-ID: <20170903195049.dbm5je33dpwjhfoy@abyayala> (raw)
In-Reply-To: <20170903194441.pkinlretz2odv44f@abyayala>

[-- Attachment #1: Type: text/plain, Size: 2474 bytes --]

ng0 transcribed 38K bytes:
> Efraim Flashner transcribed 27K bytes:
> > On Thu, Aug 31, 2017 at 01:21:09PM +0000, ng0 wrote:
> > > ng0 transcribed 47K bytes:
> > > > I did the best I could guess with this updated patch series.
> > > > If I missed something you addressed already, please point it
> > > > out in a format which is more friendly to read than a mono-patch.
> > > > 
> > > > If this series is alright I want to sort the inputs of the
> > > > longest packages with the version which is then good to go.
> > > > 
> > > > Thanks for taking the time to review!
> > > 
> > > You could also read through them here:
> > > https://gitweb.krosos.org/ng0_guix/guix/log/?h=system/mate
> > > http://gitweb.xpcbqhqx6ynktue7.onion/ng0_guix/guix/log/?h=system/mate
> > > -- 
> > 
> > That worked out well. I think we're about there, I just want you to
> > check that it works well when used as a DE.
> 
> I applied all of your corrections with the exception of:
> 
> `(#:phases -> '(#:phases
> 
> I see no point or any reason at all to use this for the package definition
> it was applied to, used 2 times. The majority of packages uses the first one.
> 
> Then there was a cosmetical change with something like
> (add-before
>  'foo 'bar
> 
> becoming
> 
> (add-before 'foo 'bar
> 
> I haven't applied this because it was outside of the packages I
> worked on and didn't fit into any logical set of patches I had.
> 
> This can be commited after this series.
> 
> Thanks for going through all of this. Now what we achieved with this
> change is:
> - mate-panel has actual readable/recognizable symbols instead
>   of the garbage I assumed that was caused by individual applications
>   but turns out it wasn't.
> - Mate Control Center looks better.
> - Everything is still working.
> 
> 
> So, your fixes to my patches LGTM.
> Rebased and edited series attached.

Actually one issue, but not related to MATE:
Please check if on a system with only Mate
and not additionally XFCE or GNOME you have
harddrives accessible. I removed both (XFCE
and GNOME) from the system and as a normal
user my unmounted disks disappeared from
the system view. Not bad, but this has
happened with other WMs/DMs before so I
just assume something is missing.

Still good to go though.
-- 
ng0
GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
GnuPG: https://n0is.noblogs.org/my-keys
https://www.infotropique.org https://krosos.org

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

      reply	other threads:[~2017-09-03 19:51 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-16 20:56 [bug#28116] MATE (and mate-terminal + caja) ng0
2017-08-23 21:04 ` ng0
2017-08-24 20:42 ` [bug#28116] mate partial review Efraim Flashner
2017-08-25 18:11   ` ng0
2017-08-28 11:32     ` Efraim Flashner
2017-08-31 12:54       ` ng0
2017-08-31 13:21         ` ng0
2017-09-03 15:09           ` Efraim Flashner
2017-09-03 19:44             ` ng0
2017-09-03 19:50               ` ng0 [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170903195049.dbm5je33dpwjhfoy@abyayala \
    --to=ng0@infotropique.org \
    --cc=28116@debbugs.gnu.org \
    --cc=efraim@flashner.co.il \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.