From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59120)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dmZPZ-0007yh-94
	for guix-patches@gnu.org; Tue, 29 Aug 2017 01:50:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dmZPW-0005n9-4U
	for guix-patches@gnu.org; Tue, 29 Aug 2017 01:50:05 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:51271)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1dmZPW-0005n5-1k
	for guix-patches@gnu.org; Tue, 29 Aug 2017 01:50:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dmZPV-0001Jo-R0
	for guix-patches@gnu.org; Tue, 29 Aug 2017 01:50:01 -0400
Subject: [bug#28145] [PATCH] build: Do not store two copies of the ISO-9660
	superblock anymore.
Resent-Message-ID: <handler.28145.B28145.15039857525010@debbugs.gnu.org>
Date: Tue, 29 Aug 2017 07:49:02 +0200
From: Danny Milosavljevic <dannym@scratchpost.org>
Message-ID: <20170829074902.1688b3c5@scratchpost.org>
In-Reply-To: <877exv699r.fsf@gnu.org>
References: <20170819024656.17036-1-dannym@scratchpost.org>
	<877exv699r.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: 28145@debbugs.gnu.org

Hi Ludo,

On Tue, 22 Aug 2017 15:07:28 +0200
ludo@gnu.org (Ludovic Court=C3=A8s) wrote:
> Danny Milosavljevic <dannym@scratchpost.org> skribis:
>=20
> > * gnu/build/vm.scm (make-iso9660-image): Do not store two copies of the
> > ISO-9660 superblock anymore. =20
>=20
> Why is it no longer needed?  Otherwise fine with me.  :-)

Because we went ahead and now we just read it from the whole disk on boot (=
previously, it only accepted superblocks on partitions, remember?).

Previously on master:

- DVD
  + ISO9660 superblock
  + partition table
    + partition
      + ISO9660 superblock copy <--- GuixSD sees this

Now on master:

- DVD
  + ISO9660 superblock <--- GuixSD sees this
  + partition table
    + partition
      + ISO9660 superblock copy <--- what's this for now?

With the patch:

- DVD
  + ISO9660 superblock <--- GuixSD sees this
  + partition table
    + partition