[bug#28272] [PATCH] Improve and upgrade signing-party.

[bug#28272] [PATCH] Improve and upgrade signing-party.

[Christopher Baines]

[-- Attachment #1: Type: text/plain, Size: 796 bytes --]

Add several missing dependencies, particularly for the caff tool. It
now runs, but I've been unable to get it working fully yet, possibly
due to problems with the actual sending of the emails.

Christopher Baines (12):
  gnu: Add perl-moox.
  gnu: Add perl-data-perl.
  gnu: Add perl-moox-handlesvia.
  gnu: Add perl-moox-late.
  gnu: Add perl-convert-binhex.
  gnu: Add perl-mailtools.
  gnu: Add perl-mime-tools.
  gnu: Add perl-net-idn-encode.
  gnu: Add perl-text-template.
  gnu: Add perl-gnupg-interface.
  gnu: Add libmd.
  gnu: Update signing-party.

 gnu/packages/crypto.scm |  31 +++++
 gnu/packages/gnupg.scm  |  79 +++++++++++--
 gnu/packages/perl.scm   | 307 ++++++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 406 insertions(+), 11 deletions(-)

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 963 bytes --]

[bug#28272] [PATCH 01/12] gnu: Add perl-moox.

[Christopher Baines]

* gnu/packages/perl.scm (perl-moox): New variable.
---
 gnu/packages/perl.scm | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
index 93fc4059d..657db1486 100644
--- a/gnu/packages/perl.scm
+++ b/gnu/packages/perl.scm
@@ -5073,6 +5073,32 @@ all coercions and constraints are inherited.")
 constraint with coercion to load the class.")
     (license (package-license perl))))
 
+(define-public perl-moox
+  (package
+    (name "perl-moox")
+    (version "0.101")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "mirror://cpan/authors/id/G/GE/GETTY/MooX-"
+             version
+             ".tar.gz"))
+       (sha256
+        (base32
+         "1m9jvrqcidiabdih211byadwnnkygafq54r2ljnf1akqdrjimy9g"))))
+    (build-system perl-build-system)
+    (inputs
+     `(("perl-data-optlist" ,perl-data-optlist)
+       ("perl-import-into" ,perl-import-into)
+       ("perl-module-runtime" ,perl-module-runtime)
+       ("perl-moo" ,perl-moo)))
+    (home-page "http://search.cpan.org/dist/MooX")
+    (synopsis
+     "Using Moo and MooX:: packages the most lazy way")
+    (description "Contains the MooX and MooX::Role packages.")
+    (license (package-license perl))))
+
 (define-public perl-moox-types-mooselike
   (package
     (name "perl-moox-types-mooselike")
-- 
2.14.1

[bug#28272] [PATCH 02/12] gnu: Add perl-data-perl.

[Christopher Baines]

* gnu/packages/perl.scm (perl-data-perl): New variable.
---
 gnu/packages/perl.scm | 43 +++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 43 insertions(+)

diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
index 657db1486..d76e0e35d 100644
--- a/gnu/packages/perl.scm
+++ b/gnu/packages/perl.scm
@@ -1588,6 +1588,49 @@ on one page.  This results in wanting to page through various pages of data.
 The maths behind this is unfortunately fiddly, hence this module.")
     (license (package-license perl))))
 
+(define-public perl-data-perl
+  (package
+    (name "perl-data-perl")
+    (version "0.002009")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "mirror://cpan/authors/id/M/MA/MATTP/Data-Perl-"
+             version
+             ".tar.gz"))
+       (sha256
+        (base32
+         "12vgqdjbfqf2qfg21x22wg88xnwxfbw2ki3qzcb3nb0chwjj4axn"))))
+    (build-system perl-build-system)
+    (native-inputs
+     `(("perl-test-deep" ,perl-test-deep)
+       ("perl-test-fatal" ,perl-test-fatal)
+       ("perl-test-output" ,perl-test-output)))
+    (inputs
+     `(("perl-class-method-modifiers"
+        ,perl-class-method-modifiers)
+       ("perl-module-runtime" ,perl-module-runtime)
+       ("perl-role-tiny" ,perl-role-tiny)
+       ("perl-strictures" ,perl-strictures)))
+    (propagated-inputs
+     `(("perl-list-moreutils" ,perl-list-moreutils)))
+    (home-page
+     "http://search.cpan.org/dist/Data-Perl")
+    (synopsis "Base classes wrapping fundamental Perl data types")
+    (description
+     "@code{Data::Perl} is a container class for the following classes:
+@itemize
+@item @code{Data::Perl::Collection::Hash}
+@item @code{Data::Perl::Collection::Array}
+@item @code{Data::Perl::String}
+@item @code{Data::Perl::Number}
+@item @code{Data::Perl::Counter}
+@item @code{Data::Perl::Bool}
+@item @code{Data::Perl::Code}
+@end itemize")
+    (license (package-license perl))))
+
 (define-public perl-data-stag
   (package
     (name "perl-data-stag")
-- 
2.14.1

[bug#28272] [PATCH 03/12] gnu: Add perl-moox-handlesvia.

[Christopher Baines]

* gnu/packages/perl.scm (perl-moox-handlesvia): New variable.
---
 gnu/packages/perl.scm | 37 +++++++++++++++++++++++++++++++++++++
 1 file changed, 37 insertions(+)

diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
index d76e0e35d..1e489d021 100644
--- a/gnu/packages/perl.scm
+++ b/gnu/packages/perl.scm
@@ -5142,6 +5142,43 @@ constraint with coercion to load the class.")
     (description "Contains the MooX and MooX::Role packages.")
     (license (package-license perl))))
 
+(define-public perl-moox-handlesvia
+  (package
+    (name "perl-moox-handlesvia")
+    (version "0.001008")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "mirror://cpan/authors/id/M/MA/MATTP/MooX-HandlesVia-"
+             version
+             ".tar.gz"))
+       (sha256
+        (base32
+         "137yrjn2jmw4cj0fjdajnkjgqr5arnpq72kbm6w66xskncinz55h"))))
+    (build-system perl-build-system)
+    (native-inputs
+     `(("perl-moox-types-mooselike"
+        ,perl-moox-types-mooselike)
+       ("perl-test-exception" ,perl-test-exception)
+       ("perl-test-fatal" ,perl-test-fatal)))
+    (inputs
+     `(("perl-class-method-modifiers"
+        ,perl-class-method-modifiers)
+       ("perl-module-runtime" ,perl-module-runtime)
+       ("perl-moo" ,perl-moo)
+       ("perl-role-tiny" ,perl-role-tiny)))
+    (propagated-inputs
+     `(("perl-data-perl" ,perl-data-perl)))
+    (home-page
+     "http://search.cpan.org/dist/MooX-HandlesVia")
+    (synopsis "NativeTrait-like behavior for Moo")
+    (description
+     "@code{MooX::HandlesVia} is an extension of Moo's @code{handles}
+attribute functionality.  It provides a means of proxying functionality from
+an external class to the given atttribute.")
+    (license (package-license perl))))
+
 (define-public perl-moox-types-mooselike
   (package
     (name "perl-moox-types-mooselike")
-- 
2.14.1

[bug#28272] [PATCH 04/12] gnu: Add perl-moox-late.

[Christopher Baines]

* gnu/packages/perl.scm (perl-moox-late): New variable.
---
 gnu/packages/perl.scm | 40 ++++++++++++++++++++++++++++++++++++++++
 1 file changed, 40 insertions(+)

diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
index 1e489d021..0b4e3071d 100644
--- a/gnu/packages/perl.scm
+++ b/gnu/packages/perl.scm
@@ -5179,6 +5179,46 @@ attribute functionality.  It provides a means of proxying functionality from
 an external class to the given atttribute.")
     (license (package-license perl))))
 
+(define-public perl-moox-late
+  (package
+    (name "perl-moox-late")
+    (version "0.015")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "mirror://cpan/authors/id/T/TO/TOBYINK/MooX-late-"
+             version
+             ".tar.gz"))
+       (sha256
+        (base32
+         "1gzvd9zws3v09sh0xx6srmw4jwi22fnrya4zcsc8dykn62pjclqp"))))
+    (build-system perl-build-system)
+    (native-inputs
+     `(("perl-test-fatal" ,perl-test-fatal)
+       ("perl-test-requires" ,perl-test-requires)))
+    (inputs
+     `(("perl-moo" ,perl-moo)
+       ("perl-moox" ,perl-moox)
+       ("perl-moox-handlesvia" ,perl-moox-handlesvia)))
+    (propagated-inputs
+     `(("perl-type-tiny" ,perl-type-tiny)))
+    (home-page
+     "http://search.cpan.org/dist/MooX-late")
+    (synopsis "Easily translate Moose code to Moo")
+    (description
+     "MooX::late does the following:
+@enumerate
+@item Supports isa => $stringytype
+@item Supports does => $rolename
+@item Supports lazy_build => 1
+@item Exports blessed and confess functions to your namespace.
+@item Handles certain attribute traits
+Currently Hash, Array and Code are supported.  This feature requires
+MooX::HandlesVia.
+@end enumerate")
+    (license (package-license perl))))
+
 (define-public perl-moox-types-mooselike
   (package
     (name "perl-moox-types-mooselike")
-- 
2.14.1

[bug#28272] [PATCH 05/12] gnu: Add perl-convert-binhex.

[Christopher Baines]

* gnu/packages/perl.scm (perl-convert-binhex): New variable.
---
 gnu/packages/perl.scm | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
index 0b4e3071d..13e6941dd 100644
--- a/gnu/packages/perl.scm
+++ b/gnu/packages/perl.scm
@@ -1311,6 +1311,34 @@ the context the subroutine would have seen if it were the last statement in
 the caller.")
     (license (package-license perl))))
 
+(define-public perl-convert-binhex
+  (package
+    (name "perl-convert-binhex")
+    (version "1.125")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "mirror://cpan/authors/id/S/ST/STEPHEN/Convert-BinHex-"
+             version
+             ".tar.gz"))
+       (sha256
+        (base32
+         "15v3489k179cx0fz3lix79ssjid0nhhpf6c33swpxga6pss92dai"))))
+    (build-system perl-build-system)
+    (native-inputs
+     `(("perl-file-slurp" ,perl-file-slurp)
+       ("perl-test-most" ,perl-test-most)))
+    (home-page
+     "http://search.cpan.org/dist/Convert-BinHex")
+    (synopsis "Extract data from Macintosh BinHex files")
+    (description
+     "BinHex is a format for transporting files safely through electronic
+mail, as short-lined, 7-bit, semi-compressed data streams.  Ths module
+provides a means of converting those data streams back into into binary
+data.")
+    (license (package-license perl))))
+
 (define-public perl-cpan-meta-check
   (package
     (name "perl-cpan-meta-check")
-- 
2.14.1

[bug#28272] [PATCH 06/12] gnu: Add perl-mailtools.

[Christopher Baines]

* gnu/packages/perl.scm (perl-mailtools): New variable.
---
 gnu/packages/perl.scm | 45 +++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 45 insertions(+)

diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
index 13e6941dd..fb1cbaf3b 100644
--- a/gnu/packages/perl.scm
+++ b/gnu/packages/perl.scm
@@ -4205,6 +4205,51 @@ implementation of these functions only serves as a fallback in case the C
 portions of this module couldn't be compiled on this machine.")
     (license (package-license perl))))
 
+(define-public perl-mailtools
+  (package
+    (name "perl-mailtools")
+    (version "2.19")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "mirror://cpan/authors/id/M/MA/MARKOV/MailTools-"
+             version
+             ".tar.gz"))
+       (sha256
+        (base32
+         "06jykkv8mp484vzkmwd6dkicx029rl3ir5ljzrbap3paxw1dfzn1"))))
+    (build-system perl-build-system)
+    (propagated-inputs
+     `(("perl-timedate" ,perl-timedate)))
+    (home-page
+     "http://search.cpan.org/dist/MailTools")
+    (synopsis "Bundle of ancient email modules")
+    (description "MailTools contains the following modules:
+@table @asis
+@item Mail::Address
+Parse email address from a header line.
+@item Mail::Cap
+Interpret mailcap files: mappings of file-types to applications as used by
+many command-line email programs.
+@item Mail::Field
+Simplifies access to (some) email header fields.  Used by Mail::Header.
+@item Mail::Filter
+Process Mail::Internet messages.
+@item Mail::Header
+Collection of Mail::Field objects, representing the header of a Mail::Internet
+object.
+@item Mail::Internet
+Represents a single email message, with header and body.
+@item Mail::Mailer
+Send Mail::Internet emails via direct smtp or local MTA's.
+@item Mail::Send
+Build a Mail::Internet object, and then send it out using Mail::Mailer.
+@item Mail::Util
+\"Smart functions\" you should not depend on.
+@end table")
+    (license (package-license perl))))
+
 (define-public perl-memoize-expirelru
   (package
     (name "perl-memoize-expirelru")
-- 
2.14.1

[bug#28272] [PATCH 07/12] gnu: Add perl-mime-tools.

[Christopher Baines]

* gnu/packages/perl.scm (perl-mime-tools): New variable.
---
 gnu/packages/perl.scm | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
index fb1cbaf3b..13da2a6f5 100644
--- a/gnu/packages/perl.scm
+++ b/gnu/packages/perl.scm
@@ -4289,6 +4289,36 @@ the argument to the CACHESIZE parameter, will be cached.")
 MIME messages on Internet.")
     (license (package-license perl))))
 
+(define-public perl-mime-tools
+  (package
+    (name "perl-mime-tools")
+    (version "5.509")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "mirror://cpan/authors/id/D/DS/DSKOLL/MIME-tools-"
+             version
+             ".tar.gz"))
+       (sha256
+        (base32
+         "0wv9rzx5j1wjm01c3dg48qk9wlbm6iyf91j536idk09xj869ymv4"))))
+    (build-system perl-build-system)
+    (native-inputs
+     `(("perl-test-deep" ,perl-test-deep)))
+    (inputs
+     `(("perl-convert-binhex" ,perl-convert-binhex)))
+    (propagated-inputs
+     `(("perl-mailtools" ,perl-mailtools)))
+    (home-page
+     "http://search.cpan.org/dist/MIME-tools")
+    (synopsis "Tools to manipulate MIME messages")
+    (description
+     "MIME-tools is a collection of Perl5 MIME:: modules for parsing,
+decoding, and generating single- or multipart (even nested multipart) MIME
+messages.")
+    (license (package-license perl))))
+
 (define-public perl-mime-types
   (package
     (name "perl-mime-types")
-- 
2.14.1

[bug#28272] [PATCH 08/12] gnu: Add perl-net-idn-encode.

[Christopher Baines]

* gnu/packages/perl.scm (perl-net-idn-encode): New variable.
---
 gnu/packages/perl.scm | 32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
index 13da2a6f5..d22e461a0 100644
--- a/gnu/packages/perl.scm
+++ b/gnu/packages/perl.scm
@@ -5501,6 +5501,38 @@ cycle.  Functions called in the package itself will still be bound by their
 name, but they won't show up as methods on your class or instances.")
     (license (package-license perl))))
 
+(define-public perl-net-idn-encode
+  (package
+    (name "perl-net-idn-encode")
+    (version "2.400")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "mirror://cpan/authors/id/C/CF/CFAERBER/Net-IDN-Encode-"
+             version
+             ".tar.gz"))
+       (sha256
+        (base32
+         "0a9knav5f9kjldrkxx1k47ivd3p23zkmi8aqgyhnxidhgasz1dlq"))))
+    (build-system perl-build-system)
+    (native-inputs
+     `(("perl-module-build" ,perl-module-build)
+       ("perl-test-nowarnings" ,perl-test-nowarnings)))
+    (home-page
+     "http://search.cpan.org/dist/Net-IDN-Encode")
+    (synopsis
+     "Internationalizing Domain Names in Applications (IDNA)")
+    (description
+     "Internationalized Domain Names (IDNs) use characters drawn from a large
+repertoire (Unicode), but IDNA allows the non-ASCII characters to be
+represented using only the ASCII characters already allowed in so-called host
+names today (letter-digit-hyphen, /[A-Z0-9-]/i).
+
+Use this module if you just want to convert domain names (or email addresses),
+using whatever IDNA standard is the best choice at the moment.")
+    (license (package-license perl))))
+
 (define-public perl-net-statsd
   (package
    (name "perl-net-statsd")
-- 
2.14.1

[bug#28272] [PATCH 09/12] gnu: Add perl-text-template.

[Christopher Baines]

* gnu/packages/perl.scm (perl-text-template): New variable.
---
 gnu/packages/perl.scm | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
index d22e461a0..13f717f4b 100644
--- a/gnu/packages/perl.scm
+++ b/gnu/packages/perl.scm
@@ -8013,6 +8013,32 @@ algorism to indicate multiplication by 1000.")
     (description "Text::Table renders plaintext tables.")
     (license x11)))
 
+(define-public perl-text-template
+  (package
+    (name "perl-text-template")
+    (version "1.47")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "mirror://cpan/authors/id/M/MS/MSCHOUT/Text-Template-"
+             version
+             ".tar.gz"))
+       (sha256
+        (base32
+         "1z781cgz7wbn80lf3kqr2ad0pg6g1wlnim0822h8liw28k3l5msh"))))
+    (build-system perl-build-system)
+    (home-page
+     "http://search.cpan.org/dist/Text-Template")
+    (synopsis
+     "Expand template text with embedded Perl")
+    (description
+     "This is a library for generating letters, building HTML pages, or
+filling in templates generally.  A template is a piece of text that has little
+Perl programs embedded in it here and there.  When you fill in a template, you
+evaluate the little programs and replace them with their values.")
+    (license (package-license perl))))
+
 (define-public perl-text-unidecode
   (package
     (name "perl-text-unidecode")
-- 
2.14.1

[bug#28272] [PATCH 10/12] gnu: Add perl-gnupg-interface.

[Christopher Baines]

* gnu/packages/gnupg.scm (perl-gnupg-interface): New variable.
---
 gnu/packages/gnupg.scm | 39 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 39 insertions(+)

diff --git a/gnu/packages/gnupg.scm b/gnu/packages/gnupg.scm
index c442ce8ae..b1b63caa2 100644
--- a/gnu/packages/gnupg.scm
+++ b/gnu/packages/gnupg.scm
@@ -32,6 +32,7 @@
   #:use-module ((guix licenses) #:prefix license:)
   #:use-module (gnu packages)
   #:use-module (gnu packages adns)
+  #:use-module (gnu packages base)
   #:use-module (gnu packages curl)
   #:use-module (gnu packages openldap)
   #:use-module (gnu packages perl)
@@ -53,6 +54,7 @@
   #:use-module (guix download)
   #:use-module (guix git-download)
   #:use-module (guix build-system gnu)
+  #:use-module (guix build-system perl)
   #:use-module (guix build-system python))
 
 (define-public libgpg-error
@@ -522,6 +524,43 @@ and signature functionality from Python programs.")
 (define-public python2-gnupg
   (package-with-python2 python-gnupg))
 
+(define-public perl-gnupg-interface
+  (package
+    (name "perl-gnupg-interface")
+    (version "0.52")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "mirror://cpan/authors/id/A/AL/ALEXMV/GnuPG-Interface-"
+             version
+             ".tar.gz"))
+       (sha256
+        (base32
+         "0dgx8yhdsmhkazcrz14n4flrk1afv7azgl003hl4arxvi1d9yyi4"))))
+    (build-system perl-build-system)
+    (arguments
+     '(;; Result: FAIL
+       ;; Failed 10/20 test programs. 21/52 subtests failed.
+       #:tests? #f))
+    (native-inputs
+     `(("perl-module-install" ,perl-module-install)
+       ("which" ,which)))
+    (inputs
+     `(("gnupg" ,gnupg)))
+    (propagated-inputs
+     `(("perl-moo" ,perl-moo)
+       ("perl-moox-late" ,perl-moox-late)
+       ("perl-moox-handlesvia" ,perl-moox-handlesvia)))
+    (home-page "http://search.cpan.org/~alexmv/GnuPG-Interface/")
+    (synopsis "Perl interface to GnuPG")
+    (description
+     "@code{GnuPG::Interface} and its associated modules are designed to
+provide an object-oriented method for interacting with GnuPG, being able to
+perform functions such as but not limited to encrypting, signing, decryption,
+verification, and key-listing parsing.")
+    (license (package-license perl))))
+
 (define-public pius
   (package
    (name "pius")
-- 
2.14.1

[bug#28272] [PATCH 11/12] gnu: Add libmd.

[Christopher Baines]

* gnu/packages/crypto.scm (libmd): New variable.
---
 gnu/packages/crypto.scm | 31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)

diff --git a/gnu/packages/crypto.scm b/gnu/packages/crypto.scm
index 0a05a1069..98155779a 100644
--- a/gnu/packages/crypto.scm
+++ b/gnu/packages/crypto.scm
@@ -78,6 +78,37 @@ communication, encryption, decryption, signatures, etc.")
     (license license:isc)
     (home-page "http://libsodium.org")))
 
+(define-public libmd
+  (package
+    (name "libmd")
+    (version "0.0.0")
+    (source (origin
+            (method url-fetch)
+            (uri (string-append
+                  "https://archive.hadrons.org/software/libmd/libmd-"
+                  version
+                  ".tar.xz"))
+            (sha256
+             (base32
+              "121s73pgbqsnmy6xblbrkj9y44c5zzzpf2hcmh6zvcvg4dk26gzx"))))
+    (build-system gnu-build-system)
+    (synopsis "Message Digest functions from BSD systems")
+    (description
+     "The currently provided message digest algorithms are:
+@itemize
+@item MD2
+@item MD4
+@item MD5
+@item RIPEMD-160
+@item SHA-1
+@item SHA-2 (SHA-256, SHA-384 and SHA-512)
+@end itemize")
+    (license (list license:bsd-3
+                   license:bsd-2
+                   license:isc
+                   license:public-domain))
+    (home-page "https://www.hadrons.org/software/libmd/")))
+
 (define-public signify
   (package
     (name "signify")
-- 
2.14.1

[bug#28272] [PATCH 12/12] gnu: Update signing-party.

[Christopher Baines]

Also add more inputs to make the caff program run. I haven't successfully used
it yet though.

* gnu/packages/gnupg.scm (signing-party)[version]: Update to 2.6.
  [source]: Update origin sha256.
  [native-inputs]: Add autoconf and automake.
  [inputs]: Add perl-text-template, perl-mime-tools, perl-gnupg-interface and
  perl-net-idn-encode as these are required by caff. Also add libmd as this is
  required by TODO.
  [arguments]: Add the change-directory and wrap-programs phase, and fix a
  regex and Makefile path in the configure phase.
---
 gnu/packages/gnupg.scm | 40 +++++++++++++++++++++++++++++-----------
 1 file changed, 29 insertions(+), 11 deletions(-)

diff --git a/gnu/packages/gnupg.scm b/gnu/packages/gnupg.scm
index b1b63caa2..a518c8e7b 100644
--- a/gnu/packages/gnupg.scm
+++ b/gnu/packages/gnupg.scm
@@ -32,8 +32,10 @@
   #:use-module ((guix licenses) #:prefix license:)
   #:use-module (gnu packages)
   #:use-module (gnu packages adns)
+  #:use-module (gnu packages autotools)
   #:use-module (gnu packages base)
   #:use-module (gnu packages curl)
+  #:use-module (gnu packages crypto)
   #:use-module (gnu packages openldap)
   #:use-module (gnu packages perl)
   #:use-module (gnu packages pth)
@@ -605,38 +607,48 @@ PGP keysigning parties.")
 (define-public signing-party
   (package
    (name "signing-party")
-   (version "1.1.4")
+   (version "2.6")
    (source (origin
             (method url-fetch)
             (uri (string-append "mirror://debian/pool/main/s/signing-party/"
                                 "signing-party_" version ".orig.tar.gz"))
             (sha256 (base32
-                     "188gp0prbh8qs29lq3pbf0qibfd6jq4fk7i0pfrybl8aahvm84rx"))))
+                     "1n5bpcfpl9vg1xp6r1jhbyahrgdyxp05b5pria1rh4m0qnv8sifr"))))
    (build-system gnu-build-system)
-   (inputs `(("perl" ,perl)))
+   (native-inputs
+    `(("autoconf" ,(autoconf-wrapper))
+      ("automake" ,automake)))
+   (inputs `(("perl" ,perl)
+             ("perl-text-template" ,perl-text-template)
+             ("perl-mime-tools" ,perl-mime-tools)
+             ("perl-gnupg-interface" ,perl-gnupg-interface)
+             ("perl-net-idn-encode" ,perl-net-idn-encode)
+             ("libmd" ,libmd)))
    (arguments
     `(#:tests? #f
       #:phases
       (modify-phases %standard-phases
-        (add-after 'unpack 'remove-spurious-links
-          (lambda _ (delete-file "keyanalyze/pgpring/depcomp")))
+        (add-before 'configure 'change-directory
+          (lambda _
+            ;; The build system in the unpack phase changes to a less useful
+            ;; subdirectory, so move up one level
+            (chdir (dirname (getcwd)))))
         (replace 'configure
           (lambda* (#:key outputs #:allow-other-keys)
             (let ((out (assoc-ref outputs "out")))
               (substitute* "keyanalyze/Makefile"
                 (("LDLIBS") (string-append "CC=" (which "gcc") "\nLDLIBS")))
               (substitute* "keyanalyze/Makefile"
-                (("./configure") (string-append "./configure --prefix=" out)))
-              (substitute* "keyanalyze/pgpring/configure"
-                (("/bin/sh") (which "sh")))
-              (substitute* "gpgwrap/Makefile"
+                (("\\./configure") (string-append "./configure --prefix=" out)))
+              (substitute* "gpgwrap/src/Makefile"
                 (("\\} clean")
                  (string-append "} clean\ninstall:\n\tinstall -D bin/gpgwrap "
                                 out "/bin/gpgwrap\n")))
               (substitute* '("gpgsigs/Makefile" "keyanalyze/Makefile"
                              "keylookup/Makefile" "sig2dot/Makefile"
                              "springgraph/Makefile")
-                           (("/usr") out)))))
+                (("/usr") out))
+              (setenv "CONFIG_SHELL" (which "sh")))))
         (replace 'install
           (lambda* (#:key outputs #:allow-other-keys #:rest args)
             (let ((out (assoc-ref outputs "out"))
@@ -661,7 +673,13 @@ PGP keysigning parties.")
                 '("caff.1" "pgp-clean.1" "pgp-fixkey.1" "gpgdir.1"
                   "gpg-key2ps.1" "gpglist.1" "gpg-mailkeys.1"
                   "gpgparticipants.1" "gpgsigs.1" "gpgwrap.1"
-                  "process_keys.1" "pgpring.1" "keyanalyze.1"))))))))
+                  "process_keys.1" "pgpring.1" "keyanalyze.1")))))
+        (add-after 'install 'wrap-programs
+          (lambda* (#:key outputs #:allow-other-keys)
+            (let* ((out (assoc-ref outputs "out")))
+              (wrap-program
+                  (string-append out "/bin/caff")
+                `("PERL5LIB" ":" prefix (,(getenv "PERL5LIB"))))))))))
    (synopsis "Collection of scripts for simplifying gnupg key signing")
    (description
     "Signing-party is a collection for all kinds of PGP/GnuPG related things,
-- 
2.14.1

[bug#28272] [PATCH] Improve and upgrade signing-party.

[Ludovic Courtès]

Christopher Baines <mail@cbaines.net> skribis:

> Add several missing dependencies, particularly for the caff tool. It
> now runs, but I've been unable to get it working fully yet, possibly
> due to problems with the actual sending of the emails.
>
> Christopher Baines (12):
>   gnu: Add perl-moox.
>   gnu: Add perl-data-perl.
>   gnu: Add perl-moox-handlesvia.
>   gnu: Add perl-moox-late.
>   gnu: Add perl-convert-binhex.
>   gnu: Add perl-mailtools.
>   gnu: Add perl-mime-tools.
>   gnu: Add perl-net-idn-encode.
>   gnu: Add perl-text-template.
>   gnu: Add perl-gnupg-interface.
>   gnu: Add libmd.
>   gnu: Update signing-party.

At first sight this looks good to me.

Please use ‘license:perl-license’ instead of (package-license perl).

OK with this change, thank you!

Ludo’.

[bug#28272] [PATCH] Improve and upgrade signing-party.

[Christopher Baines]

[-- Attachment #1: Type: text/plain, Size: 1132 bytes --]

On Fri, 08 Sep 2017 18:07:01 +0200
ludo@gnu.org (Ludovic Courtès) wrote:

> Christopher Baines <mail@cbaines.net> skribis:
> 
> > Add several missing dependencies, particularly for the caff tool. It
> > now runs, but I've been unable to get it working fully yet, possibly
> > due to problems with the actual sending of the emails.
> >
> > Christopher Baines (12):
> >   gnu: Add perl-moox.
> >   gnu: Add perl-data-perl.
> >   gnu: Add perl-moox-handlesvia.
> >   gnu: Add perl-moox-late.
> >   gnu: Add perl-convert-binhex.
> >   gnu: Add perl-mailtools.
> >   gnu: Add perl-mime-tools.
> >   gnu: Add perl-net-idn-encode.
> >   gnu: Add perl-text-template.
> >   gnu: Add perl-gnupg-interface.
> >   gnu: Add libmd.
> >   gnu: Update signing-party.  
> 
> At first sight this looks good to me.

Great, thanks for reviewing :)

> Please use ‘license:perl-license’ instead of (package-license perl).

Within (gnu packages perl), it doesn't use a prefix for the licenses
module. I could switch it to use the license: prefix, or use just
perl-license within that module. Do you have a preference?

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 963 bytes --]

[bug#28272] [PATCH] Improve and upgrade signing-party.

[Ludovic Courtès]

Christopher Baines <mail@cbaines.net> skribis:

> On Fri, 08 Sep 2017 18:07:01 +0200
> ludo@gnu.org (Ludovic Courtès) wrote:
>
>> Christopher Baines <mail@cbaines.net> skribis:
>> 
>> > Add several missing dependencies, particularly for the caff tool. It
>> > now runs, but I've been unable to get it working fully yet, possibly
>> > due to problems with the actual sending of the emails.
>> >
>> > Christopher Baines (12):
>> >   gnu: Add perl-moox.
>> >   gnu: Add perl-data-perl.
>> >   gnu: Add perl-moox-handlesvia.
>> >   gnu: Add perl-moox-late.
>> >   gnu: Add perl-convert-binhex.
>> >   gnu: Add perl-mailtools.
>> >   gnu: Add perl-mime-tools.
>> >   gnu: Add perl-net-idn-encode.
>> >   gnu: Add perl-text-template.
>> >   gnu: Add perl-gnupg-interface.
>> >   gnu: Add libmd.
>> >   gnu: Update signing-party.  
>> 
>> At first sight this looks good to me.
>
> Great, thanks for reviewing :)
>
>> Please use ‘license:perl-license’ instead of (package-license perl).
>
> Within (gnu packages perl), it doesn't use a prefix for the licenses
> module. I could switch it to use the license: prefix, or use just
> perl-license within that module. Do you have a preference?

Either way is fine.  My point is: use the ‘perl-license’ binding of
(guix licenses), not (package-license perl).

See the rationale in (guix licenses).

Thanks!

Ludo’.

[bug#28272] [PATCH] Improve and upgrade signing-party.

[Christopher Baines]

[-- Attachment #1: Type: text/plain, Size: 1859 bytes --]

On Sun, 10 Sep 2017 15:14:30 +0200
ludo@gnu.org (Ludovic Courtès) wrote:

> Christopher Baines <mail@cbaines.net> skribis:
> 
> > On Fri, 08 Sep 2017 18:07:01 +0200
> > ludo@gnu.org (Ludovic Courtès) wrote:
> >  
> >> Christopher Baines <mail@cbaines.net> skribis:
> >>   
> >> > Add several missing dependencies, particularly for the caff
> >> > tool. It now runs, but I've been unable to get it working fully
> >> > yet, possibly due to problems with the actual sending of the
> >> > emails.
> >> >
> >> > Christopher Baines (12):
> >> >   gnu: Add perl-moox.
> >> >   gnu: Add perl-data-perl.
> >> >   gnu: Add perl-moox-handlesvia.
> >> >   gnu: Add perl-moox-late.
> >> >   gnu: Add perl-convert-binhex.
> >> >   gnu: Add perl-mailtools.
> >> >   gnu: Add perl-mime-tools.
> >> >   gnu: Add perl-net-idn-encode.
> >> >   gnu: Add perl-text-template.
> >> >   gnu: Add perl-gnupg-interface.
> >> >   gnu: Add libmd.
> >> >   gnu: Update signing-party.    
> >> 
> >> At first sight this looks good to me.  
> >
> > Great, thanks for reviewing :)
> >  
> >> Please use ‘license:perl-license’ instead of (package-license
> >> perl).  
> >
> > Within (gnu packages perl), it doesn't use a prefix for the licenses
> > module. I could switch it to use the license: prefix, or use just
> > perl-license within that module. Do you have a preference?  
> 
> Either way is fine.  My point is: use the ‘perl-license’ binding of
> (guix licenses), not (package-license perl).
> 
> See the rationale in (guix licenses).

Ok, I'll switch these packages over to use perl-license, and the other
perl ones I've done recently.

Also, if this is a sensible thing to do, it's probably worth changing
the importer to match, I've sent a patch as #28410 [1].

1: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=28410

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 963 bytes --]

bug#28272: [PATCH] Improve and upgrade signing-party.

[Christopher Baines]

[-- Attachment #1: Type: text/plain, Size: 1027 bytes --]

On Fri, 08 Sep 2017 18:07:01 +0200
ludo@gnu.org (Ludovic Courtès) wrote:

> Christopher Baines <mail@cbaines.net> skribis:
> 
> > Add several missing dependencies, particularly for the caff tool. It
> > now runs, but I've been unable to get it working fully yet, possibly
> > due to problems with the actual sending of the emails.
> >
> > Christopher Baines (12):
> >   gnu: Add perl-moox.
> >   gnu: Add perl-data-perl.
> >   gnu: Add perl-moox-handlesvia.
> >   gnu: Add perl-moox-late.
> >   gnu: Add perl-convert-binhex.
> >   gnu: Add perl-mailtools.
> >   gnu: Add perl-mime-tools.
> >   gnu: Add perl-net-idn-encode.
> >   gnu: Add perl-text-template.
> >   gnu: Add perl-gnupg-interface.
> >   gnu: Add libmd.
> >   gnu: Update signing-party.  
> 
> At first sight this looks good to me.
> 
> Please use ‘license:perl-license’ instead of (package-license perl).
> 
> OK with this change, thank you!

I've updated the licence for the packages, and now pushed :) Thanks
for reviewing.

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 963 bytes --]