bug#28190: [PATCH] gnu: Build the shared library for yaml-cpp.

[Christopher Baines <mail@cbaines.net>]

[-- Attachment #1: Type: text/plain, Size: 1099 bytes --]

On Tue, 22 Aug 2017 23:10:38 +0200
Marius Bakke <mbakke@fastmail.com> wrote:

> Christopher Baines <mail@cbaines.net> writes:
> 
> > On Tue, 22 Aug 2017 22:58:34 +0200
> > Marius Bakke <mbakke@fastmail.com> wrote:
> >  
> >> Christopher Baines <mail@cbaines.net> writes:
> >>   
> >> > * gnu/packages/serialization.scm (yaml-cpp)[arguments]: Add
> >> >   -DBUILD_SHARED_LIBS=ON to #:configure-flags.    
> >> 
> >> Does this disable building the static library too?  If not, should
> >> we do that while at it?  LGTM, anyway.  
> >
> > I'm not quite sure, but I think so, these are the files in lib now,
> > and the .a file that was there before has disappeared.
> >
> > └── lib
> >     ├── libyaml-cpp.so -> libyaml-cpp.so.0.5
> >     ├── libyaml-cpp.so.0.5 -> libyaml-cpp.so.0.5.3
> >     ├── libyaml-cpp.so.0.5.3
> >     └── pkgconfig
> >         └── yaml-cpp.pc  
> 
> Great!  Static libraries cannot be reliably grafted, so it's good to
> avoid them when we can.  Thanks!

I've pushed this now, thanks for your review Marius :)

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 963 bytes --]