all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Efraim Flashner <efraim@flashner.co.il>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: GRUB EFI installation breakage
Date: Tue, 22 Aug 2017 17:47:39 +0300	[thread overview]
Message-ID: <20170822144739.GF2484@macbook42.flashner.co.il> (raw)
In-Reply-To: <87efs34tfl.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 1877 bytes --]

On Tue, Aug 22, 2017 at 03:34:54PM +0200, Ludovic Courtès wrote:
> Hello,
> 
> To reconfigure my system on UEFI, I had to apply this patch:
> 

> modified   gnu/bootloader/grub.scm
> @@ -401,7 +401,8 @@ submenu \"GNU system, old configurations...\" {~%")
>          ;; root partition.
>          (setenv "GRUB_ENABLE_CRYPTODISK" "y")
>          (unless (zero? (system* grub-install "--boot-directory" install-dir
> -                                "--efi-directory" efi-dir))
> +                                ;; "--efi-directory" efi-dir
> +                                ))
>            (error "failed to install GRUB (EFI)")))))
>  

> 
> Before that ‘grub-install’ would fail because ‘efi-dir’ would actually
> be “/dev/sda”, which is what I have in the ‘device’ field of
> ‘grub-configuration’.
> 
> Removing the “--efi-directory” solves the problem because ‘grub-install’
> automatically determines that the EFI directory is mounted at /boot/efi.
> 
> I think 2941b347b664a3d3114de0ac95e28db78db66144 is bogus because it
> assumes that the second argument of the gexp’d lambda is ‘efi-dir’,
> where in fact it is the ‘device’ field of the bootloader config.
> 
> So what is the preferred fix?  Simply remove “--efi-directory” like I
> did above, and rename ‘efi-dir’ to ‘device’ to avoid the ambiguity?
> Thoughts?
> 
> Ludo’.

I spent part of today staring at grub
https://www.gnu.org/software/grub/manual/html_node/Installing-GRUB-using-grub_002dinstall.html#Installing-GRUB-using-grub_002dinstall
if efi-directory is /boot/efi then there's no need for the flag.

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2017-08-22 14:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-22 13:34 GRUB EFI installation breakage Ludovic Courtès
2017-08-22 14:47 ` Efraim Flashner [this message]
2017-08-22 20:00 ` Marius Bakke
2017-08-22 22:25   ` Ludovic Courtès
2017-08-23  9:14     ` Andy Wingo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170822144739.GF2484@macbook42.flashner.co.il \
    --to=efraim@flashner.co.il \
    --cc=guix-devel@gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.