* [bug#28145] [PATCH] build: Do not store two copies of the ISO-9660 superblock anymore.
@ 2017-08-19 2:46 Danny Milosavljevic
2017-08-22 13:07 ` Ludovic Courtès
0 siblings, 1 reply; 5+ messages in thread
From: Danny Milosavljevic @ 2017-08-19 2:46 UTC (permalink / raw)
To: 28145
* gnu/build/vm.scm (make-iso9660-image): Do not store two copies of the
ISO-9660 superblock anymore.
---
gnu/build/vm.scm | 13 -------------
1 file changed, 13 deletions(-)
diff --git a/gnu/build/vm.scm b/gnu/build/vm.scm
index 727494ad9..409320b1a 100644
--- a/gnu/build/vm.scm
+++ b/gnu/build/vm.scm
@@ -379,19 +379,6 @@ GRUB configuration and OS-DRV as the stuff in it."
"var=/tmp/root/var"
"run=/tmp/root/run"
"--"
- ;; Store two copies of the headers.
- ;; The resulting ISO-9660 image has a DOS MBR and
- ;; one protective partition (with type 0xCD).
- ;; Because GuixSD only uses actual partitions
- ;; rather than what /proc/partitions returns, work
- ;; around it by storing the primary volume
- ;; descriptor twice, once where it should be and
- ;; once in the partition.
- ;; Allegedly, otherwise, many other GNU tools
- ;; (automounters etc) would also be confused by
- ;; the extra partition so it makes sense to
- ;; store two copies in any case.
- "-boot_image" "any" "partition_offset=16"
"-volid" ,(string-upcase volume-id)
,@(if volume-uuid
`("-volume_date" "uuid"
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [bug#28145] [PATCH] build: Do not store two copies of the ISO-9660 superblock anymore.
2017-08-19 2:46 [bug#28145] [PATCH] build: Do not store two copies of the ISO-9660 superblock anymore Danny Milosavljevic
@ 2017-08-22 13:07 ` Ludovic Courtès
2017-08-29 5:49 ` Danny Milosavljevic
2017-09-19 21:29 ` Ludovic Courtès
0 siblings, 2 replies; 5+ messages in thread
From: Ludovic Courtès @ 2017-08-22 13:07 UTC (permalink / raw)
To: Danny Milosavljevic; +Cc: 28145
Hello Danny,
Danny Milosavljevic <dannym@scratchpost.org> skribis:
> * gnu/build/vm.scm (make-iso9660-image): Do not store two copies of the
> ISO-9660 superblock anymore.
Why is it no longer needed? Otherwise fine with me. :-)
Ludo’.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [bug#28145] [PATCH] build: Do not store two copies of the ISO-9660 superblock anymore.
2017-08-22 13:07 ` Ludovic Courtès
@ 2017-08-29 5:49 ` Danny Milosavljevic
2017-08-29 21:38 ` Ludovic Courtès
2017-09-19 21:29 ` Ludovic Courtès
1 sibling, 1 reply; 5+ messages in thread
From: Danny Milosavljevic @ 2017-08-29 5:49 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: 28145
Hi Ludo,
On Tue, 22 Aug 2017 15:07:28 +0200
ludo@gnu.org (Ludovic Courtès) wrote:
> Danny Milosavljevic <dannym@scratchpost.org> skribis:
>
> > * gnu/build/vm.scm (make-iso9660-image): Do not store two copies of the
> > ISO-9660 superblock anymore.
>
> Why is it no longer needed? Otherwise fine with me. :-)
Because we went ahead and now we just read it from the whole disk on boot (previously, it only accepted superblocks on partitions, remember?).
Previously on master:
- DVD
+ ISO9660 superblock
+ partition table
+ partition
+ ISO9660 superblock copy <--- GuixSD sees this
Now on master:
- DVD
+ ISO9660 superblock <--- GuixSD sees this
+ partition table
+ partition
+ ISO9660 superblock copy <--- what's this for now?
With the patch:
- DVD
+ ISO9660 superblock <--- GuixSD sees this
+ partition table
+ partition
^ permalink raw reply [flat|nested] 5+ messages in thread
* [bug#28145] [PATCH] build: Do not store two copies of the ISO-9660 superblock anymore.
2017-08-29 5:49 ` Danny Milosavljevic
@ 2017-08-29 21:38 ` Ludovic Courtès
0 siblings, 0 replies; 5+ messages in thread
From: Ludovic Courtès @ 2017-08-29 21:38 UTC (permalink / raw)
To: Danny Milosavljevic; +Cc: 28145
Danny Milosavljevic <dannym@scratchpost.org> skribis:
> Hi Ludo,
>
> On Tue, 22 Aug 2017 15:07:28 +0200
> ludo@gnu.org (Ludovic Courtès) wrote:
>> Danny Milosavljevic <dannym@scratchpost.org> skribis:
>>
>> > * gnu/build/vm.scm (make-iso9660-image): Do not store two copies of the
>> > ISO-9660 superblock anymore.
>>
>> Why is it no longer needed? Otherwise fine with me. :-)
>
> Because we went ahead and now we just read it from the whole disk on boot (previously, it only accepted superblocks on partitions, remember?).
>
> Previously on master:
>
> - DVD
> + ISO9660 superblock
> + partition table
> + partition
> + ISO9660 superblock copy <--- GuixSD sees this
>
> Now on master:
>
> - DVD
> + ISO9660 superblock <--- GuixSD sees this
> + partition table
> + partition
> + ISO9660 superblock copy <--- what's this for now?
>
> With the patch:
>
> - DVD
> + ISO9660 superblock <--- GuixSD sees this
> + partition table
> + partition
Thanks for the explanation, got it now.
Ludo’.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [bug#28145] [PATCH] build: Do not store two copies of the ISO-9660 superblock anymore.
2017-08-22 13:07 ` Ludovic Courtès
2017-08-29 5:49 ` Danny Milosavljevic
@ 2017-09-19 21:29 ` Ludovic Courtès
1 sibling, 0 replies; 5+ messages in thread
From: Ludovic Courtès @ 2017-09-19 21:29 UTC (permalink / raw)
To: Danny Milosavljevic; +Cc: 28145
Hi Danny,
Just a reminder that this patch hasn’t been applied. TIA! :-)
Ludo’.
ludo@gnu.org (Ludovic Courtès) skribis:
> Hello Danny,
>
> Danny Milosavljevic <dannym@scratchpost.org> skribis:
>
>> * gnu/build/vm.scm (make-iso9660-image): Do not store two copies of the
>> ISO-9660 superblock anymore.
>
> Why is it no longer needed? Otherwise fine with me. :-)
>
> Ludo’.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-09-19 21:30 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-19 2:46 [bug#28145] [PATCH] build: Do not store two copies of the ISO-9660 superblock anymore Danny Milosavljevic
2017-08-22 13:07 ` Ludovic Courtès
2017-08-29 5:49 ` Danny Milosavljevic
2017-08-29 21:38 ` Ludovic Courtès
2017-09-19 21:29 ` Ludovic Courtès
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.