From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52354) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dhhPj-0001wP-Gt for guix-patches@gnu.org; Tue, 15 Aug 2017 15:22:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dhhPe-0002ZZ-EY for guix-patches@gnu.org; Tue, 15 Aug 2017 15:22:07 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:58788) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dhhPe-0002ZM-7Y for guix-patches@gnu.org; Tue, 15 Aug 2017 15:22:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dhhPd-0002b1-W2 for guix-patches@gnu.org; Tue, 15 Aug 2017 15:22:02 -0400 Subject: [bug#28093] [PATCH] gnu: cgit: Don't build cgit's special 'git:src' input. Resent-Message-ID: Date: Tue, 15 Aug 2017 15:21:36 -0400 From: Leo Famulari Message-ID: <20170815192136.GB9893@jasmine.lan> References: <20170815073531.4b72ab02@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="oyUTqETQ0mS9luUI" Content-Disposition: inline In-Reply-To: <20170815073531.4b72ab02@cbaines.net> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Christopher Baines Cc: 28093@debbugs.gnu.org --oyUTqETQ0mS9luUI Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Aug 15, 2017 at 07:35:31AM +0100, Christopher Baines wrote: > On Mon, 14 Aug 2017 23:31:37 -0400 > Leo Famulari wrote: >=20 > > * gnu/packages/version-control.scm (cgit)[inputs]: Replace the > > git@2.10 package with an origin reference of the source code. > > (git@2.10): Remove variable. >=20 > It would be useful if outside of the changelog, but in the commit > message, you could put why you are making the change. As far as I can > tell, this won't change the cgit package, so I'm guessing the intent is > to neaten up the code? Recently we started running the test suite of the "main" git package. That caused the build of this package to fail, which also made cgit fail to build, and that was annoying. But, we don't even need to build this source code as a package, since it gets built within the cgit build process, and we don't run the tests there. So, I figured we might as well not provide this as a package at all, since it's really just intended to provide source code to cgit. Does that sound reasonable? If so, I'll summarize this in the commit message. --oyUTqETQ0mS9luUI Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAlmTSbwACgkQJkb6MLrK fwhcyxAAowvT21uW6FEtX2TNAytiXm+szNumuPixk/b/nHdH90oUt6VKkt4iI1+1 lYHR7ImdCKM0E5L/dNZ9g4oro18GWlDYHfG+y2DMlgfvUhPW7EOIa8czToORru++ 0+NOm3lNIo1kg8r6/GMeR1MwDdoDQ+L0TKiSWReNjFaqjo06DjQqI4mVojFsXIYJ dPjA7h7EnhThaJS60z8hW9JBupilaJzM0KLZDlJKO/DQ70swOyChkvQbDW7yKy+n WXUZjzvHwhBxVOavGDOCWYKQhuFYcIdq3f3bbliQgC3dViBZXS+mFbLZgbd+A8X4 rNmv5iO2WfAWgMBpGmH+vlTTQ9Dlh6Rb1R1p+HvxEwObaq6ii0VagJvrP25tFMGw c5A9FtYpRlLjdAEdoYrgUENPbE9E5IRWxDEn0GXejeAPpOAkPrpHfBmaCtDuyyus 3sGxCVtq+ZWcjcgJ13hHHviSaon5wOuvvYVHZYCUQ9AGNl0NGKMUQjimUcJ06VXN bFHfscEBeGYkOPBA1OPGadmuI3+Fn6aWfaK+cnmSwb+tg8EKGjKP9om0TgRpUu4d BffD63xpxPwp+DrPSJHQrlyfQSimvPLL9MZHfNvK8FVym3k7exDWFqCY4Grux06m tw4TueEkLC9Do+oHwfQrq+ZlKNDhEFBHQyPgRQ/DbgAMPxG84IU= =E3R5 -----END PGP SIGNATURE----- --oyUTqETQ0mS9luUI--