From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38183) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dgZZ3-0007Mm-W6 for guix-patches@gnu.org; Sat, 12 Aug 2017 12:47:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dgZZ0-0008O2-U3 for guix-patches@gnu.org; Sat, 12 Aug 2017 12:47:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:48445) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dgZZ0-0008No-Pk for guix-patches@gnu.org; Sat, 12 Aug 2017 12:47:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dgZZ0-0003N6-6L for guix-patches@gnu.org; Sat, 12 Aug 2017 12:47:02 -0400 Subject: [bug#28060] [PATCH] gnu: Add emacs-nixos-mode. Resent-Message-ID: Date: Sat, 12 Aug 2017 16:46:29 +0000 From: ng0 Message-ID: <20170812164629.rzko2qinssiqhezi@abyayala> References: <87shgx2rql.fsf@gmail.com> <7a592bd0.ADkAACozouwAAAAAAAAAAAPfggsAAAACwQwAAAAAAAW9WABZjxmB@mailjet.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="tyciogbxm55zruva" Content-Disposition: inline In-Reply-To: <7a592bd0.ADkAACozouwAAAAAAAAAAAPfggsAAAACwQwAAAAAAAW9WABZjxmB@mailjet.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Arun Isaac Cc: 28060@debbugs.gnu.org --tyciogbxm55zruva Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Arun Isaac transcribed 1.1K bytes: >=20 > Thanks for the patch! >=20 > Oleg Pykhalov writes: >=20 > > +(define-public emacs-nixos-mode > > + (package > > + (name "emacs-nixos-mode") > > + (version "1.11.13") >=20 > misc/emacs/nix-mode.el says the version number is 1.0. This contradicts > the release version number 1.11.13. But, I guess we can go with the > release version number. >=20 > > + (arguments > > + `(#:phases > > + (modify-phases %standard-phases > > + (add-after 'unpack 'chdir-elisp > > + (lambda _ > > + (chdir "misc/emacs")))))) >=20 > It is kinda obvious, but do add a short comment explaining why we are > changing directory. >=20 > > + (synopsis "Emacs major mode for editing Nix expressions") > > + (description "@code{nixos-mode} provides an Emacs major mode for e= diting > > +Nix expressions.") >=20 > Could you add the following line to the description? >=20 > "It supports syntax highlighting, indenting and refilling of comments." >=20 > I have taken the above sentence from > https://github.com/NixOS/nix/blob/master/misc/emacs/README >=20 > > + (license license:gpl3+))) >=20 > Nix is under the LGPL 2.1 license. So, nix-mode should also be under the > same license, right? >=20 > Could you send an updated patch? Thanks! We have Nix in (gnu packages package-management). Why do you fetch it again when we could just add another output to the nix package? --=20 ng0 GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588 GnuPG: https://n0is.noblogs.org/my-keys https://www.infotropique.org https://krosos.org --tyciogbxm55zruva Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEqIyK3RKYKNfqwC5S4i+bv+40hYgFAlmPMOUACgkQ4i+bv+40 hYjL7A/+Oh26kQJ7VZcUAH6VX71f26gZHTfmT05Su8XfWEDxJsgpqcij+SOPA8K1 YIGlLQUfypNOhxg3JFw42RUfFNID5oM13gMilU/GGcuUh5u8USDQTEiVyqqqsAJc YP1kpbvInbHUzjke/5zLl6scxmvHFygR3lS8g3FdtF0Nq7e26obqQ0FYeXJtX3R+ W4Knnx1nOVmMlblyulnahRd6CZuZZ+qtYAS52Q8k2yQk6hgANLGPDnAO0LXOAteg yqEux7Ujvc8tqqgbPxuly20nNA+FTc/CThj62IWKeXkFdm1pAKlmg4y+GSmuewey I/7L1U23Bf0TIFiVj4lNxjJzYTKoYjUCteBlmD43sMUDHgUD7FnShoEGHS6HVLXQ T4PMr/qtwJndswOC4WthhG/b2dKOS5HcTkGkizoVkXMDDOkgv4TaXHBGGivLOYmK 9lcyiCfClrf64P99xwiovfZToECJAZPDGqd5mPSom/MCxOo4jBA42LMONBdjU6TO JdCVexZsw2lP81BP/yNRVMsAH5fqEglWRK8iF0ESZ1WmULaDJAFfqg953LUQKvwL oB8+4mVskfNIu8DcmG1F0jTfoaYLBA2IJNeFqzxKXV5+VDA/OIru2m6BeqIqOBiy 3LSc6MXrZhaK9xktJRlxAhACG3YlONWmQaNEt1hIcV1AVTjR5O8= =LXKY -----END PGP SIGNATURE----- --tyciogbxm55zruva--