From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55372) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dgQP3-0007MW-MA for guix-patches@gnu.org; Sat, 12 Aug 2017 03:00:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dgQOx-0004eQ-P1 for guix-patches@gnu.org; Sat, 12 Aug 2017 03:00:09 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:47565) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dgQOx-0004eC-LL for guix-patches@gnu.org; Sat, 12 Aug 2017 03:00:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dgQOw-0001Og-CU for guix-patches@gnu.org; Sat, 12 Aug 2017 03:00:03 -0400 Subject: [bug#27855] [PATCH] gnu: Add rsync service. Resent-Message-ID: Date: Sat, 12 Aug 2017 07:59:03 +0100 From: Christopher Baines Message-ID: <20170812075903.0dc36c0c@cbaines.net> In-Reply-To: <87y3qprjjd.fsf@gmail.com> References: <20170727220151.2116-1-go.wigust@gmail.com> <20170728231747.5eae3af9@cbaines.net> <874ltvh5d6.fsf@gmail.com> <20170729125554.29836b28@cbaines.net> <87r2wszni8.fsf@gmail.com> <20170803163322.3e87b004@cbaines.net> <87fud8zkqv.fsf@gmail.com> <20170810081820.71b29b0a@cbaines.net> <20170810192139.2c3f04da@cbaines.net> <87mv778d66.fsf@gmail.com> <87y3qprjjd.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/DOe.QTcP7GQvFM+yDA0xb2f"; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Oleg Pykhalov Cc: 27855@debbugs.gnu.org --Sig_/DOe.QTcP7GQvFM+yDA0xb2f Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Fri, 11 Aug 2017 22:28:22 +0300 Oleg Pykhalov wrote: > Hello, >=20 > > Hello Christopher, > > > > Thank you for supporting this patch! > > > > Christopher Baines writes: > > =20 > >> On Thu, 10 Aug 2017 08:18:20 +0100 > >> Christopher Baines wrote: > >> =20 > >>> I've attached the beginnings of a system test for this. I haven't > >>> got as far as actually testing the service directly yet, but I'm > >>> going to try testing it, both when running as root, and when not > >>> running as root. > >>>=20 > >>> A VM start script can be created from this rsync.scm file, by > >>> running: guix system vm gnu/tests/rsync.scm > >>>=20 > >>> Also, the test itself can be run by doing: > >>> make check-system TESTS=3Drsync =20 > >> > >> I've now got around to actually testing the service. I've attached > >> a patch which creates two system tests. One which tests the > >> service with the default port, and one with a higher port (I > >> randomly picked 2000). > >> > >> The default port test currently passes, but the higher port one > >> currently fails as the rsync service can't create the PID file. > >> > >> One option to fix this would be to create a /var/run/rsync > >> directory which is owned by the rsyncd user, and then create the > >> PID file as /var/run/rsync/pid. =20 > > > > I'll check it later, if you'll not be faster than me. :-) > > =20 > >> Just let me know if you have any questions? =20 > > =E2=80=A6 > > > > I successfully passed you previous patch test, but the new patch one > > with two =E2=80=9Cports=E2=80=9D fails. =20 >=20 > Trying to understand what is going on. Working on your latest test > patch. >=20 > This is what I currently have. It's not differ from your patch except > commented test below. guix/gnu/tests/rsync.scm > https://paste.pound-python.org/raw/ZyfPIvOWAbPd7blPRXf7/ >=20 > I fully commented > (test-equal "Test file correctly received from share" =E2=80=A6). >=20 > (test-assert "Test file copied to share" > =E2=80=A6 > (zero? ; ERROR HERE > (system* "rsync" "/tmp/input" "localhost::files/"))) >=20 > Bottom of test log: > --8<---------------cut here---------------start------------->8--- > rsync: mkstemp ".input.Y6OhRW" (in files) failed: Permission denied > (13) rsync error: some files/attrs were not transferred (see previous > errors) (code 23) at main.c(1178) [sender=3D3.1.2] QEMU runs as PID 5 > connected to QEMU's monitor > read QEMU monitor prompt > connected to guest REPL > %%%% Starting test rsync (Writing full log to "rsync.log") > marionette is ready > /gnu/store/bm3kvdwh8q3spvhxbmpmcjwz3fng8z5f-rsync-test-builder:1: > FAIL Test file copied to share # of expected passes 2 > # of unexpected failures 1 > note: keeping build directory `/tmp/guix-build-rsync-test.drv-9' > builder for > `/gnu/store/1hv9c616m9xkgi549hgbn1y2vr8mnzfr-rsync-test.drv' failed > with exit code 1 @ > build-failed /gnu/store/1hv9c616m9xkgi549hgbn1y2vr8mnzfr-rsync-test.drv > - 1 builder for > `/gnu/store/1hv9c616m9xkgi549hgbn1y2vr8mnzfr-rsync-test.drv' failed > with exit code 1 TOTAL: 1 > FAIL: /gnu/store/s0rwmr3iha48jbw2b9xkzcqqsamdl21q-rsync-test make: > *** [Makefile:5217: check-system] Error 1 --8<---------------cut > here---------------end--------------->8--- With the change to add the uid to the rsync configuration file, the rsync-with-default-port passes for me. What test are you running here? > Also, I have (is related?) error on top of test log. > --8<---------------cut here---------------start------------->8--- > natsu@magnolia ~/src/guix$ ./pre-inst-env make check-system > TESTS=3Drsync-with-default-port Compiling Scheme modules... > warning: failed to load '(gnu tests admin)': > ERROR: In procedure allocate-struct: Wrong type argument in position > 2: 8 --8<---------------cut here---------------end--------------->8--- I think I may have seen this error too, no idea what it relates to though. --Sig_/DOe.QTcP7GQvFM+yDA0xb2f Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAlmOpzdfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XeLMA/+NDvstSJFyD/hXSNjeUblcVdrVRPHD6cXn5femSkImZQVQBoUSEERQG8w WDFlVcM6yeDe0jBbbqruHnpBbvxvjQ40kcq0OPJNtdLsQvmYm6rNJP6axTBNBNgs HZkJMAf6o7S7I1R76JaDHEsCodbppGw81GuRCaH/s1HlDdukswDO1h2iXAu3KzxJ JsKIY1MzJ85revxtyC76SnyeH48wSRKm6QBOnw23JudwGKkTunJ2l70r+XpKiho4 A6EyUnDvhbsuirWfF/NU6gB1TBg67DtvFkYzRxuB/iUg0toUYHxmVlHcp1qn50si C7YcYGEDvRnJRZ+g3ejw3SP94WWud5/NKBwu8X5RDD62ye3w/mbdMjYK5OEeB0iV jLSNe8lhf/IMv7NyeYJJu+30r9HM6cAV5FJg/uYnVpWo4Fqvxc8WStYZjgVPTp68 FW+rpmf2apcx2q03XDZ1APDOpa0pShGYcBYPAPAOJnzMGKuJ7wyBJWpJpOjI2IaL xTROr9ATLbZJBkLv1hHmyAYWJTEjeJl9nC394oeuLjiodmAP7JQcsNwRlCVBc1/k Sszk5UIkgr02np4lkxqHXFvI2s5H5m8hVAeIUgyRwetyT2eODB0JY+2iXdqrT07q AryVDolBX3jTxVJY74nySyx918i7RfWN2KDwCQVJhVgIHF0PeJo= =V3bK -----END PGP SIGNATURE----- --Sig_/DOe.QTcP7GQvFM+yDA0xb2f--