From mboxrd@z Thu Jan 1 00:00:00 1970 From: ng0 Subject: continued discussion on git commit messages Date: Fri, 11 Aug 2017 08:55:48 +0000 Message-ID: <20170811085548.2sk77bfwuw3ip5u3@abyayala> References: <87wp6ekkef.fsf@gmail.com> <4b50a45a.ADkAACnAL5YAAAAAAAAAAAPejtMAAAACwQwAAAAAAAW9WABZjCOA@mailjet.com> <20170810120612.bi33kbdswgtktohr@abyayala> <20170810165517.nojmfy7j4busmwao@abyayala> <9b857f17.AEQAOV3jPRoAAAAAAAAAAAPU5Q8AAAACwQwAAAAAAAW9WABZjJhx@mailjet.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="2hdbnd4u7sfujmuj" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:55953) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dg5js-000314-F2 for guix-devel@gnu.org; Fri, 11 Aug 2017 04:56:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dg5jp-00052x-RB for guix-devel@gnu.org; Fri, 11 Aug 2017 04:56:16 -0400 Received: from aibo.runbox.com ([91.220.196.211]:50378) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dg5jp-00052U-JQ for guix-devel@gnu.org; Fri, 11 Aug 2017 04:56:13 -0400 Content-Disposition: inline In-Reply-To: List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Arun Isaac , guix-devel@gnu.org --2hdbnd4u7sfujmuj Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable It makes more sense to move this to guix-devel, the bug is finished. Arun Isaac transcribed 1.6K bytes: >=20 > Tobias Geerinckx-Rice writes: >=20 > >> Also, having a staging branch to which all commits are made would help > >> keep the master branch clean, and free of these mishaps. But, I guess > >> this issue has been raised before, and the creation of such a staging > >> branch has been postponed. > > > > Interesting. Do you have a link? We do have a =E2=80=98staging=E2=80=99= branch, but it > > serves a different purpose (basically, =E2=80=98core-updates=E2=80=99, = lite). >=20 > I was referring to this thread discussing the stability of master. It's > not about any staging branch like I proposed, but there are some > similarities. >=20 > https://lists.gnu.org/archive/html/guix-devel/2017-07/msg00021.html >=20 > > Since the commit message is already reviewed on the mailing list, such a > > branch would only catch the =E2=80=94 one hopes =E2=80=94 very rare las= t-minute foul-up > > by the committer themselves. > > > > =E2=80=98Someone=E2=80=99 would have to keep track of, review, and merg= e it. =E2=80=98People=E2=80=99 > > would then start following that branch instead of master (Why let a typo > > keep me from the shiny?), making rebasing just as painful. >=20 > Agreed. >=20 > > I'm less opposed to an optional hook, but fear that it will discourage > > committers from making a habit of checking all their commits before that > > last and final push. Which they should definitely be doing. >=20 > Despite these concerns, I think it is still worth automating some commit > checks. Given long enough time, even the most careful person is likely > to mess up somewhere. That's what I (although very obscure) meant to express with my grumpy comments a while back. We could have a bot merging this after checks have been run (mostly what I was concerned with is health of repository and general build checks). Ludovic said we'd need to change large parts of our workflow for this, and someone needs to work on getting this implemented. > > (That's not a dig at you or anyone personally =E2=80=94 you're talking = to the > > reason for the /current/ pre-push hook, after all :-) >=20 > No issues! :-) >=20 >=20 >=20 >=20 --=20 ng0 GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588 GnuPG: https://n0is.noblogs.org/my-keys https://www.infotropique.org https://krosos.org --2hdbnd4u7sfujmuj Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEqIyK3RKYKNfqwC5S4i+bv+40hYgFAlmNcRQACgkQ4i+bv+40 hYibAA/6A5cixwxG1t8ytGlrBfP6jWBZN14LxBHlb4l/88aULmYdhFN+/mrAGnY3 qqNxcnqbuF9GhG2cOPPL4KcweoS++abn4yqlNZkkEfA+SDJIxn/2Zx84QYeMkk5w 8ODSro7yKBOXycMO5yZw/+V5jMl5DDOvYVQW85dg4qPYTnxMaDcqJ24ohArxmbzA CIjILhHETA6G8U596PT0Rrmy0vSVRig9oMTCEa4SKkOQMqjQm4yxFma1BIPbOyHp CmuerBDL1/wGQDBLJjAj0GBhE2mPdssTYuTRDJjZrTm3EWNhEVkPvhz4TWQNpNOC pIEZkFn6wgK9aNoXpOLXEjQETJm2ilACsVjdsUKlKb8qXZlFVGURHucvWmAINkeB V7fEbjRJTFvZNTUB2hfQQTppcLar+fLuRVDVboqIPYQ8WMbQ/V4SzhrLs+Bm+mcw Eagqgu93zrg70/iOuKw6bX2N5M9i8kr+VfGPG90NmNvnMHdb3GlThseygoMEvUhv qEX48uFCl57wJv9AgbAz4zhi2Rx9KX5Rc/R9kGVz8TVRf2piPlN3wcih0cO88gHT fmTLJ2R6Wb3Ezvg0aPR+Ga1ijoFG1S0LBBqfaSfWPacWM3fx+yHZEweBQ2G7ApBu IVD/gxW/9DTkylySlILrOnjvU/wspJrmXeRTjAZIjxu4a+kvl8w= =CVQF -----END PGP SIGNATURE----- --2hdbnd4u7sfujmuj--