[bug#28020] [PATCH] gnu: Add emacs-gitpatch.

[ng0 <ng0@infotropique.org>]

[-- Attachment #1: Type: text/plain, Size: 1731 bytes --]

Arun Isaac transcribed 1.3K bytes:
> 
> ng0 writes:
> 
> >     gnu: Add emacs-gitpatch.
> >
> >     By the way, “gitpatch.el” says different version than release tarball.
> >     Do I need to ask a developer?
> >     --8<---------------cut here---------------start------------->8---
> >     ;; Author: Feng Shu <tumashu@163.com>
> >     ;; Homepage: https://github.com/tumashu/gitpatch
> >     ;; Keywords: convenience
> >     ;; Package-Requires: ((emacs "24.3"))
> >     ;; Version: 0.10
> >     --8<---------------cut here---------------end--------------->8---
> >
> >     >From 9eddf07fa401468738c2f48a25e51ddef2a3ceed Mon Sep 17 00:00:00 2001
> >     From: Oleg Pykhalov <go.wigust@gmail.com>
> >     Date: Sat, 29 Jul 2017 14:22:48 +0300
> >     Subject: [PATCH] gnu: Add emacs-gitpatch.
> >
> >     * gnu/packages/emacs.scm (emacs-gitpatch): New variable.
> >
> >     Signed-off-by: Arun Isaac <arunisaac@systemreboot.net>
> >
> > I appreciate the concerns, but
> > I don't think the complete paragraph of "By the way…" should be in the
> > commit message. Please place notes like this as "XXX: ..." or "TODO: ..."
> > in the code if possible.
> > Or is there any reason why this landed in the commit message?
> 
> Oops! I didn't notice it was there. Looks like I screwed up big time
> while applying the patch. There's no way to change the commit message
> now, is there?
> 

No, don't worry there are some other misshapenings in the commit log.
Mistakes can happen. Though it would be nice to have a checker for this
somehow...
-- 
ng0
GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
GnuPG: https://n0is.noblogs.org/my-keys
https://www.infotropique.org https://krosos.org

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]