From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54894) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1df5PW-00034h-Qb for guix-patches@gnu.org; Tue, 08 Aug 2017 10:23:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1df5PS-0002CG-AT for guix-patches@gnu.org; Tue, 08 Aug 2017 10:23:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:43433) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1df5PS-0002Bk-5i for guix-patches@gnu.org; Tue, 08 Aug 2017 10:23:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1df5PR-0006mW-W3 for guix-patches@gnu.org; Tue, 08 Aug 2017 10:23:02 -0400 Subject: [bug#28004] Chromium Resent-Message-ID: Date: Tue, 8 Aug 2017 14:22:23 +0000 From: ng0 Message-ID: <20170808142223.re52odap7y32eten@abyayala> References: <87y3qvb15k.fsf@fastmail.com> <20170807202341.5c54jx4mpudor47i@abyayala> <87shh3axjf.fsf@fastmail.com> <20170808131801.snryxiiehczhnibr@abyayala> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="xkknvqa42h2lusi5" Content-Disposition: inline In-Reply-To: <20170808131801.snryxiiehczhnibr@abyayala> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Marius Bakke , 28004@debbugs.gnu.org --xkknvqa42h2lusi5 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable ng0 transcribed 3.4K bytes: > Marius Bakke transcribed 2.4K bytes: > > ng0 writes: > >=20 > > > Hi Marius, > > > > > > Marius Bakke transcribed 43K bytes: > > >> Hello Guix! > > >>=20 > > >> Attached is a patch for Chromium, a popular web browser. > > > > > > Nice! I've been using this from your branch for a while now, > > > works just fine :) > > > Is this not affected by the chromium discussion which happened > > > a while back? Can we include this? I'm all for this, because I > > > mainly use it for websites where firefox/icecat doesn't work so > > > well, and building it locally takes a very long time. > >=20 > > I believe this is within the Free System Distribution Guidelines. DRM > > ("Widevine") is disabled at build time, and the Web Store is > > non-functional without the end user explicitly enabling it. > >=20 > > There are some grey areas though. The browser may interact with certain > > non-free APIs (apart from regular browser duties) such as translation or > > prediction services. These features are optional, but some are enabled > > by default, and difficult to maintain patches for (I've tried). > >=20 > > However, I have verified that it does not send any unsolicited requests > > with the current command-line options, apart from the very first launch > > which spawns a login prompt (help wanted!). Without either of those > > flags the browser "calls home" every time it starts. > >=20 > > >> Note that I cannot guarantee timely delivery of security updates. Ma= jor > > >> version upgrades are hugely painful, and almost always contain many > > >> high-severity fixes. Should we mention that in the description? > > >>=20 > > >> Happy for any feedback. > > >>=20 > > > > > > Shouldn't you mention defines in addition to the define-public aswell, > > > or don't we do that? > >=20 > > Not for new files (modules), typically. I don't think Magit can fill out > > those variable names (by pressing C on the hunks) either ;-) But it > > should probably go in web-browsers.scm anyway. >=20 > Unless someone else is already building this, I'm giving it a spin. >=20 > I guess you changed some things since the version of yours I have in > here: https://gitlab.com/ng0_guix/packages/blob/master/ng0/packages/chrom= ium.scm > so I have to rebuild it. > It might take a while because I'm offloading to something much slower > but which doesn't care about heat as much as a this one ;) Patch itself LGTM, I'm now waiting on the build to finish in the next couple of hours. Thanks for your work on this! --=20 ng0 GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588 GnuPG: https://n0is.noblogs.org/my-keys https://www.infotropique.org https://krosos.org --xkknvqa42h2lusi5 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEqIyK3RKYKNfqwC5S4i+bv+40hYgFAlmJyR8ACgkQ4i+bv+40 hYgTTw//fB8XVC9a/WYkzW3eJWQ6zfBgXRwRYjb+dO48WHdmzbkxfs4ub5vwcOce SQeJg1Dj2JwkxSlJYvxAa9Gadh2LiXNyaBhqlAEWdmesDcF2CPAlDicw2uADUMTu JFKyA0HkJLnSaTWaD4THqGTpDX6vLcnEDEbCNp9bisJQqky4S955zIz4QWf7VbTa +7p854l36h91aUW5VYHQFTH5jMgMBVt4UIlhWrEbAV7CQE5u0Jv3Bfa8Tq1qlmM4 oXEC1tCorK39vbnW4Op2/YnWA5C3DfdNIPgikmMuKq4jwZO4ECR+S99DRY/6i/Mn cCbonTt/hFaVG4DHvaru5DSAVx2tzszO8EFj3uGBt2CacFkfYmouHzDL+D24AhVD xlFnO5XZIilvq9jo+BFUu5D7LwbvsqX1ohjSxmBo5SC3W1riMB554/dc+01OjIhr AsXjhEGR4r5p0O56k5ks7vW2jdRWOfhfgGkuarr4rmO0AixH8XDQfW7B07OwOzBq TWECe3q8+PoeSrHT+4WPrnmpAB2XGRLp1x4TYEAC0DN//jqthnGcrdSdWV5cdC6Y kTMoa2P6UzGzZcoAADLzm6mWlHlDSuasQbgeavAD/bglM+f4ShIlluQNNSSEByDE 7xJi/gcq+T+zeWMLnLzn5ERLEhg/M5XuT82tbsPmuOCzbMlkwpw= =XXF+ -----END PGP SIGNATURE----- --xkknvqa42h2lusi5--