From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42396) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1df52J-0000D9-NS for guix-patches@gnu.org; Tue, 08 Aug 2017 09:59:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1df52E-00026x-VP for guix-patches@gnu.org; Tue, 08 Aug 2017 09:59:07 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:43419) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1df52E-00025h-IL for guix-patches@gnu.org; Tue, 08 Aug 2017 09:59:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1df52E-0006DT-3q for guix-patches@gnu.org; Tue, 08 Aug 2017 09:59:02 -0400 Subject: [bug#27983] [PATCH] gnu: googletest: Build shared libraries. Resent-Message-ID: Date: Tue, 8 Aug 2017 09:58:03 -0400 From: Leo Famulari Message-ID: <20170808135803.GA8806@jasmine.lan> References: <20170806141217.14626-1-manolis837@gmail.com> <20170807182248.GC10622@jasmine.lan> <0ee7654f-0abe-c9c4-597e-df2007e72164@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="tThc/1wpZn/ma/RB" Content-Disposition: inline In-Reply-To: <0ee7654f-0abe-c9c4-597e-df2007e72164@gmail.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Manolis Ragkousis Cc: 27983@debbugs.gnu.org --tThc/1wpZn/ma/RB Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Aug 08, 2017 at 02:31:51PM +0300, Manolis Ragkousis wrote: > Hello Leo >=20 > On 08/07/2017 09:22 PM, Leo Famulari wrote: > > On Sun, Aug 06, 2017 at 05:12:17PM +0300, manolis837@gmail.com wrote: > >> From: Manolis Ragkousis > >> > >> * gnu/packages/check.scm (googletest)[arguments]: Pass "-DBUILD_SHARED= _LIBS=3DON" > >> in #:configure-flags. > >=20 > > Does it still build the static library in this case? If not, do packages > > that are currently using googletest need to be adjusted? > >=20 >=20 > No it doesn't but I rebuilt all the packages that depend on googletest > and everything built and worked the same. No need for anything to be > adjusted. Okay then, LGTM! --tThc/1wpZn/ma/RB Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAlmJw10ACgkQJkb6MLrK fwjHZxAAxJohtqCcqFvHEUmJu3poxuznUrD5qw7NLWLnVG9FYsHwIyfhli4x/SxP m5xYul8rkmyanDMYoBOxYVGFslZ3Pvcr4dRoxUAnfEbUYeNjqVtekhWHalKvZfc3 nIWUGBoBIU4N3KuyPwigrfUafvrmj40pZA2JdvMDR8ckEWuCX2WuhzBSl10ubBuI BFxempWsZX2Go8XDBe6wHFCExvY+bl1O8uLV7jAkujrtKPJUMCtwtqlvoKNSA9/Y /Pm4C1uSCQFSzzbD/esFfJReZ1ZX3WgV0hr4QqZMCUJ2KuD2pR9OjOe0VHdpzyNy rQ65OGNxDEwFRQXfMIDwc6msTfvT4pQfywRE0jZRYfMsz2juL+9I68wsAVd7wJQa QyNyy1m9YgM4naSjN7gfD7I69en8BJLDau3ysxLKdIn4wECH1JuGjW2GNyuubidf BCpBCp3WtztBmIAr46Dt1NGXKh8qoD18PUY1JA/9F4twnCEaFTx9o4RKa0b/i9PZ T528lz6TqDfJaHe/WHU3UJJzSQlVFJwNFM2oKCgDlpOWPxW+VpqNmS5Au4fxc7uU knTwqIh5nCYGxNLBsUaa+tqJE8FoUVnDCBrBNCHxmxWScee2H7ruUFnuqXXArLKC Kg+Xx4PHU3/W8/mwv77q+ExjsFp15abGZNtLa7/mvPyaEPrXJGk= =ShYs -----END PGP SIGNATURE----- --tThc/1wpZn/ma/RB--